bruno-roustant commented on PR #2038:
URL: https://github.com/apache/solr/pull/2038#issuecomment-1779592475
Could you create a JIRA issue for this PR to give it more visibility?
I agree it's only a cleanup, but since I investigated to be sure of the dead
code removal, for me it means it's
bruno-roustant commented on code in PR #2038:
URL: https://github.com/apache/solr/pull/2038#discussion_r1371992238
##
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java:
##
@@ -883,8 +836,7 @@ private void checkReplicationTracker(UpdateCommand
pvcnt commented on code in PR #2038:
URL: https://github.com/apache/solr/pull/2038#discussion_r1368299063
##
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java:
##
@@ -883,8 +836,7 @@ private void checkReplicationTracker(UpdateCommand cmd) {
pvcnt commented on code in PR #2038:
URL: https://github.com/apache/solr/pull/2038#discussion_r1368298738
##
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java:
##
@@ -786,52 +784,7 @@ protected List setupRequest(
// that means I want
pvcnt commented on code in PR #2038:
URL: https://github.com/apache/solr/pull/2038#discussion_r1368298223
##
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java:
##
@@ -212,13 +212,11 @@ public void processCommit(CommitUpdateCommand cmd) throws
pvcnt opened a new pull request, #2038:
URL: https://github.com/apache/solr/pull/2038
# Description
There is dead code and duplicate code in DistributedZkUpdateProcessor. This
PR removes some of it.
# Solution
Please provide a short description of the approac
