dsmiley merged PR #3343:
URL: https://github.com/apache/solr/pull/3343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #3343:
URL: https://github.com/apache/solr/pull/3343#issuecomment-2896434937
This change is ready to go. Barring further feedback to the contrary, I'll
merge in 2 days and back-port to 9x. No JIRA/changes.txt for thsi refactoring.
--
This is an automated message
dsmiley commented on PR #3343:
URL: https://github.com/apache/solr/pull/3343#issuecomment-2872795385
Note: precommit fails because ECJ Lint is configured for Java 17 for all
modules; not allowing 21 in server modules like "core". I root caused that and
submitted a PR to Lucene: https://git
dsmiley commented on code in PR #3343:
URL: https://github.com/apache/solr/pull/3343#discussion_r2078575879
##
solr/core/src/java/org/apache/solr/search/SortSpecParsing.java:
##
@@ -220,6 +185,40 @@ private static SortSpec parseSortSpecImpl(
return new SortSpec(s, fields);
dsmiley opened a new pull request, #3343:
URL: https://github.com/apache/solr/pull/3343
This pull request refactors the Solr codebase to streamline the handling of
`ValueSource` and `Query` objects by introducing a new `parseAsValueSource`
method. This change reduces redundancy, simplifies
