Re: [PR] POC: Test picocli [solr]

2025-03-11 Thread via GitHub
janhoy commented on PR #3247: URL: https://github.com/apache/solr/pull/3247#issuecomment-2711920203 Eric, you have really lifted the CLI in the last versions, none of which is wasted if/when moving to picocli! Also, we have pretty good test coverage in bats tests, which is a great way

Re: [PR] POC: Test picocli [solr]

2025-03-11 Thread via GitHub
epugh commented on PR #3247: URL: https://github.com/apache/solr/pull/3247#issuecomment-2713435505 > Eric, you have really lifted the CLI in the last versions, none of which is wasted if/when moving to picocli! > > Also, we have pretty good test coverage in bats tests, which is a grea

Re: [PR] POC: Test picocli [solr]

2025-03-10 Thread via GitHub
epugh commented on code in PR #3247: URL: https://github.com/apache/solr/pull/3247#discussion_r1987164110 ## solr/core/src/java/org/apache/solr/cli/HealthcheckTool.java: ## @@ -227,6 +250,20 @@ protected void runCloudTool(CloudSolrClient cloudSolrClient, CommandLine cli) th

[PR] POC: Test picocli [solr]

2025-03-08 Thread via GitHub
janhoy opened a new pull request, #3247: URL: https://github.com/apache/solr/pull/3247 This is not intended for merge, more to spark a discussion about replacing commons-cli with [picocli](https://picocli.info) in bin/solr. This PR does the following * Parses `bin/solr` with picocl