Re: [PR] Move EnvToSyspropMappings.properties to solrj module [solr]

2024-03-07 Thread via GitHub
janhoy commented on PR #2320: URL: https://github.com/apache/solr/pull/2320#issuecomment-1983311288 Related JIRA just opened: https://issues.apache.org/jira/browse/SOLR-17199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Move EnvToSyspropMappings.properties to solrj module [solr]

2024-03-05 Thread via GitHub
janhoy merged PR #2320: URL: https://github.com/apache/solr/pull/2320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Move EnvToSyspropMappings.properties to solrj module [solr]

2024-02-28 Thread via GitHub
janhoy commented on PR #2320: URL: https://github.com/apache/solr/pull/2320#issuecomment-1969969831 Created SOLR-17188 to track creation of such as new test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Move EnvToSyspropMappings.properties to solrj module [solr]

2024-02-28 Thread via GitHub
janhoy commented on PR #2320: URL: https://github.com/apache/solr/pull/2320#issuecomment-1969962794 I discovered this by chance. Obviously all our solrJ tests run with access to solr-core on classpath? We should likely have a test with only SolrJ and its dependencies on classpath? --

[PR] Move EnvToSyspropMappings.properties to solrj module [solr]

2024-02-28 Thread via GitHub
janhoy opened a new pull request, #2320: URL: https://github.com/apache/solr/pull/2320 I discovered that the properties file `EnvToSyspropMappings.properties` required by the new `EnvUtils` (SOLR-15960) was located in `core`. But since `EnvUtils` class is in `solrj` and will fail static `in