epugh merged PR #2162:
URL: https://github.com/apache/solr/pull/2162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
cdrini commented on code in PR #2162:
URL: https://github.com/apache/solr/pull/2162#discussion_r1517147908
##
solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc:
##
@@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the
list of constraints to
|O
cdrini commented on code in PR #2162:
URL: https://github.com/apache/solr/pull/2162#discussion_r1517147908
##
solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc:
##
@@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the
list of constraints to
|O
cdrini commented on PR #2162:
URL: https://github.com/apache/solr/pull/2162#issuecomment-1985016847
Thanks for the review @cpoerschke ! Ok @epugh , this should be ready to go
now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
cdrini commented on code in PR #2162:
URL: https://github.com/apache/solr/pull/2162#discussion_r1517147908
##
solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc:
##
@@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the
list of constraints to
|O
cdrini commented on PR #2162:
URL: https://github.com/apache/solr/pull/2162#issuecomment-1985010050
Ah apologies for the delay! Will update this week :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
epugh commented on PR #2162:
URL: https://github.com/apache/solr/pull/2162#issuecomment-1983459204
hey @cdrini do you want to take another spin though this PR and finalize
some of the changes? Then I'd love to merge this!
--
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on PR #2162:
URL: https://github.com/apache/solr/pull/2162#issuecomment-1982069707
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
cpoerschke commented on code in PR #2162:
URL: https://github.com/apache/solr/pull/2162#discussion_r1439672251
##
solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc:
##
@@ -113,7 +113,7 @@ This does not limit the query in any way, only the facets
that would be returned
cdrini commented on code in PR #2162:
URL: https://github.com/apache/solr/pull/2162#discussion_r1431585826
##
solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc:
##
@@ -149,7 +147,7 @@ Note that the default logic is changed when <
|Optional |Default: `100`
|===
+
-Th
cdrini commented on code in PR #2162:
URL: https://github.com/apache/solr/pull/2162#discussion_r1431574852
##
solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc:
##
@@ -149,7 +147,7 @@ Note that the default logic is changed when <
|Optional |Default: `100`
|===
+
-Th
janhoy commented on code in PR #2162:
URL: https://github.com/apache/solr/pull/2162#discussion_r1431049930
##
solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc:
##
@@ -396,7 +392,7 @@ To ensure you avoid double-counting, do not choose both
`lower` and `upper`, do
|Op
cdrini opened a new pull request, #2162:
URL: https://github.com/apache/solr/pull/2162
# Description
The parameters descriptions in the faceting docs begin inconsistently. Some
re-state the parameter names, some start with "This parameters...", etc.
# Solution
Make them
13 matches
Mail list logo
