Re: [PR] Extract duplicate code and move it to CollectionHandlingUtils [solr]

2023-11-27 Thread via GitHub
epugh merged PR #2044: URL: https://github.com/apache/solr/pull/2044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Extract duplicate code and move it to CollectionHandlingUtils [solr]

2023-11-22 Thread via GitHub
renatoh commented on code in PR #2044: URL: https://github.com/apache/solr/pull/2044#discussion_r1402482842 ## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ## @@ -450,6 +450,26 @@ static void processResponse( } } + static void

Re: [PR] Extract duplicate code and move it to CollectionHandlingUtils [solr]

2023-11-22 Thread via GitHub
epugh commented on code in PR #2044: URL: https://github.com/apache/solr/pull/2044#discussion_r1402161824 ## solr/core/src/java/org/apache/solr/cloud/OverseerConfigSetMessageHandler.java: ## @@ -98,6 +99,8 @@ public OverseerSolrResponse processMessage(ZkNodeProps message, Strin

Re: [PR] Extract duplicate code and move it to CollectionHandlingUtils [solr]

2023-11-22 Thread via GitHub
renatoh commented on PR #2044: URL: https://github.com/apache/solr/pull/2044#issuecomment-1822838682 @epugh Hey Eric This PR has been open for quite a while. Would you mind having a look at it?, Thanks! -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] Extract duplicate code and move it to CollectionHandlingUtils [solr]

2023-10-31 Thread via GitHub
renatoh commented on PR #2044: URL: https://github.com/apache/solr/pull/2044#issuecomment-1786687021 @risdenk Hey Kevin, would you mind having a look at this PR? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Extract duplicate code and move it to CollectionHandlingUtils [solr]

2023-10-26 Thread via GitHub
renatoh opened a new pull request, #2044: URL: https://github.com/apache/solr/pull/2044 I came across some duplicate code which I moved to the utils-class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t