Re: [PR] Avoid NPE if snapshotMgr failed during init [solr]

2024-11-21 Thread via GitHub
dsmiley commented on PR #2879: URL: https://github.com/apache/solr/pull/2879#issuecomment-2492460643 I pushed to 9x too: https://github.com/apache/solr/commit/119b98623cc47953111a64d9034af59726c9b9b8 Thanks. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Avoid NPE if snapshotMgr failed during init [solr]

2024-11-21 Thread via GitHub
dsmiley merged PR #2879: URL: https://github.com/apache/solr/pull/2879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Avoid NPE if snapshotMgr failed during init [solr]

2024-11-20 Thread via GitHub
AndreyBozhko commented on PR #2879: URL: https://github.com/apache/solr/pull/2879#issuecomment-2489578817 Thanks - it also seemed to me that the change is too minor to warrant a JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Avoid NPE if snapshotMgr failed during init [solr]

2024-11-19 Thread via GitHub
dsmiley commented on PR #2879: URL: https://github.com/apache/solr/pull/2879#issuecomment-2487554064 Thanks. Ideally add a JIRA & CHANGES.txt entry but I'm personally fine with simply merging this trivial change as-is. So if nobody says anything or you don't bother, that's what I'll do by

[PR] Avoid NPE if snapshotMgr failed during init [solr]

2024-11-19 Thread via GitHub
AndreyBozhko opened a new pull request, #2879: URL: https://github.com/apache/solr/pull/2879 https://issues.apache.org/jira/browse/SOLR-X # Description Avoid NPE when SolrCore is closing. If the snapshotMgr failed to initialize (e.g., because it didn't hav