Re: [PR] Add support for optional DBQ expansion. [solr-sandbox]

2023-11-28 Thread via GitHub
sigram merged PR #91: URL: https://github.com/apache/solr-sandbox/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] Add support for optional DBQ expansion. [solr-sandbox]

2023-11-27 Thread via GitHub
markrmiller commented on PR #91: URL: https://github.com/apache/solr-sandbox/pull/91#issuecomment-1828655126 Looks fine to me. We may want to make it an enum or something instead of a boolean though, so we are free to easily add further options. I haven't brought it over yet, but you can ac

Re: [PR] Add support for optional DBQ expansion. [solr-sandbox]

2023-11-27 Thread via GitHub
sigram commented on PR #91: URL: https://github.com/apache/solr-sandbox/pull/91#issuecomment-1827998881 If there are no objections I'd like to merge this soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] Add support for optional DBQ expansion. [solr-sandbox]

2023-11-20 Thread via GitHub
sigram opened a new pull request, #91: URL: https://github.com/apache/solr-sandbox/pull/91 This PR adds a boolean config option `expandDbq` (defaults to true) that allows to control whether Delete-By-Query should be expanded on the source-side into a series of Delete-By-Ids. There are trade