Re: [PR] Add DateRangeField example to Ref Guide [solr]

2024-03-02 Thread via GitHub
epugh merged PR #2330: URL: https://github.com/apache/solr/pull/2330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Add DateRangeField example to Ref Guide [solr]

2024-03-02 Thread via GitHub
epugh commented on PR #2330: URL: https://github.com/apache/solr/pull/2330#issuecomment-1974841764 Thank you @AndreyBozhko for following up from the other issue. I bumped the example up to give it a bit more prominance. Keep the improvements coming. In the future, I would love to r

Re: [PR] Add DateRangeField example to Ref Guide [solr]

2024-03-02 Thread via GitHub
epugh commented on code in PR #2330: URL: https://github.com/apache/solr/pull/2330#discussion_r1509997419 ## solr/solr-ref-guide/modules/indexing-guide/pages/date-formatting-math.adoc: ## @@ -217,4 +217,117 @@ Unlike most local params, `op` is actually _not_ defined by any quer

Re: [PR] Add DateRangeField example to Ref Guide [solr]

2024-03-02 Thread via GitHub
epugh commented on code in PR #2330: URL: https://github.com/apache/solr/pull/2330#discussion_r1509997243 ## solr/core/src/test/org/apache/solr/request/macro/TestMacroExpander.java: ## @@ -37,8 +37,7 @@ public void testExamples() { me = new MacroExpander(testParams, failO