[GitHub] [solr] risdenk commented on pull request #1076: Disable lift god classes

2022-10-17 Thread GitBox
risdenk commented on PR #1076: URL: https://github.com/apache/solr/pull/1076#issuecomment-1281276781 Well interestingly https://github.com/apache/solr/pull/1083 doesn't have this god classes message. So maybe it is disabled but some PRs pickup the old changes... -- This is an automated m

[GitHub] [solr] risdenk commented on pull request #1076: Disable lift god classes

2022-10-17 Thread GitBox
risdenk commented on PR #1076: URL: https://github.com/apache/solr/pull/1076#issuecomment-1281262377 @TomMD @chriswininger can either of you help with why this change didn't disable the god classes comment from Lift? This PR https://github.com/apache/solr/pull/1082 was created 2 hrs

[GitHub] [solr] risdenk commented on pull request #1076: Disable lift god classes

2022-10-15 Thread GitBox
risdenk commented on PR #1076: URL: https://github.com/apache/solr/pull/1076#issuecomment-1279831731 > um why did Lift do this? because it wasn't on main? eh going to merge this and see what happens. I read the Lift docs and no idea why this didn't work. -- This is an autom

[GitHub] [solr] risdenk commented on pull request #1076: Disable lift god classes

2022-10-14 Thread GitBox
risdenk commented on PR #1076: URL: https://github.com/apache/solr/pull/1076#issuecomment-1279453602 um why did Lift do this? because it wasn't on main? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL