[GitHub] [solr] joel-bernstein commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285592668 @HoustonPutman, I'll focus on the move to solrj-streaming since thats what is needed for 9x. For Solr 10 we can decide between a module or solr-core. I'm fine with either appro

[GitHub] [solr] joel-bernstein commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285561544 For this PR I'll focus on the move to solrj-streaming as that cleans things up in Solrj. I'll open another ticket to discuss the deprecation and creation of the server side mod

[GitHub] [solr] joel-bernstein commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285539059 It is possible that people are using a more broad set of classes on the client side. Which would indeed break if they are removed. So I see your point about waiting for 10 for splitti

[GitHub] [solr] joel-bernstein commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285530094 @risdenk, I'm curious why it all needs to stay client? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [solr] joel-bernstein commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285503975 As part of the solrj-streaming module I will add documentation for using the Java API. There is a massive amount of documentation for streaming expressions on the server side but noth

[GitHub] [solr] joel-bernstein commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285500456 If people are ok with this approach I will keep this PR alive and continue working on the server side module. Once thats done, I'll migrate a small set of classes to solrj-streaming.

[GitHub] [solr] joel-bernstein commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285498590 Another way to split the classes between server and client side module is any class that has a Java API test case can stay in Solrj. 98% of the classes only have streaming expression

[GitHub] [solr] joel-bernstein commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285488578 Ok, I like the idea of keeping a very small workable subset of classes in Solrj and moving the rest along with the /stream handler etc... to a server side module. The best supported T

[GitHub] [solr] joel-bernstein commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
joel-bernstein commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285456616 Before I close this PR and start to work on a solrj-streaming PR lets be sure we don't want this to be server module. The original streaming classes were designed to be a Java A