[GitHub] [solr] athrog commented on pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-27 Thread GitBox
athrog commented on pull request #271: URL: https://github.com/apache/solr/pull/271#issuecomment-907338957 It looks good to me! I assume you've tested it end to end with s3mock and real s3? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [solr] athrog commented on pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on pull request #271: URL: https://github.com/apache/solr/pull/271#issuecomment-905759932 Regarding > One thing I couldn't find a similar setting for in the v2 client was: (not sure if this is actually an issue or not) > new ClientConfiguration().withProtocol(Prot