[GitHub] [solr] NazerkeBS commented on pull request #977: Add shard-split.adoc

2022-09-20 Thread GitBox
NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1252515608 > RE documentation getting out of date: I think it's important to link _to_ this documentation to help its discoverability and to reduce the chances it won't be noticed if splits are updated

[GitHub] [solr] NazerkeBS commented on pull request #977: Add shard-split.adoc

2022-09-16 Thread GitBox
NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1249377813 > Thanks for the detailed doc, @NazerkeBS ! > > I've left review comments but additionally, it'd be best to mention that this explanation assumes the user is splitting the parent shard

[GitHub] [solr] NazerkeBS commented on pull request #977: Add shard-split.adoc

2022-09-14 Thread GitBox
NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1246901949 > This has been out for a while I'm thinking that it's worth committing? Any other changes you want? No changes so far -- This is an automated message from the Apache Git Servic

[GitHub] [solr] NazerkeBS commented on pull request #977: Add shard-split.adoc

2022-09-06 Thread GitBox
NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1238258620 > maybe adding the `documentation` label would bring in more reviewers? I didn't create a jira issue for this; not sure if it is worth it. -- This is an automated message from the A

[GitHub] [solr] NazerkeBS commented on pull request #977: Add shard-split.adoc

2022-09-06 Thread GitBox
NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1238257202 > Also, did you drop an explicit note to dev mailing list? yes, i did; it has a title `Shard Split Documentation`. -- This is an automated message from the Apache Git Service. To res

[GitHub] [solr] NazerkeBS commented on pull request #977: Add shard-split.adoc

2022-08-19 Thread GitBox
NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1221067939 @shalinmangar @sigram hi, mentioning you because from the git history it seems you worked on shard split at some point in the past. Wondering if you could give some feedback on this doc ?

[GitHub] [solr] NazerkeBS commented on pull request #977: Add shard-split.adoc

2022-08-18 Thread GitBox
NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1219473264 > LGTM. I can't validate the content accuracy, as this is an area I don't know about, but in terms of reading it, it all makes sense as presented! Thank you Eric for having a look! Yes