[GitHub] [solr] HoustonPutman commented on pull request #1094: SOLR-15733: WIP

2022-10-20 Thread GitBox
HoustonPutman commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1285573279 This sounds good to me, although I'm not sure why the streaming expressions stuff would really need to go into a module instead of solr-core. Does it require any dependencies that Solr

[GitHub] [solr] HoustonPutman commented on pull request #1094: SOLR-15733: WIP

2022-10-19 Thread GitBox
HoustonPutman commented on PR #1094: URL: https://github.com/apache/solr/pull/1094#issuecomment-1284588558 Agreed, modules is not for solrj code, its for server modules. We don't have a solrj folder that hosts sub-folders yet (but we will starting in Solr 10), so it should just be called `s