[jira] [Commented] (SOLR-16562) Upgrade to Caffeine 3.1.2

2022-12-26 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652115#comment-17652115 ] Ben Manes commented on SOLR-16562: -- Note that this version metadata will be removed in t

[jira] [Commented] (SOLR-16562) Upgrade to Caffeine 3.1.2

2022-11-28 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640229#comment-17640229 ] Ben Manes commented on SOLR-16562: -- To clarify, the change is to detect keys that were m

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-23 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638081#comment-17638081 ] Ben Manes commented on SOLR-15859: -- You still have the bug of replacing the counter on e

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-23 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638042#comment-17638042 ] Ben Manes commented on SOLR-15859: -- Sorry, I linked to the wrong file and fixed it. You

[jira] [Comment Edited] (SOLR-15859) Add handler to dump filter cache

2022-11-23 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638034#comment-17638034 ] Ben Manes edited comment on SOLR-15859 at 11/24/22 1:54 AM: C

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-23 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17638034#comment-17638034 ] Ben Manes commented on SOLR-15859: -- Caffeine offers getIfPresentQuietly in the policy ap

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-23 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637994#comment-17637994 ] Ben Manes commented on SOLR-15859: -- The estimated size can include expired entries. I'd

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-23 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637993#comment-17637993 ] Ben Manes commented on SOLR-15859: -- What is the cache size? You can log with a listener

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-23 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637981#comment-17637981 ] Ben Manes commented on SOLR-15859: -- It depends on what you mean. The cache will suppress

[jira] [Commented] (SOLR-16546) Faceting puts an entry for each q into the filterCache

2022-11-19 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636241#comment-17636241 ] Ben Manes commented on SOLR-16546: -- The algorithm achieves a hit rate that is the at or

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-13 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633548#comment-17633548 ] Ben Manes commented on SOLR-15859: -- Sorry, since I do not develop Solr, I don't know. Th

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-13 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633522#comment-17633522 ] Ben Manes commented on SOLR-15859: -- The method is called when the key is present so that

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-13 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633423#comment-17633423 ] Ben Manes commented on SOLR-15859: -- Each time {{computeIfAbsent}} is called you replace

[jira] [Comment Edited] (SOLR-15859) Add handler to dump filter cache

2022-11-13 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633402#comment-17633402 ] Ben Manes edited comment on SOLR-15859 at 11/13/22 9:33 PM: b

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-13 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633402#comment-17633402 ] Ben Manes commented on SOLR-15859: -- > I figured that my synchronization additions wouldn

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-13 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633401#comment-17633401 ] Ben Manes commented on SOLR-15859: -- You can either change the logic to {{Cache>}} or use

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-13 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633394#comment-17633394 ] Ben Manes commented on SOLR-15859: -- As I mentioned, you need to also add your changes in

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-13 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633390#comment-17633390 ] Ben Manes commented on SOLR-15859: -- I believe many of Solr's usages switched to {{comput

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-13 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17633382#comment-17633382 ] Ben Manes commented on SOLR-15859: -- [~elyograg] can you attach your patch file? It looks

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-11 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632560#comment-17632560 ] Ben Manes commented on SOLR-15859: -- Caffeine doesn’t maintain that level of detail. It’s

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-11-11 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632549#comment-17632549 ] Ben Manes commented on SOLR-15859: -- Caffeine keeps the accumulated hit count in Cache.st

[jira] [Commented] (SOLR-15859) Add handler to dump filter cache

2022-07-29 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17573176#comment-17573176 ] Ben Manes commented on SOLR-15859: -- - {{Caffeine.recordStats()}} enables basic statistic

[jira] [Commented] (SOLR-15555) Use filterCache.computeIfAbsent in SolrIndexSearcher

2021-09-19 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417292#comment-17417292 ] Ben Manes commented on SOLR-1: -- If you perform recursive computations, then that mus

[jira] [Commented] (SOLR-15555) Use filterCache.computeIfAbsent in SolrIndexSearcher

2021-07-28 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389110#comment-17389110 ] Ben Manes commented on SOLR-1: -- Yes, that is true for all of the adapted methods. Th

[jira] [Commented] (SOLR-15555) Use filterCache.computeIfAbsent in SolrIndexSearcher

2021-07-28 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17389056#comment-17389056 ] Ben Manes commented on SOLR-1: -- Those are all available and can be accessed through

[jira] [Commented] (SOLR-15555) Use filterCache.computeIfAbsent in SolrIndexSearcher

2021-07-28 Thread Ben Manes (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17388944#comment-17388944 ] Ben Manes commented on SOLR-1: -- This looks similar to an {{AsyncCache}}, which store