[jira] [Commented] (SOLR-17775) Optimize ValueSourceAugmenter

2025-06-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956481#comment-17956481 ] ASF subversion and git services commented on SOLR-17775: Commit 0

[jira] [Resolved] (SOLR-17775) Optimize ValueSourceAugmenter

2025-06-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17775. - Fix Version/s: 9.9 Resolution: Fixed Thanks for contributing! > Optimize ValueSourceAugme

[jira] [Updated] (SOLR-17775) Optimize ValueSourceAugmenter -- fl function query

2025-06-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-17775: Summary: Optimize ValueSourceAugmenter -- fl function query (was: Optimize ValueSourceAugmenter)

[jira] [Commented] (SOLR-17775) Optimize ValueSourceAugmenter

2025-06-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956474#comment-17956474 ] ASF subversion and git services commented on SOLR-17775: Commit 5

Re: [PR] SOLR-17775: optimize ValueSourceAugmenter [solr]

2025-06-05 Thread via GitHub
dsmiley merged PR #3380: URL: https://github.com/apache/solr/pull/3380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Optimize no rows only count [solr]

2025-06-05 Thread via GitHub
risdenk commented on PR #2655: URL: https://github.com/apache/solr/pull/2655#issuecomment-2947341362 Probably I totally forgot about this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] SOLR-17776: Harmonize SolrJ timeouts [solr]

2025-06-05 Thread via GitHub
dsmiley commented on code in PR #3357: URL: https://github.com/apache/solr/pull/3357#discussion_r2130726121 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java: ## @@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) { return

Re: [PR] SOLR-17776: Harmonize SolrJ timeouts [solr]

2025-06-05 Thread via GitHub
dsmiley commented on code in PR #3357: URL: https://github.com/apache/solr/pull/3357#discussion_r2130657407 ## solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/SolrClientCache.java: ## @@ -205,19 +205,13 @@ private static Http2SolrClient.Builder newHttp2SolrClientB

Re: [PR] SOLR-17776: Harmonize SolrJ timeouts [solr]

2025-06-05 Thread via GitHub
dsmiley commented on code in PR #3357: URL: https://github.com/apache/solr/pull/3357#discussion_r2130676326 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java: ## @@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) { return

Re: [PR] Optimize no rows only count [solr]

2025-06-05 Thread via GitHub
HoustonPutman commented on PR #2655: URL: https://github.com/apache/solr/pull/2655#issuecomment-2946576965 @risdenk should we move forward with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] SOLR-17776: Harmonize SolrJ timeouts [solr]

2025-06-05 Thread via GitHub
dsmiley commented on code in PR #3357: URL: https://github.com/apache/solr/pull/3357#discussion_r2130373395 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -129,6 +126,12 @@ protected Http2SolrClient(String serverBaseUrl, Builder builder) {

Re: [PR] SOLR-17776: Harmonize SolrJ timeouts [solr]

2025-06-05 Thread via GitHub
kotman12 commented on code in PR #3357: URL: https://github.com/apache/solr/pull/3357#discussion_r2129982207 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java: ## @@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) { retur

Re: [PR] SOLR-17776: Harmonize SolrJ timeouts [solr]

2025-06-05 Thread via GitHub
kotman12 commented on code in PR #3357: URL: https://github.com/apache/solr/pull/3357#discussion_r2129982207 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java: ## @@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) { retur

Re: [PR] SOLR-17776: Harmonize SolrJ timeouts [solr]

2025-06-05 Thread via GitHub
kotman12 commented on code in PR #3357: URL: https://github.com/apache/solr/pull/3357#discussion_r2129982207 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java: ## @@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) { retur

[jira] [Updated] (SOLR-17776) Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolrClient timeouts

2025-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17776: -- Labels: pull-request-available (was: ) > Harmonize SolrJ Http2SolrClient (Jetty) & HttpJdkSolr

Re: [PR] SOLR-17776: Harmonize SolrJ timeouts [solr]

2025-06-05 Thread via GitHub
kotman12 commented on code in PR #3357: URL: https://github.com/apache/solr/pull/3357#discussion_r2129941025 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderBase.java: ## @@ -115,38 +121,49 @@ public B withMaxConnectionsPerHost(int max) { retur

Re: [PR] SOLR-17678, SOLR-17732: Add matchScore support for ReRank queries [solr]

2025-06-05 Thread via GitHub
dsmiley commented on code in PR #3222: URL: https://github.com/apache/solr/pull/3222#discussion_r2129848607 ## solr/core/src/java/org/apache/solr/search/SolrReturnFields.java: ## @@ -50,6 +51,7 @@ public class SolrReturnFields extends ReturnFields { // Special Field Keys

Re: [PR] SOLR-17678, SOLR-17732: Add matchScore support for ReRank queries [solr]

2025-06-05 Thread via GitHub
HoustonPutman commented on code in PR #3222: URL: https://github.com/apache/solr/pull/3222#discussion_r2129734839 ## solr/core/src/java/org/apache/solr/search/SolrReturnFields.java: ## @@ -50,6 +51,7 @@ public class SolrReturnFields extends ReturnFields { // Special Field Ke

Re: [PR] SOLR-17678, SOLR-17732: Add matchScore support for ReRank queries [solr]

2025-06-05 Thread via GitHub
HoustonPutman commented on code in PR #3222: URL: https://github.com/apache/solr/pull/3222#discussion_r2129733214 ## solr/core/src/java/org/apache/solr/search/SolrReturnFields.java: ## @@ -50,6 +51,7 @@ public class SolrReturnFields extends ReturnFields { // Special Field Ke

Re: [PR] SOLR-17775: optimize ValueSourceAugmenter [solr]

2025-06-05 Thread via GitHub
dsmiley commented on PR #3380: URL: https://github.com/apache/solr/pull/3380#issuecomment-2945417091 I mispoke/misunderstood... thinking this would work for a `fl=aDvField` when no, that's handled by `SolrDocumentFetcher` `org.apache.solr.search.SolrDocumentFetcher#decorateDocValueFields`.

Re: [PR] SOLR-17775: optimize ValueSourceAugmenter [solr]

2025-06-05 Thread via GitHub
yurkor commented on PR #3380: URL: https://github.com/apache/solr/pull/3380#issuecomment-2945085396 @dsmiley Done. Will keep in mind - no force pushes) Usually it even worse - with single commit. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Created] (SOLR-17781) Add support for binary quantized dense vectors

2025-06-05 Thread Kevin Liang (Jira)
Kevin Liang created SOLR-17781: -- Summary: Add support for binary quantized dense vectors Key: SOLR-17781 URL: https://issues.apache.org/jira/browse/SOLR-17781 Project: Solr Issue Type: New Featu

[jira] [Commented] (SOLR-17631) Upgrade main to Lucene 10.x

2025-06-05 Thread Kevin Liang (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17956360#comment-17956360 ] Kevin Liang commented on SOLR-17631: Can this ticket be re-purposed for bumping to Lu

[jira] [Created] (SOLR-17780) Add support for scalar quantized dense vectors

2025-06-05 Thread Kevin Liang (Jira)
Kevin Liang created SOLR-17780: -- Summary: Add support for scalar quantized dense vectors Key: SOLR-17780 URL: https://issues.apache.org/jira/browse/SOLR-17780 Project: Solr Issue Type: New Featu

[jira] [Updated] (SOLR-17780) Add support for scalar quantized dense vectors

2025-06-05 Thread Kevin Liang (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Liang updated SOLR-17780: --- Labels: vector-based-search (was: ) > Add support for scalar quantized dense vectors > -

Re: [PR] SOLR-17775: optimize ValueSourceAugmenter [solr]

2025-06-05 Thread via GitHub
dsmiley commented on PR #3380: URL: https://github.com/apache/solr/pull/3380#issuecomment-2944125812 OMG I'm slipping... you already have a CHANGES.txt. Nonetheless my feedback shows a massive difference between the actual code change (what you wrote about there) and how users understand/e

Re: [PR] SOLR-17775: optimize ValueSourceAugmenter [solr]

2025-06-05 Thread via GitHub
dsmiley commented on PR #3380: URL: https://github.com/apache/solr/pull/3380#issuecomment-2944112030 Great! (BTW, stop force-pushing to PRs. It resets the GH review state, therefore, as a reviewer, I can't as easily clearly see your changes from one change to the next). CHANGES.txt: