Re: [PR] SOLR-17379: Fix date parsing in Java 23, remove Lucene TestSecurityManager [solr]

2025-02-03 Thread via GitHub
epugh commented on code in PR #3154: URL: https://github.com/apache/solr/pull/3154#discussion_r1940367902 ## solr/core/src/test/org/apache/solr/update/processor/ParsingFieldUpdateProcessorsTest.java: ## @@ -1064,43 +1065,37 @@ public void testAKSTZone() throws IOException {

Re: [PR] SOLR-17351: Decompose filestore "get file" API [solr]

2025-02-03 Thread via GitHub
gerlowskija commented on code in PR #3047: URL: https://github.com/apache/solr/pull/3047#discussion_r1940306565 ## solr/solr-ref-guide/modules/configuration-guide/pages/package-manager-internals.adoc: ## @@ -115,7 +115,7 @@ openssl dgst -sha1 -sign my_key.pem runtimelibs.jar |

Re: [PR] SOLR-17351: Decompose filestore "get file" API [solr]

2025-02-03 Thread via GitHub
gerlowskija commented on code in PR #3047: URL: https://github.com/apache/solr/pull/3047#discussion_r1940305756 ## solr/core/src/java/org/apache/solr/packagemanager/PackageManager.java: ## @@ -173,7 +173,7 @@ public void uninstall(String packageName, String version) Str

Re: [PR] SOLR-17351: Decompose filestore "get file" API [solr]

2025-02-03 Thread via GitHub
gerlowskija commented on code in PR #3047: URL: https://github.com/apache/solr/pull/3047#discussion_r1940305043 ## solr/core/src/java/org/apache/solr/filestore/NodeFileStore.java: ## @@ -76,135 +66,54 @@ public SolrJerseyResponse getFile(String path, Boolean sync, String getFro

Re: [PR] SOLR-17379: Fix date parsing in Java 23, remove Lucene TestSecurityManager [solr]

2025-02-03 Thread via GitHub
HoustonPutman commented on PR #3154: URL: https://github.com/apache/solr/pull/3154#issuecomment-2632468777 Aha! Tracked it down to `BasicAuthIntegrationTest`. Wow these tests... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (SOLR-17641) Support Java 24

2025-02-03 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923508#comment-17923508 ] Gus Heck commented on SOLR-17641: - Opensearch folks had a large discussion about the disa

[jira] [Commented] (SOLR-17646) DirectoryFactory should support any NIO FileSystemProvider

2025-02-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923506#comment-17923506 ] David Smiley commented on SOLR-17646: - For sure, NIOFSDirectoryFactory, StandardDirec

Re: [PR] SOLR-17641: Disable the Security Manager for Java 24+ [solr]

2025-02-03 Thread via GitHub
madrob commented on PR #3153: URL: https://github.com/apache/solr/pull/3153#issuecomment-2632357157 Agree with @epugh - isn't Security Manager all no-ops even with 21 (which IIRC is the minimum Java for Solr 10) -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] SOLR-17379: Fix date parsing in Java 23, remove Lucene TestSecurityManager [solr]

2025-02-03 Thread via GitHub
HoustonPutman commented on PR #3154: URL: https://github.com/apache/solr/pull/3154#issuecomment-2632284025 Nvm, replicated it locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (SOLR-17334) Minor bugs in Solr dedicated coordinator mode

2025-02-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923498#comment-17923498 ] David Smiley commented on SOLR-17334: - Neither linked PRs are merged. I think the co

Re: [PR] SOLR-17379: Fix date parsing in Java 23, remove Lucene TestSecurityManager [solr]

2025-02-03 Thread via GitHub
HoustonPutman commented on PR #3154: URL: https://github.com/apache/solr/pull/3154#issuecomment-2632228099 This fails every time on Crave, because a grade test runner is returning an exit code of "1". This doesn't replicate for me, but it is suspicious given that `TestSecurityManager` does

[jira] [Commented] (SOLR-17650) Determine executor for UpdateLog reading

2025-02-03 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923488#comment-17923488 ] Houston Putman commented on SOLR-17650: --- Currently the buffered update tests ( {{T

[jira] [Created] (SOLR-17650) Determine executor for UpdateLog reading

2025-02-03 Thread Houston Putman (Jira)
Houston Putman created SOLR-17650: - Summary: Determine executor for UpdateLog reading Key: SOLR-17650 URL: https://issues.apache.org/jira/browse/SOLR-17650 Project: Solr Issue Type: Improveme

[jira] [Commented] (SOLR-17497) Pull replicas throws AlreadyClosedException

2025-02-03 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923454#comment-17923454 ] Houston Putman commented on SOLR-17497: --- Should we resolve this with a fix version?

[jira] [Commented] (SOLR-17641) Support Java 24

2025-02-03 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923453#comment-17923453 ] Houston Putman commented on SOLR-17641: --- I will raise it, but it's not really a dec

[jira] [Commented] (SOLR-17641) Support Java 24

2025-02-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923445#comment-17923445 ] David Smiley commented on SOLR-17641: - Please raise in dev list for visibility of a k

Re: [PR] SOLR-17582: Stream CLUSTERSTATUS API for SolrJ version >= 9.9 [solr]

2025-02-03 Thread via GitHub
dsmiley commented on code in PR #3156: URL: https://github.com/apache/solr/pull/3156#discussion_r1939799714 ## solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java: ## @@ -975,7 +975,7 @@ public Map execute( CLUSTERSTATUS, (req, rsp, h) -> {

Re: [PR] SOLR-17648: multiThreaded=true: changed queue implementation [solr]

2025-02-03 Thread via GitHub
dsmiley commented on code in PR #3155: URL: https://github.com/apache/solr/pull/3155#discussion_r1939755482 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -228,25 +229,15 @@ public static ExecutorService initCollectorExecutor(NodeConfig cfg) {

Re: [PR] SOLR-17582: Stream CLUSTERSTATUS API for SolrJ version >= 9.9 [solr]

2025-02-03 Thread via GitHub
mlbiscoc commented on PR #3156: URL: https://github.com/apache/solr/pull/3156#issuecomment-2631588200 Meant to put into draft. A few more things I need to add. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] SOLR-17582: Stream CLUSTERSTATUS API for SolrJ version >= 9.9 [solr]

2025-02-03 Thread via GitHub
mlbiscoc opened a new pull request, #3156: URL: https://github.com/apache/solr/pull/3156 https://issues.apache.org/jira/browse/SOLR-17582 # Description Check for SolrJ version from a cluster status request user agent header to stream the response for any SolrJ clients >= 9.9 al

Re: [PR] feat(update-security-json): Update security.json when secret is updated [solr-operator]

2025-02-03 Thread via GitHub
mcarroll1 commented on code in PR #744: URL: https://github.com/apache/solr-operator/pull/744#discussion_r1939622256 ## controllers/util/solr_security_util.go: ## @@ -240,11 +245,16 @@ func cmdToPutSecurityJsonInZk() string { cmd := " solr zk cp zk:/security.json /tmp/cu

Re: [PR] feat(update-security-json): Update security.json when secret is updated [solr-operator]

2025-02-03 Thread via GitHub
mcarroll1 commented on code in PR #744: URL: https://github.com/apache/solr-operator/pull/744#discussion_r1939611644 ## api/v1beta1/solrcloud_types.go: ## @@ -1621,6 +1624,15 @@ const ( Basic AuthenticationType = "Basic" ) +type BootstrapSecurityJson struct { Review

Re: [PR] SOLR-17641: Disable the Security Manager for Java 24+ [solr]

2025-02-03 Thread via GitHub
malliaridis commented on code in PR #3153: URL: https://github.com/apache/solr/pull/3153#discussion_r1939602273 ## solr/bin/solr.cmd: ## @@ -94,7 +94,10 @@ IF NOT DEFINED SOLR_SSL_RELOAD_ENABLED ( set "SOLR_SSL_RELOAD_ENABLED=true" ) -REM Enable java security manager by de

Re: [PR] feat(update-security-json): Update security.json when secret is updated [solr-operator]

2025-02-03 Thread via GitHub
mcarroll1 commented on code in PR #744: URL: https://github.com/apache/solr-operator/pull/744#discussion_r1939586626 ## config/crd/bases/solr.apache.org_solrclouds.yaml: ## @@ -10205,29 +10205,37 @@ spec: description: |- Configure a us

Re: [PR] remove deprecated KnnVectorField use [solr]

2025-02-03 Thread via GitHub
cpoerschke merged PR #3121: URL: https://github.com/apache/solr/pull/3121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] in tests replace deprecated IndexSearcher.doc() calls [solr]

2025-02-03 Thread via GitHub
cpoerschke commented on code in PR #3149: URL: https://github.com/apache/solr/pull/3149#discussion_r1939515949 ## solr/core/src/test/org/apache/solr/legacy/TestNumericRangeQuery32.java: ## @@ -183,12 +183,12 @@ private void testRange(int precisionStep) throws Exception {

[jira] [Updated] (SOLR-17649) Multivalue facets on enum field type returns empty result when using JsonFacet

2025-02-03 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wöckinger updated SOLR-17649: Description: When using JsonFacet API on a multivalued EnumFieldType with facet method 'en

[jira] [Updated] (SOLR-17649) Multivalue facets on enum field type returns empty result when using JsonFacet

2025-02-03 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wöckinger updated SOLR-17649: Description: When using JsonFacet api on a multivalued EnumFieldType with facet method 'en

[jira] [Updated] (SOLR-17649) Multivalue facets on enum field type returns empty result when using JsonFacet

2025-02-03 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Wöckinger updated SOLR-17649: Description: When using JsonFacet api on a multivalued EnumFieldType with facet method 'en

[jira] [Created] (SOLR-17649) Multivalue facets on enum field type returns empty result when using JsonFacet

2025-02-03 Thread Jira
Thomas Wöckinger created SOLR-17649: --- Summary: Multivalue facets on enum field type returns empty result when using JsonFacet Key: SOLR-17649 URL: https://issues.apache.org/jira/browse/SOLR-17649 Pr

Re: [PR] SOLR-17648: multiThreaded=true: changed queue implementation [solr]

2025-02-03 Thread via GitHub
sigram commented on code in PR #3155: URL: https://github.com/apache/solr/pull/3155#discussion_r1939248091 ## solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java: ## @@ -228,25 +229,15 @@ public static ExecutorService initCollectorExecutor(NodeConfig cfg) {