Re: [PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2025-01-30 Thread via GitHub
dsmiley commented on code in PR #2924: URL: https://github.com/apache/solr/pull/2924#discussion_r1936591016 ## solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java: ## @@ -410,7 +410,9 @@ private void upgradeToManagedSchema() { "nor under SolrC

[PR] Add NavigableObject.wrap. Deprecate MapWriter.EMPTY and MapWriterMap. [solr]

2025-01-30 Thread via GitHub
dsmiley opened a new pull request, #3148: URL: https://github.com/apache/solr/pull/3148 Introduce NavigableObject.wrap to coerce its arg to a NavigableObject. Maybe call this method "of"? Deprecate MapWriter.EMPTY; don't need it anymore (due to the above); was only used once. Enhance

Re: [PR] SOLR-16953: Grouped fields are handled in edismax clauses [solr]

2025-01-30 Thread via GitHub
github-actions[bot] closed pull request #1893: SOLR-16953: Grouped fields are handled in edismax clauses URL: https://github.com/apache/solr/pull/1893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] SOLR-17015: Test and fix bug in MoveReplicaCmd for PRS collections [solr]

2025-01-30 Thread via GitHub
github-actions[bot] closed pull request #1986: SOLR-17015: Test and fix bug in MoveReplicaCmd for PRS collections URL: https://github.com/apache/solr/pull/1986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] SOLR-17015: Test and fix bug in MoveReplicaCmd for PRS collections [solr]

2025-01-30 Thread via GitHub
github-actions[bot] commented on PR #1986: URL: https://github.com/apache/solr/pull/1986#issuecomment-2625974285 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This

Re: [PR] SOLR-16932: expose `AsyncTracker`'s max outstanding async req limit config in `Http2SolrClient` [solr]

2025-01-30 Thread via GitHub
github-actions[bot] closed pull request #2313: SOLR-16932: expose `AsyncTracker`'s max outstanding async req limit config in `Http2SolrClient` URL: https://github.com/apache/solr/pull/2313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] SOLR-16427: Enable error-prone ClassInitializationDeadlock rule [solr]

2025-01-30 Thread via GitHub
github-actions[bot] commented on PR #2881: URL: https://github.com/apache/solr/pull/2881#issuecomment-2625973468 This PR has had no activity for 60 days and is now labeled as stale. Any new activity will remove the stale label. To attract more reviewers, please tag people who might be fam

Re: [PR] SOLR-16953: Grouped fields are handled in edismax clauses [solr]

2025-01-30 Thread via GitHub
github-actions[bot] commented on PR #1893: URL: https://github.com/apache/solr/pull/1893#issuecomment-2625974639 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This

Re: [PR] SOLR-16932: expose `AsyncTracker`'s max outstanding async req limit config in `Http2SolrClient` [solr]

2025-01-30 Thread via GitHub
github-actions[bot] commented on PR #2313: URL: https://github.com/apache/solr/pull/2313#issuecomment-2625974050 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This

Re: [PR] SOLR-17623: Simple ordered map should implement map [solr]

2025-01-30 Thread via GitHub
dsmiley commented on PR #3048: URL: https://github.com/apache/solr/pull/3048#issuecomment-2625909437 As you are a very new contributor, I can tell by your changes and your last question that you have not been running `./gradlew precommit`, which will detect issues that you can correct befor

[jira] [Commented] (SOLR-17619) Generate CHANGELOG.md (formerly CHANGES.txt) via logchange

2025-01-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922529#comment-17922529 ] Jan Høydahl commented on SOLR-17619: Or we could start encouraging committers to also

[jira] [Resolved] (SOLR-17637) HttpShardHandler can wait indefinitely when retrying after certain failures

2025-01-30 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-17637. --- Fix Version/s: 9.8.1 Assignee: Houston Putman Resolution: Fixed > HttpShardHa

Re: [PR] SOLR-17623: Simple ordered map should implement map [solr]

2025-01-30 Thread via GitHub
renatoh commented on PR #3048: URL: https://github.com/apache/solr/pull/3048#issuecomment-2625544960 > I removed the asShallowMap returning SimpleOrderedMap so such a decision can be in Solr 10. I intend on merging this when the tests pass and back porting to 9x. Today/tomorrow. Thanks agai

[jira] [Commented] (SOLR-17637) HttpShardHandler can wait indefinitely when retrying after certain failures

2025-01-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922527#comment-17922527 ] ASF subversion and git services commented on SOLR-17637: Commit f

[jira] [Updated] (SOLR-17642) Knn queries use multi threaded search unintentionally

2025-01-30 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-17642: - Affects Version/s: 9.8 9.7 > Knn queries use multi threaded search uninten

[jira] [Updated] (SOLR-17642) Knn queries use multi threaded search unintentionally

2025-01-30 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-17642: - Description: First reported on [https://lists.apache.org/thread/xn1xg5szxhrs0sbcy4gmx4cvohy6flvh

[jira] [Commented] (SOLR-17619) Generate CHANGELOG.md (formerly CHANGES.txt) via logchange

2025-01-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922520#comment-17922520 ] David Smiley commented on SOLR-17619: - As this tool forces us to put some structural

[jira] [Created] (SOLR-17642) Knn queries use multi threaded search unintentionally

2025-01-30 Thread Varun Thacker (Jira)
Varun Thacker created SOLR-17642: Summary: Knn queries use multi threaded search unintentionally Key: SOLR-17642 URL: https://issues.apache.org/jira/browse/SOLR-17642 Project: Solr Issue Ty

[jira] [Commented] (SOLR-17582) CLUSTERSTATUS API could stream the response to save memory

2025-01-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922517#comment-17922517 ] David Smiley commented on SOLR-17582: - Yes you are seeing my vision here :-). Also se

[jira] [Commented] (SOLR-17637) HttpShardHandler can wait indefinitely when retrying after certain failures

2025-01-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922516#comment-17922516 ] ASF subversion and git services commented on SOLR-17637: Commit 9

[jira] [Commented] (SOLR-17637) HttpShardHandler can wait indefinitely when retrying after certain failures

2025-01-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922513#comment-17922513 ] ASF subversion and git services commented on SOLR-17637: Commit d

Re: [PR] SOLR-17637: Fix LBHttpSolrClient & HttpShardHandler bug [solr]

2025-01-30 Thread via GitHub
HoustonPutman merged PR #3147: URL: https://github.com/apache/solr/pull/3147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

Re: [PR] SOLR-17623: Simple ordered map should implement map [solr]

2025-01-30 Thread via GitHub
dsmiley commented on PR #3048: URL: https://github.com/apache/solr/pull/3048#issuecomment-2625396992 I removed the asShallowMap returning SimpleOrderedMap so such a decision can be in Solr 10. I intend on merging this when the tests pass and back porting to 9x. Today/tomorrow. Thanks

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-30 Thread via GitHub
gus-asf commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2625369713 > (not thinking of backwards compatibility here, just thinking holistically) > > I appreciate that there are very different causes of a terminated request, and we want to differentiate

Re: [PR] SOLR-XXXXX: Support different filesystem implementations with EmbeddedSolrServer [solr]

2025-01-30 Thread via GitHub
dsmiley commented on code in PR #3146: URL: https://github.com/apache/solr/pull/3146#discussion_r1936130337 ## solr/CHANGES.txt: ## @@ -34,6 +34,8 @@ Improvements * SOLR-17516: `LBHttp2SolrClient` is now generic, adding support for `HttpJdkSolrClient`. (James Dyer) +* SOLR

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-30 Thread via GitHub
dsmiley commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2625311557 (not thinking of backwards compatibility here, just thinking holistically) I appreciate that there are very different causes of a terminated request, and we want to differentiate them

Re: [PR] SOLR-17637: Fix LBHttpSolrClient & HttpShardHandler bug [solr]

2025-01-30 Thread via GitHub
gus-asf commented on PR #3147: URL: https://github.com/apache/solr/pull/3147#issuecomment-2625307927 Nice catch! thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-30 Thread via GitHub
gus-asf commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1935871739 ## solr/core/src/java/org/apache/solr/search/EarlyTerminatingCollector.java: ## @@ -29,11 +30,15 @@ */ public class EarlyTerminatingCollector extends FilterCollector {

[I] Scaling Down Causes "Down" Replicas [solr-operator]

2025-01-30 Thread via GitHub
Kamalsaiperla opened a new issue, #754: URL: https://github.com/apache/solr-operator/issues/754 **Environment** Solr Operator Version: 0.8.1 → 0.9.0 (same issue) Solr Image Version: 9.6.1 Platform: GKE Custom Plugins: Yes HPA Configuration: Configured for CPU-based scaling

Re: [PR] SOLR-XXXXX: Support different filesystem implementations with EmbeddedSolrServer [solr]

2025-01-30 Thread via GitHub
epugh commented on code in PR #3146: URL: https://github.com/apache/solr/pull/3146#discussion_r1935674798 ## solr/CHANGES.txt: ## @@ -34,6 +34,8 @@ Improvements * SOLR-17516: `LBHttp2SolrClient` is now generic, adding support for `HttpJdkSolrClient`. (James Dyer) +* SOLR-X

Re: [PR] SOLR-XXXXX: Support different filesystem implementations with EmbeddedSolrServer [solr]

2025-01-30 Thread via GitHub
dsmiley commented on PR #3146: URL: https://github.com/apache/solr/pull/3146#issuecomment-2624996827 Probably need to wait for @mlbiscoc in https://github.com/apache/solr/pull/2924 which is touching lots of stuff. Then pick a particular String based API endpoint and convert it in an isolat

[jira] [Created] (SOLR-17641) Support Java 24

2025-01-30 Thread Houston Putman (Jira)
Houston Putman created SOLR-17641: - Summary: Support Java 24 Key: SOLR-17641 URL: https://issues.apache.org/jira/browse/SOLR-17641 Project: Solr Issue Type: Bug Components: SolrCLI,

Re: [PR] SOLR-XXXXX: Support different filesystem implementations with EmbeddedSolrServer [solr]

2025-01-30 Thread via GitHub
AndreyBozhko commented on PR #3146: URL: https://github.com/apache/solr/pull/3146#issuecomment-2624829745 Thanks - I just opened SOLR-17640 before reading your comment. Do you suggest this should go under SOLR-16903 instead? Or would you prefer to see a more comprehensive refactoring for Pa

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-30 Thread via GitHub
gus-asf commented on code in PR #2960: URL: https://github.com/apache/solr/pull/2960#discussion_r1935817655 ## solr/core/src/java/org/apache/solr/search/QueryResult.java: ## @@ -22,6 +22,7 @@ public class QueryResult { // Object for back compatibility so that we render true n

Re: [PR] SOLR-17447 : Support to early terminate a search based on maxHits per collector. [solr]

2025-01-30 Thread via GitHub
gus-asf commented on PR #2960: URL: https://github.com/apache/solr/pull/2960#issuecomment-2624803443 > > Overall this makes sense to me. Thanks for the nice contribution! I'd prefer if @gus-asf could take a look at some aspects since he worked on cpuAllowed recently. BTW it's clear you need

Re: [PR] SOLR-17492: Introduce recommendations of WAYS of running Solr from small to massive [solr]

2025-01-30 Thread via GitHub
epugh commented on PR #2783: URL: https://github.com/apache/solr/pull/2783#issuecomment-2624787972 This remains on my "must do" list for Solr 10, and I will pick it up as we get closer ;-). -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (SOLR-17640) Support different filesystem implementations with EmbeddedSolrServer

2025-01-30 Thread Andrey Bozhko (Jira)
Andrey Bozhko created SOLR-17640: Summary: Support different filesystem implementations with EmbeddedSolrServer Key: SOLR-17640 URL: https://issues.apache.org/jira/browse/SOLR-17640 Project: Solr

[jira] [Commented] (SOLR-16903) Use Path instead of File in Java Code

2025-01-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922399#comment-17922399 ] David Smiley commented on SOLR-16903: - BTW I don't think module-by-module is generall

Re: [PR] SOLR-XXXXX: Support different filesystem implementations with EmbeddedSolrServer [solr]

2025-01-30 Thread via GitHub
dsmiley commented on code in PR #3146: URL: https://github.com/apache/solr/pull/3146#discussion_r1935720303 ## solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java: ## @@ -148,12 +147,11 @@ public String lookupZKManagedSchemaPath() { */ public Path loo

[jira] [Commented] (SOLR-7504) Atomic Update causes solr.CountFieldValuesUpdateProcessorFactory to be wrong

2025-01-30 Thread Paul Heijman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922371#comment-17922371 ] Paul Heijman commented on SOLR-7504: This is still an issue in 9.6.1. It has nothing

[PR] Create 2025-01-30-how-to-use-apache-solr-request-parameters-api.md [solr-site]

2025-01-30 Thread via GitHub
lizbiella opened a new pull request, #142: URL: https://github.com/apache/solr-site/pull/142 added a blog post about request parameters api -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Created] (SOLR-17639) Upgrade Prometheus Java client to v1

2025-01-30 Thread Philipp Trulson (Jira)
Philipp Trulson created SOLR-17639: -- Summary: Upgrade Prometheus Java client to v1 Key: SOLR-17639 URL: https://issues.apache.org/jira/browse/SOLR-17639 Project: Solr Issue Type: Improvement

[jira] [Updated] (SOLR-17638) Some CLI errors not logged when starting prometheus exporter

2025-01-30 Thread Philipp Trulson (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Trulson updated SOLR-17638: --- Description: Hey everyone, we are currently upgrading our 8.11 setup to 9.8 and right now I'

[jira] [Created] (SOLR-17638) Some CLI errors not logged when starting prometheus exporter

2025-01-30 Thread Philipp Trulson (Jira)
Philipp Trulson created SOLR-17638: -- Summary: Some CLI errors not logged when starting prometheus exporter Key: SOLR-17638 URL: https://issues.apache.org/jira/browse/SOLR-17638 Project: Solr