[jira] [Commented] (SOLR-5970) Create collection API always has status 0

2024-12-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17908128#comment-17908128 ] David Smiley commented on SOLR-5970: When we don't know why the failure happens, a 400

Re: [PR] Feature/solr-17334 Minor bugs in Solr dedicated coordinator mode [solr]

2024-12-24 Thread via GitHub
mkhludnev commented on PR #2672: URL: https://github.com/apache/solr/pull/2672#issuecomment-2561400684 Doesn't it make sense to add a test confirming this functionality? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] SOLR-16903: Migrate off java.io.File to java.nio.file.Path from core files [solr]

2024-12-24 Thread via GitHub
mlbiscoc commented on code in PR #2924: URL: https://github.com/apache/solr/pull/2924#discussion_r1896910582 ## solr/core/src/java/org/apache/solr/core/SolrCore.java: ## @@ -1354,16 +1354,29 @@ public void initializeMetrics(SolrMetricsContext parentContext, String scope) {

Re: [PR] Coordinator: remove SolrQueryRequest.getCloudDescriptor [solr]

2024-12-24 Thread via GitHub
patsonluk commented on PR #2913: URL: https://github.com/apache/solr/pull/2913#issuecomment-2561336393 > @patsonluk do you know about this? **If** there's a problem, it's HttpShardHandler (the only caller) who passes this cloudDescriptor on to `org.apache.solr.handler.component.HttpShardHan

Re: [PR] SOLR-17582 Stream CLUSTERSTATUS API response [solr]

2024-12-24 Thread via GitHub
mlbiscoc commented on PR #2916: URL: https://github.com/apache/solr/pull/2916#issuecomment-2561331239 > Yes; as the code you modified in a ClusterStateProvider shows, the NamedList->Map happened and broke that code. > > You could add a check for {{params.get(CommonParams.WT)}} and che

Re: [PR] Feature/solr-17334 Minor bugs in Solr dedicated coordinator mode [solr]

2024-12-24 Thread via GitHub
patsonluk commented on PR #2672: URL: https://github.com/apache/solr/pull/2672#issuecomment-2561326911 Sorry about the delay! I was on vacation and somehow I missed this thread! To be honest I'm not totally sure why it returns null for non-select paths: ``` if (!path.endsWith

Re: [PR] Coordinator: remove SolrQueryRequest.getCloudDescriptor [solr]

2024-12-24 Thread via GitHub
dsmiley commented on code in PR #2913: URL: https://github.com/apache/solr/pull/2913#discussion_r1896868578 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -160,28 +156,13 @@ protected String getCoreOrColName() { return collectionName; }

Re: [PR] Coordinator: remove SolrQueryRequest.getCloudDescriptor [solr]

2024-12-24 Thread via GitHub
pvcnt commented on code in PR #2913: URL: https://github.com/apache/solr/pull/2913#discussion_r1896798141 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -160,28 +156,13 @@ protected String getCoreOrColName() { return collectionName; }

Re: [PR] Coordinator: remove SolrQueryRequest.getCloudDescriptor [solr]

2024-12-24 Thread via GitHub
pvcnt commented on code in PR #2913: URL: https://github.com/apache/solr/pull/2913#discussion_r1896798141 ## solr/core/src/java/org/apache/solr/servlet/CoordinatorHttpSolrCall.java: ## @@ -160,28 +156,13 @@ protected String getCoreOrColName() { return collectionName; }