dsmiley commented on PR #2764:
URL: https://github.com/apache/solr/pull/2764#issuecomment-2515726655
There is another problem I chased down. So I tried the schema designer
locally from this branch just to see if it was working. It's not, yet not
captured in a test failure (not good). The
cfeldmann created SOLR-17583:
Summary: Bring back documentation for Adding Custom Expressions
Key: SOLR-17583
URL: https://issues.apache.org/jira/browse/SOLR-17583
Project: Solr
Issue Type: Impro
HoustonPutman commented on PR #2875:
URL: https://github.com/apache/solr/pull/2875#issuecomment-2515161658
> One thing we'll probably want/need to come up with a better story around
is model-serving.
>
> Several places in our docs described using `` as a way not of loading
new JARs,
gerlowskija commented on code in PR #2876:
URL: https://github.com/apache/solr/pull/2876#discussion_r1868027727
##
solr/core/src/java/org/apache/solr/api/V2HttpCall.java:
##
@@ -434,7 +434,12 @@ protected void executeCoreRequest(SolrQueryResponse rsp) {
// SolrCore coun
gerlowskija commented on PR #2875:
URL: https://github.com/apache/solr/pull/2875#issuecomment-2514995493
One thing we'll probably want/need to come up with a better story around is
model-serving.
Several places in our docs described using `` as a way not of loading
new JARs, but of a
gerlowskija commented on code in PR #2875:
URL: https://github.com/apache/solr/pull/2875#discussion_r1868009405
##
solr/core/src/test-files/solr/configsets/upload/with-lib-directive/solrconfig.xml:
##
@@ -37,8 +37,6 @@
${tests.luceneMatchVersion:LATEST}
-
Review Commen
[
https://issues.apache.org/jira/browse/SOLR-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902695#comment-17902695
]
Eric Pugh commented on SOLR-17576:
--
Looking now.. I noticed that it had the annotation
gerlowskija commented on code in PR #2894:
URL: https://github.com/apache/solr/pull/2894#discussion_r1867906970
##
solr/core/src/test/org/apache/solr/cli/TestSolrCLIRunExample.java:
##
@@ -70,6 +72,7 @@ public static void beforeClass() {
Paths.get(".").toAbsolutePath().
iamsanjay commented on code in PR #2764:
URL: https://github.com/apache/solr/pull/2764#discussion_r1867908226
##
solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java:
##
Review Comment:
Yup failed!
```
./gradlew :solr:modules:sql:test --tests
"or
iamsanjay commented on code in PR #2764:
URL: https://github.com/apache/solr/pull/2764#discussion_r1867903389
##
solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java:
##
@@ -125,46 +119,22 @@ class SchemaDesignerConfigSetHelper implements
Schem
iamsanjay commented on code in PR #2764:
URL: https://github.com/apache/solr/pull/2764#discussion_r1867901890
##
solr/modules/sql/src/test/org/apache/solr/handler/sql/TestSQLHandler.java:
##
Review Comment:
Yeah this one I commented because somewhere in the code they
`Inpu
gerlowskija commented on code in PR #2894:
URL: https://github.com/apache/solr/pull/2894#discussion_r1867891294
##
solr/core/src/java/org/apache/solr/cli/RunExampleTool.java:
##
@@ -620,10 +620,15 @@ protected Map startSolr(
if (!isWindows && cwdPath.length() > 1 && solrHom
David Smiley created SOLR-17582:
---
Summary: CLUSTERSTATUS API could stream the response to save memory
Key: SOLR-17582
URL: https://issues.apache.org/jira/browse/SOLR-17582
Project: Solr
Issue T
[
https://issues.apache.org/jira/browse/SOLR-17574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902582#comment-17902582
]
David Smiley commented on SOLR-17574:
-
Even though this is a public method on Cluster
dsmiley commented on code in PR #2892:
URL: https://github.com/apache/solr/pull/2892#discussion_r1867487293
##
solr/CHANGES.txt:
##
@@ -229,6 +229,8 @@ Bug Fixes
* SOLR-17575: Fixed broken backwards compatibility with the legacy
"langid.whitelist" config in Solr Langid. (Jan
[
https://issues.apache.org/jira/browse/SOLR-17576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902323#comment-17902323
]
ASF subversion and git services commented on SOLR-17576:
Commit f
dsmiley commented on code in PR #2892:
URL: https://github.com/apache/solr/pull/2892#discussion_r1867330538
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -387,7 +386,7 @@ public boolean equals(Object obj) {
/** Internal API used only by ZkStat
epugh commented on PR #2835:
URL: https://github.com/apache/solr/pull/2835#issuecomment-2511772758
Okay, I've responded (I think!) to @risdenk comments.I think this is
ready for merging
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
18 matches
Mail list logo
