Re: [PR] SolrClientCache switch to Http2SolrClient [solr]

2024-11-28 Thread via GitHub
dsmiley commented on code in PR #2764: URL: https://github.com/apache/solr/pull/2764#discussion_r1862970143 ## solr/core/src/java/org/apache/solr/handler/designer/SchemaDesignerConfigSetHelper.java: ## @@ -525,40 +495,22 @@ void deleteStoredSampleDocs(String configSet) { @S

Re: [PR] SOLR-17571: Introduce dependabot [solr]

2024-11-28 Thread via GitHub
malliaridis commented on PR #2880: URL: https://github.com/apache/solr/pull/2880#issuecomment-2506862810 > A bonus that we get a "security" label on those PRs! I have also noticed that our labeler overrides the labels dependabot is setting. I couldn't find a way to configure the label

Re: [PR] SOLR-17571: Introduce dependabot [solr]

2024-11-28 Thread via GitHub
malliaridis commented on PR #2880: URL: https://github.com/apache/solr/pull/2880#issuecomment-2506858391 Current changes do not work for PRs outside the repository, so more work needs to be done on that "checkout latest changes" configuration. -- This is an automated message from the Apac

Re: [PR] SOLR-17571: Introduce dependabot [solr]

2024-11-28 Thread via GitHub
malliaridis commented on PR #2880: URL: https://github.com/apache/solr/pull/2880#issuecomment-2506857549 Sorry for the delayed update on this PR. I was testing on a separate project the configurations, and had to make further changes to make security updates actually work correctly.

[jira] [Commented] (SOLR-17306) Solr Repeater or Slave loses data after restart when replication is not enabled on leader

2024-11-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901805#comment-17901805 ] Jan Høydahl commented on SOLR-17306: I started the automatic tests on the PR. Looks l

Re: [PR] SOLR-17571: Introduce dependabot [solr]

2024-11-28 Thread via GitHub
janhoy commented on code in PR #2880: URL: https://github.com/apache/solr/pull/2880#discussion_r1862722863 ## .github/dependabot.yml: ## @@ -0,0 +1,83 @@ +# To get started with Dependabot version updates, you'll need to specify which +# package ecosystems to update and where the

[jira] [Resolved] (SOLR-17575) Solr Langid backwards compatibility with the legacy "langid.whitelist" is broken

2024-11-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17575. Fix Version/s: 9.8 Resolution: Fixed > Solr Langid backwards compatibility with the legacy "

Re: [PR] SOLR-16390: v2 Cluster Property APIs. [solr]

2024-11-28 Thread via GitHub
iamsanjay commented on PR #2788: URL: https://github.com/apache/solr/pull/2788#issuecomment-2506517753 Test Failing! ``` ./gradlew :solr:core:test --tests "org.apache.solr.handler.admin.api.ClusterPropsAPITest.testClusterPropertyOpsAllGood" -Ptests.jvms=96 "-Ptests.jvmargs=-XX:TieredS

[jira] [Updated] (SOLR-17578) Remove ZkController internal core supplier

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17578: -- Labels: pull-request-available (was: ) > Remove ZkController internal core supplier >

[PR] SOLR-17578: Remove ZkController internal core supplier. [solr]

2024-11-28 Thread via GitHub
psalagnac opened a new pull request, #2891: URL: https://github.com/apache/solr/pull/2891 https://issues.apache.org/jira/browse/SOLR-17578 # Description Code to list cores when re-restablishing Zookeeper session is bloated. # Solution Remove the bloated

Re: [PR] SOLR-17568: SolrCloud shouldn't proxy/route a core specific request [solr]

2024-11-28 Thread via GitHub
bruno-roustant commented on code in PR #2885: URL: https://github.com/apache/solr/pull/2885#discussion_r1862179675 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -1145,40 +1123,32 @@ protected String getRemoteCoreUrl(String collectionName, String origCor

Re: [PR] User Behavior Insights implementation for Apache Solr [solr]

2024-11-28 Thread via GitHub
epugh commented on PR #2452: URL: https://github.com/apache/solr/pull/2452#issuecomment-2506063447 Argh, a bit stuck. I can't figure out how to have the UBIComponent during a distributed query, look up the final doc id's and record them before sending them back to the user. With a single

Re: [PR] SOLR-17576: Remove deprecated master/slave support in ReplicationHandler [solr]

2024-11-28 Thread via GitHub
epugh commented on PR #2887: URL: https://github.com/apache/solr/pull/2887#issuecomment-2506020356 @gus-asf unfortuantly, I have to agree with you I'm going to redo this PR to seperate out the code cleanups from the deprecations. I just read @dsmiley link about "how to maintain fork

[jira] [Commented] (SOLR-17575) Solr Langid backwards compatibility with the legacy "langid.whitelist" is broken

2024-11-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901670#comment-17901670 ] ASF subversion and git services commented on SOLR-17575: Commit 8

[jira] [Assigned] (SOLR-17575) Solr Langid backwards compatibility with the legacy "langid.whitelist" is broken

2024-11-28 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-17575: -- Assignee: Jan Høydahl > Solr Langid backwards compatibility with the legacy "langid.whitelist"

[jira] [Commented] (SOLR-17575) Solr Langid backwards compatibility with the legacy "langid.whitelist" is broken

2024-11-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901651#comment-17901651 ] ASF subversion and git services commented on SOLR-17575: Commit c

Re: [PR] SOLR-17575: Fixed broken backwards compatibility with the legacy "langid.whitelist" config in Solr Langid [solr]

2024-11-28 Thread via GitHub
janhoy merged PR #2886: URL: https://github.com/apache/solr/pull/2886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Fix claim name in JWT Authentication Plugin docs [solr]

2024-11-28 Thread via GitHub
janhoy commented on PR #2890: URL: https://github.com/apache/solr/pull/2890#issuecomment-2505581546 Thanks for the fix. Merged and backported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Fix claim name in JWT Authentication Plugin docs [solr]

2024-11-28 Thread via GitHub
janhoy merged PR #2890: URL: https://github.com/apache/solr/pull/2890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org