Re: [PR] Backport: Update com.google.errorprone:* to 2.31.0 (#2862) [solr]

2024-11-14 Thread via GitHub
malliaridis merged PR #2863: URL: https://github.com/apache/solr/pull/2863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-11-14 Thread via GitHub
github-actions[bot] closed pull request #210: SOLR-13360: Collation code fails with non-increasing token order URL: https://github.com/apache/solr/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] SOLR-13360: Collation code fails with non-increasing token order [solr]

2024-11-14 Thread via GitHub
github-actions[bot] commented on PR #210: URL: https://github.com/apache/solr/pull/210#issuecomment-2477657205 This PR is now closed due to 60 days of inactivity after being marked as stale. Re-opening this PR is still possible, in which case it will be marked as active again. -- This i

[jira] [Commented] (SOLR-17541) LBSolrClient implementations should agree on 'getClient()' semantics

2024-11-14 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17898441#comment-17898441 ] James Dyer commented on SOLR-17541: --- Is this controversial? Can we choose to make the

Re: [PR] SOLR-17477: Support custom aggregates in plugin code [solr]

2024-11-14 Thread via GitHub
mkhludnev commented on PR #2742: URL: https://github.com/apache/solr/pull/2742#issuecomment-2477285696 > you can already achieve the desired results using the existing mechanism `type:func` Wait a sec. I read here https://solr.apache.org/guide/solr/latest/query-guide/json-facet-api.h

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-11-14 Thread via GitHub
gus-asf commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1842696769 ## dev-docs/dependency-upgrades.adoc: ## @@ -16,30 +16,34 @@ // specific language governing permissions and limitations // under the License. -Solr has lots of 3rd par

[jira] [Created] (SOLR-17562) Unify v2 API streaming support

2024-11-14 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17562: -- Summary: Unify v2 API streaming support Key: SOLR-17562 URL: https://issues.apache.org/jira/browse/SOLR-17562 Project: Solr Issue Type: Improvement

Re: [PR] SOLR-16470: Create V2 equivalent of V1 Replication: Get files/{filePath} [solr]

2024-11-14 Thread via GitHub
gerlowskija commented on PR #2734: URL: https://github.com/apache/solr/pull/2734#issuecomment-2476943623 After a bit of reading, I agree with Matt that StreamingOutput seems to be the "preferred" approach. The best explanation I could find on "why" comes from [this SO post](https://s

Re: [PR] SOLR-17406: Introduce Version Catalogs [solr]

2024-11-14 Thread via GitHub
gus-asf commented on code in PR #2706: URL: https://github.com/apache/solr/pull/2706#discussion_r1842431080 ## dev-docs/dependency-upgrades.adoc: ## @@ -16,30 +16,34 @@ // specific language governing permissions and limitations // under the License. -Solr has lots of 3rd par

Re: [PR] SOLR-16470: Create V2 equivalent of V1 Replication: Get files/{filePath} [solr]

2024-11-14 Thread via GitHub
mlbiscoc commented on PR #2734: URL: https://github.com/apache/solr/pull/2734#issuecomment-2476447405 > Alright, merged in the latest 'main' and synced it with the changes here. The only real change of note is that the interface file is now named 'ReplicationApis.java' (I went with the name