Re: [PR] Feature/solr-17334 Minor bugs in Solr dedicated coordinator mode [solr]

2024-09-17 Thread via GitHub
mkhludnev commented on PR #2672: URL: https://github.com/apache/solr/pull/2672#issuecomment-2357617808 I think it's fine to add CHANGES row and push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Update org.glassfish.jersey*:* to v3.1.7 [solr]

2024-09-17 Thread via GitHub
github-actions[bot] commented on PR #2396: URL: https://github.com/apache/solr/pull/2396#issuecomment-2357224214 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please t

Re: [PR] Update org.apache.hadoop:* to v3.4.0 [solr]

2024-09-17 Thread via GitHub
github-actions[bot] commented on PR #2380: URL: https://github.com/apache/solr/pull/2380#issuecomment-2357224245 This PR has had no activity for 60 days and is now labeled as stale. Any new activity or converting it to draft will remove the stale label. To attract more reviewers, please t

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-09-17 Thread via GitHub
epugh commented on code in PR #2479: URL: https://github.com/apache/solr/pull/2479#discussion_r1763521501 ## solr/solr-ref-guide/modules/query-guide/pages/stream-tool.adoc: ## @@ -0,0 +1,167 @@ += Stream Tool +// Licensed to the Apache Software Foundation (ASF) under one +// or

[jira] [Commented] (SOLR-17453) Replace CloudUtil.waitForState and some TimeOut with ZkStateReader.waitForState

2024-09-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882448#comment-17882448 ] David Smiley commented on SOLR-17453: - Sounds good Pierre; thanks for volunteering!

Re: [PR] help the next person when it comes to building the docs.. [solr]

2024-09-17 Thread via GitHub
epugh merged PR #2711: URL: https://github.com/apache/solr/pull/2711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Ref Guide Doc fixes to match on bin/solr post works in 9.7 [solr]

2024-09-17 Thread via GitHub
epugh merged PR #2713: URL: https://github.com/apache/solr/pull/2713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17256: Replace SolrRequest.setBasePath (PoC) [solr]

2024-09-17 Thread via GitHub
gerlowskija commented on code in PR #2714: URL: https://github.com/apache/solr/pull/2714#discussion_r1763347010 ## solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java: ## @@ -102,6 +111,24 @@ public static String buildRequestUrl( return basePath + path;

Re: [PR] SOLR-17256: Replace SolrRequest.setBasePath (PoC) [solr]

2024-09-17 Thread via GitHub
gerlowskija commented on code in PR #2714: URL: https://github.com/apache/solr/pull/2714#discussion_r1763347010 ## solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java: ## @@ -102,6 +111,24 @@ public static String buildRequestUrl( return basePath + path;

[jira] [Commented] (SOLR-17453) Replace CloudUtil.waitForState and some TimeOut with ZkStateReader.waitForState

2024-09-17 Thread Pierre Salagnac (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882401#comment-17882401 ] Pierre Salagnac commented on SOLR-17453: I was looking for a ticket with {{newdev

[jira] [Commented] (SOLR-17454) ERROR message in logs with multithreaded searches

2024-09-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882388#comment-17882388 ] David Smiley commented on SOLR-17454: - It's a sloppy practice but some devs do log.er

[jira] [Updated] (SOLR-17454) ERROR message in logs with multithreaded searches

2024-09-17 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-17454: --- Fix Version/s: 9.8 > ERROR message in logs with multithreaded searches >

[jira] [Commented] (SOLR-17454) ERROR message in logs with multithreaded searches

2024-09-17 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882387#comment-17882387 ] Christine Poerschke commented on SOLR-17454: Thanks [~ahankinson] for noticin

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-09-17 Thread via GitHub
cpoerschke commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1763201928 ## solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java: ## @@ -0,0 +1,423 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Updated] (SOLR-17385) coordinators don't support query requests that use any RH except /select

2024-09-17 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-17385: --- Fix Version/s: 9.8 > coordinators don't support query requests that use any RH except

[jira] [Updated] (SOLR-17334) Minor bugs in Solr dedicated coordinator mode

2024-09-17 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-17334: --- Fix Version/s: 9.8 > Minor bugs in Solr dedicated coordinator mode >

Re: [PR] Feature/solr-17334 Minor bugs in Solr dedicated coordinator mode [solr]

2024-09-17 Thread via GitHub
cpoerschke commented on PR #2672: URL: https://github.com/apache/solr/pull/2672#issuecomment-2355677750 Thanks @ellaeln for iterating on this PR, the CI is now green, yay! w.r.t. the remainder of the review(s) here -- unfortunately I'm not familiar enough with the area of the code to

Re: [PR] Blog post - Community Over Code NA 2024 [solr-site]

2024-09-17 Thread via GitHub
janhoy commented on PR #126: URL: https://github.com/apache/solr-site/pull/126#issuecomment-2355512296 I think this looks great! +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Blog post - Community Over Code NA 2024 [solr-site]

2024-09-17 Thread via GitHub
janhoy commented on code in PR #126: URL: https://github.com/apache/solr-site/pull/126#discussion_r1763113863 ## content/pages/blogposts/2024-09-16-community-over-code-north-america-2024.md: ## @@ -0,0 +1,43 @@ +Title: Join us at Community Over Code North America 2024 +category:

[jira] [Comment Edited] (SOLR-17256) Remove SolrRequest.getBasePath setBasePath

2024-09-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882373#comment-17882373 ] Jason Gerlowski edited comment on SOLR-17256 at 9/17/24 11:36 AM: -

[jira] [Commented] (SOLR-17256) Remove SolrRequest.getBasePath setBasePath

2024-09-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882373#comment-17882373 ] Jason Gerlowski commented on SOLR-17256: I actually played with that approach ini

[jira] [Updated] (SOLR-17455) Docs say we have tracing based on OpenTracing

2024-09-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17455: --- Fix Version/s: main (10.0) > Docs say we have tracing based on OpenTracing >

[jira] [Commented] (SOLR-17455) Docs say we have tracing based on OpenTracing

2024-09-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882331#comment-17882331 ] Jan Høydahl commented on SOLR-17455: It is actually correct to mention OpenTracing fo

[jira] [Updated] (SOLR-17455) Docs say we have tracing based on OpenTracing

2024-09-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17455: --- Affects Version/s: main (10.0) (was: 9.7) > Docs say we have tracing based

Re: [PR] SOLR-17432: Allow OTel Java Agent [solr]

2024-09-17 Thread via GitHub
janhoy commented on PR #2687: URL: https://github.com/apache/solr/pull/2687#issuecomment-2354999765 I just saw SOLR-17455 coming in. While mentioning OpenTracing is correct for 9.x, for 10.0 it is gone, so perhaps when you add refGuide docs for this PR, you can also `s/OpenTracing/OpenTelem