tboeghk commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1756202876
##
solr/core/src/test/org/apache/solr/cloud/ReplicateFromLeaderTest.java:
##
@@ -18,54 +18,94 @@
package org.apache.solr.cloud;
import static org.junit.Assert.assertEq
tboeghk commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1756203503
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -133,18 +126,25 @@ public static String getCommitVersion(SolrCore solrCore) {
}
/**
-
[
https://issues.apache.org/jira/browse/SOLR-13234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881123#comment-17881123
]
David Smiley commented on SOLR-13234:
-
Years later, observing this PR creates an Http
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1755442168
##
solr/core/src/java/org/apache/solr/schema/ZkIndexSchemaReader.java:
##
@@ -145,6 +145,10 @@ public void process(WatchedEvent event) {
log.warn("ZooKeepe
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1755401081
##
solr/core/src/test/org/apache/solr/pkg/TestPackages.java:
##
@@ -810,10 +813,18 @@ public void testSchemaPlugins() throws Exception {
":fieldType:_pac
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1755401081
##
solr/core/src/test/org/apache/solr/pkg/TestPackages.java:
##
@@ -810,10 +813,18 @@ public void testSchemaPlugins() throws Exception {
":fieldType:_pac
AndreyBozhko commented on code in PR #2707:
URL: https://github.com/apache/solr/pull/2707#discussion_r1755326203
##
solr/core/src/java/org/apache/solr/cloud/ZkShardTerms.java:
##
@@ -421,6 +421,10 @@ private void registerWatcher() throws KeeperException {
return;
[
https://issues.apache.org/jira/browse/SOLR-17448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17448:
--
Labels: pull-request-available (was: )
> Audit usage of ExecutorService#submit in Solr codebas
AndreyBozhko opened a new pull request, #2707:
URL: https://github.com/apache/solr/pull/2707
https://issues.apache.org/jira/browse/SOLR-17448
# Description
There are quite a few places in Solr codebase where the background task is
created by invoking `ExecutorService#submit(...
[
https://issues.apache.org/jira/browse/SOLR-17447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siju Varghese updated SOLR-17447:
-
Description:
Currently there are 3 mechanisms to control # of hits for a query
* Use of the _tim
epugh commented on code in PR #2705:
URL: https://github.com/apache/solr/pull/2705#discussion_r1755198531
##
solr/solr-ref-guide/modules/deployment-guide/pages/solr-in-docker.adoc:
##
@@ -342,6 +342,13 @@ Usage: jattach [args ...]
jcmd : execute jcmd command
+To f
[
https://issues.apache.org/jira/browse/SOLR-17447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881056#comment-17881056
]
Siju Varghese edited comment on SOLR-17447 at 9/11/24 5:04 PM:
[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881058#comment-17881058
]
David Smiley commented on SOLR-17256:
-
>From the description:
bq. But moreover I thi
[
https://issues.apache.org/jira/browse/SOLR-17447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881056#comment-17881056
]
Siju Varghese commented on SOLR-17447:
--
I can see a reference to something similar t
Andrey Bozhko created SOLR-17448:
Summary: Audit usage of ExecutorService#submit in Solr codebase
Key: SOLR-17448
URL: https://issues.apache.org/jira/browse/SOLR-17448
Project: Solr
Issue Typ
Siju Varghese created SOLR-17447:
Summary: Add support for maxHits
Key: SOLR-17447
URL: https://issues.apache.org/jira/browse/SOLR-17447
Project: Solr
Issue Type: New Feature
Security L
cpoerschke commented on code in PR #2705:
URL: https://github.com/apache/solr/pull/2705#discussion_r1755134699
##
solr/solr-ref-guide/modules/deployment-guide/pages/solr-in-docker.adoc:
##
@@ -342,6 +342,13 @@ Usage: jattach [args ...]
jcmd : execute jcmd command
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1755064259
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -133,18 +126,25 @@ public static String getCommitVersion(SolrCore solrCore) {
}
/**
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1755053664
##
solr/core/src/test/org/apache/solr/cloud/ReplicateFromLeaderTest.java:
##
@@ -18,54 +18,94 @@
package org.apache.solr.cloud;
import static org.junit.Assert.asser
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1755039181
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -133,18 +126,25 @@ public static String getCommitVersion(SolrCore solrCore) {
}
/**
epugh commented on PR #2703:
URL: https://github.com/apache/solr/pull/2703#issuecomment-2343927963
okay, the refute wasn't actually matching.. i found that we need to
consult the log file. Also, I was getting a RMI Port exception..Can you
validate that this test fails for you, and ht
malliaridis opened a new pull request, #2706:
URL: https://github.com/apache/solr/pull/2706
https://issues.apache.org/jira/browse/SOLR-17406
# Description
With the version catalogs all versions and references to them are managed in
a single file and updated from there.
#
[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881002#comment-17881002
]
Sanjay Dutt commented on SOLR-17256:
I agree that setting it up at the method level i
[
https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880997#comment-17880997
]
Sanjay Dutt commented on SOLR-17256:
I might not fully understand the entire rational
malliaridis commented on code in PR #2684:
URL: https://github.com/apache/solr/pull/2684#discussion_r1754439637
##
solr/packaging/test/test_ssl.bats:
##
@@ -526,12 +526,14 @@ teardown() {
# server1 will run on $SOLR_PORT and will use server1.keystore
export SOLR_SSL_KEY_ST
[
https://issues.apache.org/jira/browse/SOLR-16254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880967#comment-17880967
]
ASF subversion and git services commented on SOLR-16254:
Commit 5
[
https://issues.apache.org/jira/browse/SOLR-16254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880959#comment-17880959
]
ASF subversion and git services commented on SOLR-16254:
Commit 1
epugh merged PR #2698:
URL: https://github.com/apache/solr/pull/2698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
ellaeln commented on PR #2527:
URL: https://github.com/apache/solr/pull/2527#issuecomment-2343459909
Sure go ahead. I also opened a pr to your branch with 9.7 changes and
another one https://github.com/apache/solr/pull/2672 with the both of them
combined, feel free to use any of them if you
[
https://issues.apache.org/jira/browse/SOLR-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880931#comment-17880931
]
Eric Pugh commented on SOLR-6962:
-
What this really is about is that we don't validate for
[
https://issues.apache.org/jira/browse/SOLR-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880931#comment-17880931
]
Eric Pugh edited comment on SOLR-6962 at 9/11/24 10:50 AM:
---
What
[
https://issues.apache.org/jira/browse/SOLR-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-6962:
Summary: bin/solr stop/start/restart should complain about missing value
for options that expect a value. (
epugh commented on PR #2671:
URL: https://github.com/apache/solr/pull/2671#issuecomment-2343296171
Okay, I just did some testing of `bin/solr` and this is what I get (and
expect):
```
dev git:(SOLR-6962) ✗ bin/solr stop -a
ERROR: Jvm options are required when using the -a o
epugh commented on PR #2671:
URL: https://github.com/apache/solr/pull/2671#issuecomment-2343286444
Okaym, I dug more into this, and I think I see another problem! It turns
out that we parse the args for the start/stop/restart commands separate from
actually invoking the command.
Thi
tboeghk commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753939777
##
solr/core/src/test/org/apache/solr/cloud/ReplicateFromLeaderTest.java:
##
@@ -28,44 +28,64 @@ public class ReplicateFromLeaderTest {
public void determinePollInterva
epugh commented on PR #2671:
URL: https://github.com/apache/solr/pull/2671#issuecomment-2343217312
thanks @rahulgoswami I am going to back out the `solr.cmd` changes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/SOLR-17439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated SOLR-17439:
--
Labels: pull-request-available (was: )
> jattach does not work with Solr in Docker
> -
rmueller83 opened a new pull request, #2705:
URL: https://github.com/apache/solr/pull/2705
https://issues.apache.org/jira/browse/SOLR-17439
# Description
The documentation misses a section for finding out a non-default PID.
# Solution
Added a `ps` comma
[
https://issues.apache.org/jira/browse/SOLR-17382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880921#comment-17880921
]
ASF subversion and git services commented on SOLR-17382:
Commit 4
epugh commented on PR #2316:
URL: https://github.com/apache/solr/pull/2316#issuecomment-2343183866
thanks @cpoerschke for your review on this! Definitly a better patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cpoerschke commented on PR #2316:
URL: https://github.com/apache/solr/pull/2316#issuecomment-2343071045
> ... I'll update the docs also ...
Yes please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
cpoerschke merged PR #2700:
URL: https://github.com/apache/solr/pull/2700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753672888
##
solr/core/src/test/org/apache/solr/cloud/ReplicateFromLeaderTest.java:
##
@@ -28,44 +28,64 @@ public class ReplicateFromLeaderTest {
public void determinePollInte
tboeghk commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753658338
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -74,6 +74,7 @@ public void startReplication(boolean switchTransactionLog) {
"Sol
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753651572
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -74,6 +74,7 @@ public void startReplication(boolean switchTransactionLog) {
"
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753643392
##
solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java:
##
@@ -143,8 +144,12 @@ public static String
determinePollInterval(SolrConfig.UpdateHandlerInfo u
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753537546
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -852,6 +856,7 @@ public UpdateHandlerInfo(ConfigNode updateHandler) {
updateHandler.get("co
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753535902
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -836,6 +838,8 @@ public UpdateHandlerInfo(
this.commitWithinSoftCommit = commitWithinSoftComm
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753534329
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -810,6 +810,7 @@ public static class UpdateHandlerInfo implements
MapSerializable {
public final
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753526474
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -810,6 +810,7 @@ public static class UpdateHandlerInfo implements
MapSerializable {
public final
cpoerschke commented on code in PR #2316:
URL: https://github.com/apache/solr/pull/2316#discussion_r1753517685
##
solr/core/src/java/org/apache/solr/core/SolrConfig.java:
##
@@ -810,6 +810,7 @@ public static class UpdateHandlerInfo implements
MapSerializable {
public final
RavinaChidambaram opened a new pull request, #722:
URL: https://github.com/apache/solr-operator/pull/722
Implemented #650
Have added observed generation to the status of the solrcloud CR to track
the transition of the solrcloud.
--
This is an automated message from the Apache Git
tboeghk commented on PR #2527:
URL: https://github.com/apache/solr/pull/2527#issuecomment-2342904768
Thanks @ellaeln for picking up the work 🙏 I completely lost track of this
during the summer ☀️
However as Solr 9.7 is through the gates, I adapted the coordinator changes
to the `bran
53 matches
Mail list logo
