[jira] [Updated] (SOLR-17334) Minor bugs in Solr dedicated coordinator mode

2024-07-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17334: -- Labels: pull-request-available (was: ) > Minor bugs in Solr dedicated coordinator mode > -

Re: [PR] SOLR-17334: Enable coordinator nodes to handle requests other than `/select` [solr]

2024-07-24 Thread via GitHub
noblepaul commented on PR #2527: URL: https://github.com/apache/solr/pull/2527#issuecomment-2249475607 @tboeghk can you please fix the conflicts ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Updated] (SOLR-17379) ParsingFieldUpdateProcessorsTest failures using CLDR locale provider

2024-07-24 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-17379: -- Attachment: SOLR-17379.test.patch Status: Open (was: Open) I'm attaching a pat

[jira] [Commented] (SOLR-17379) ParsingFieldUpdateProcessorsTest failures using CLDR locale provider

2024-07-24 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868518#comment-17868518 ] Chris M. Hostetter commented on SOLR-17379: --- Examples of what these failures lo

[jira] [Created] (SOLR-17379) ParsingFieldUpdateProcessorsTest failures using CLDR locale provider

2024-07-24 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-17379: - Summary: ParsingFieldUpdateProcessorsTest failures using CLDR locale provider Key: SOLR-17379 URL: https://issues.apache.org/jira/browse/SOLR-17379 Project:

Re: [PR] SOLR-17322 Make RankQuery.getTopDocsCollector use covariant generic types [solr]

2024-07-24 Thread via GitHub
dsmiley commented on PR #2506: URL: https://github.com/apache/solr/pull/2506#issuecomment-2249193900 Cool; maybe (@cpoerschke reviewer and listed in CHANGES.txt) can merge this in a day or so to make 9.7. @madrob now's your chance to object if you have an issue with this. -- This is an

Re: [PR] SOLR-17322 Make RankQuery.getTopDocsCollector use covariant generic types [solr]

2024-07-24 Thread via GitHub
stephen-woods commented on code in PR #2506: URL: https://github.com/apache/solr/pull/2506#discussion_r1690613819 ## solr/CHANGES.txt: ## @@ -220,6 +220,8 @@ Other Changes * SOLR-17347: EnvUtils: Removed "env" methods, as they were problematic. Code should almost never ref

[jira] [Updated] (SOLR-17322) Once again allow rank queries to use custom TopDocsCollectors that operate on types that extend ScoreDocs (covariant generic types)

2024-07-24 Thread Stephen Woods (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Woods updated SOLR-17322: - Description: Make RankQuery.getTopDocsCollector use covariant generic types Currently, rank quer

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690592214 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -268,35 +258,90 @@ public void testAliasHandling() throws Exception {

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690592151 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -268,35 +258,90 @@ public void testAliasHandling() throws Exception {

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690591569 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -325,6 +325,11 @@ protected void init() throws Exception { addCollectionParamIfNeede

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690542590 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -268,35 +258,90 @@ public void testAliasHandling() throws Exception {

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
dsmiley commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690524467 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -268,35 +258,90 @@ public void testAliasHandling() throws Exception { }

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690487661 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -246,6 +257,81 @@ public void testAliasHandling() throws Exception {

[jira] [Updated] (SOLR-17359) Make SolrCLI handle arg parsing of zk sub commands

2024-07-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17359: -- Labels: pull-request-available (was: ) > Make SolrCLI handle arg parsing of zk sub commands >

[PR] SOLR-17359: Move Zk Arg parsing into Java Code [solr]

2024-07-24 Thread via GitHub
epugh opened a new pull request, #2593: URL: https://github.com/apache/solr/pull/2593 https://issues.apache.org/jira/browse/SOLR-17359 # Description Migrate arg parsing for ZK commands into Java code # Solution Had to add a ZkToolHelp to handle some of the glob

Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-07-24 Thread via GitHub
dsmiley commented on code in PR #2591: URL: https://github.com/apache/solr/pull/2591#discussion_r1690411012 ## solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java: ## @@ -246,20 +250,24 @@ public void handleRequest(SolrQueryRequest req, SolrQueryResponse rsp) {

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
dsmiley commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690380168 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## @@ -1228,9 +1199,15 @@ protected DocCollection getDocCollection(String collection, Integ

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
dsmiley commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690380168 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## @@ -1228,9 +1199,15 @@ protected DocCollection getDocCollection(String collection, Integ

[PR] chore(deps): update io.netty:* to v4.1.112.final [solr]

2024-07-24 Thread via GitHub
solrbot opened a new pull request, #2592: URL: https://github.com/apache/solr/pull/2592 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.netty:netty-transport-native-unix-common](https://netty.io/) ([source](https://togithub.co

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
dsmiley commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690370559 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## @@ -1228,9 +1199,15 @@ protected DocCollection getDocCollection(String collection, Integ

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-24 Thread via GitHub
dsmiley commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1690355384 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -0,0 +1,397 @@ +package org.apache.solr.common.cloud; + +import

[jira] [Assigned] (SOLR-17378) Add a RequestHandler metric for "number of outstanding concurrent requests"

2024-07-24 Thread Michael Gibney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Gibney reassigned SOLR-17378: - Assignee: Michael Gibney > Add a RequestHandler metric for "number of outstanding concur

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1690310343 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -868,7 +869,11 @@ public ClusterState getClusterState() { } public O

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1690309873 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -0,0 +1,406 @@ +package org.apache.solr.common.cloud; +

[jira] [Commented] (SOLR-17359) Make SolrCLI handle arg parsing of zk sub commands

2024-07-24 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868461#comment-17868461 ] Eric Pugh commented on SOLR-17359: -- Going to try out your "ZkTool" idea and see where th

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1690299047 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -0,0 +1,406 @@ +package org.apache.solr.common.cloud; +

[jira] [Resolved] (SOLR-16876) Delegate Arg parsing for AuthTool to SolrCLI

2024-07-24 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16876. -- Fix Version/s: 9.7 Resolution: Fixed > Delegate Arg parsing for AuthTool to SolrCLI > --

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-24 Thread via GitHub
dsmiley commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1690279665 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -868,7 +869,11 @@ public ClusterState getClusterState() { } public Object g

[jira] [Commented] (SOLR-15831) Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI

2024-07-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868452#comment-17868452 ] ASF subversion and git services commented on SOLR-15831: Commit e

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-07-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868449#comment-17868449 ] David Smiley commented on SOLR-13350: - There is no dedicated test for this functional

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690233893 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -93,6 +94,22 @@ public class CloudHttp2SolrClientTest extends SolrClo

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-07-24 Thread via GitHub
dsmiley commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1690232566 ## solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java: ## @@ -0,0 +1,423 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
dsmiley commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690201866 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -246,6 +267,36 @@ public void testAliasHandling() throws Exception {

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
dsmiley commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1690194393 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -93,6 +94,22 @@ public class CloudHttp2SolrClientTest extends SolrCloudTestC

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1690191452 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -909,8 +884,8 @@ public void close() { }); ExecutorUtil.

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1690190405 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -0,0 +1,403 @@ +package org.apache.solr.common.cloud; +

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1690190857 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java: ## @@ -1191,130 +1166,27 @@ private void loadClusterProperties() { } /** -

Re: [PR] SOLR-15831: Refactor bin/solr and bin/solr.cmd to delegate args parsing and usage help to SolrCLI [solr]

2024-07-24 Thread via GitHub
epugh merged PR #2580: URL: https://github.com/apache/solr/pull/2580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-07-24 Thread via GitHub
magibney commented on PR #2591: URL: https://github.com/apache/solr/pull/2591#issuecomment-2248437989 The core code should be ready for review, but the test coverage is not at all adequate yet. There is a test stubbed out, but it's sloppy/too long, and basically exists only to exerci

[jira] [Updated] (SOLR-17378) Add a RequestHandler metric for "number of outstanding concurrent requests"

2024-07-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17378: -- Labels: pull-request-available (was: ) > Add a RequestHandler metric for "number of outstandin

[PR] SOLR-17378: Add a RequestHandler metric for "number of outstanding concurrent requests" [solr]

2024-07-24 Thread via GitHub
magibney opened a new pull request, #2591: URL: https://github.com/apache/solr/pull/2591 https://issues.apache.org/jira/browse/SOLR-17378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [SOLR-17368] TestPrometheusResponseWriter redesign [solr]

2024-07-24 Thread via GitHub
mlbiscoc commented on PR #2586: URL: https://github.com/apache/solr/pull/2586#issuecomment-2248429857 > > any leaking metrics from other metrics should not override these values. > > That's dodging an issue that should be investigated as it might interfere with another metrics based t

Re: [PR] Delegate Collection Property Management to CollectionPropertiesZkStateReader [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2585: URL: https://github.com/apache/solr/pull/2585#discussion_r1690094240 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/CollectionPropertiesZkStateReader.java: ## @@ -0,0 +1,403 @@ +package org.apache.solr.common.cloud; +

[jira] [Commented] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-07-24 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868416#comment-17868416 ] Christine Poerschke commented on SOLR-17298: bq. * By turning it on by defau

Re: [PR] SOLR-13350, SOLR-17298: multi-threaded search: don't (yet) support query limits [solr]

2024-07-24 Thread via GitHub
cpoerschke commented on PR #2590: URL: https://github.com/apache/solr/pull/2590#issuecomment-2248391077 https://github.com/apache/solr/actions/runs/10079922542/job/27868413918?pr=2590 CI failure _does_ sound related, will investigate. ``` > Task :solr:core:wipeTaskTemp ERROR: T

[jira] [Closed] (SOLR-5933) BoolField should support docValues

2024-07-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-5933. -- > BoolField should support docValues > -- > > Key: SOLR-5933

[jira] [Resolved] (SOLR-5933) BoolField should support docValues

2024-07-24 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-5933. Fix Version/s: 6.2 Resolution: Duplicate > BoolField should support docValues > -

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-07-24 Thread via GitHub
cpoerschke commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1690065461 ## solr/core/src/test/org/apache/solr/search/TestQueryLimits.java: ## @@ -76,7 +76,17 @@ public void testQueryLimits() throws Exception { rsp = solrCl

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-07-24 Thread via GitHub
cpoerschke commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1690065008 ## solr/core/src/test/org/apache/solr/search/TestCpuAllowedLimit.java: ## @@ -185,7 +185,9 @@ public void testDistribLimit() throws Exception { "stages

Re: [PR] SOLR-13350, SOLR-17298: multi-threaded search: revert TestFiltering.java change [solr]

2024-07-24 Thread via GitHub
cpoerschke commented on PR #2589: URL: https://github.com/apache/solr/pull/2589#issuecomment-2248295940 https://github.com/apache/solr/actions/runs/10079063243/job/27866170943?pr=2589 failure seems unrelated: ``` > Task :solr:modules:hdfs:wipeTaskTemp ERROR: The following test(s) h

Re: [PR] SOLR-13350, SOLR-17298: multi-threaded search: revert TestFiltering.java change [solr]

2024-07-24 Thread via GitHub
cpoerschke commented on PR #2589: URL: https://github.com/apache/solr/pull/2589#issuecomment-2248263651 https://github.com/apache/solr/actions/runs/10079063243/job/27865500493?pr=2589 failure seems unrelated: ``` ERROR: The following test(s) have failed: - org.apache.solr.sea

Re: [PR] SOLR-17298: multi-threaded search: add assertions w.r.t. get(TopDocs|MaxScore|DocSet) call when need(TopDocs|MaxScore|DocSet) is false [solr]

2024-07-24 Thread via GitHub
cpoerschke commented on PR #2588: URL: https://github.com/apache/solr/pull/2588#issuecomment-2248248868 https://github.com/apache/solr/actions/runs/10078717202/job/27864279172 failure seems unrelated. ``` ERROR: The following test(s) have failed: - org.apache.solr.cloud.Split

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1689976255 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java: ## @@ -246,6 +250,51 @@ public void testAliasHandling() throws Exception {

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-07-24 Thread via GitHub
cpoerschke commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1689976431 ## solr/core/src/test/org/apache/solr/search/TestFiltering.java: ## @@ -92,21 +93,34 @@ public void testLiveDocsSharing() throws Exception { QueryResult res =

[PR] SOLR-13350, SOLR-17298: multi-threaded search: revert TestFiltering.java change [solr]

2024-07-24 Thread via GitHub
cpoerschke opened a new pull request, #2589: URL: https://github.com/apache/solr/pull/2589 It seems the change is no longer necessary now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1689971949 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java: ## @@ -124,7 +119,10 @@ private ClusterState fetchClusterState( t

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1689968198 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## @@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String collection

Re: [PR] SOLR-14985 Address perf issues to switch CloudSolrClient to HttpCluste… [solr]

2024-07-24 Thread via GitHub
aparnasuresh85 commented on code in PR #2571: URL: https://github.com/apache/solr/pull/2571#discussion_r1689968198 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java: ## @@ -1213,10 +1193,6 @@ protected DocCollection getDocCollection(String collection

[PR] SOLR-17298: multi-threaded search: add assertions w.r.t. get(TopDocs|MaxScore|DocSet) call when need(TopDocs|MaxScore|DocSet) is false [solr]

2024-07-24 Thread via GitHub
cpoerschke opened a new pull request, #2588: URL: https://github.com/apache/solr/pull/2588 https://issues.apache.org/jira/browse/SOLR-17298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Updated] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-07-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17298: -- Labels: pull-request-available (was: ) > Multithreaded search breaks limits, and possibly othe

Re: [PR] SOLR-13350: Multithreaded search [solr]

2024-07-24 Thread via GitHub
cpoerschke commented on code in PR #2248: URL: https://github.com/apache/solr/pull/2248#discussion_r1689870031 ## solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java: ## @@ -0,0 +1,423 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (SOLR-17298) Multithreaded search breaks limits, and possibly other things

2024-07-24 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868373#comment-17868373 ] Christine Poerschke commented on SOLR-17298: {quote}* The code presents a pos

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-07-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868369#comment-17868369 ] ASF subversion and git services commented on SOLR-13350: Commit 8

[jira] [Commented] (SOLR-13350) Explore collector managers for multi-threaded search

2024-07-24 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868367#comment-17868367 ] ASF subversion and git services commented on SOLR-13350: Commit f

Re: [PR] SOLR-13350: multi-threaded search: default to 'available processors' thread count [solr]

2024-07-24 Thread via GitHub
cpoerschke merged PR #2569: URL: https://github.com/apache/solr/pull/2569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] Create 2024-07-15-apache-solr-performance-jmeter.md [solr-site]

2024-07-24 Thread via GitHub
lizbiella commented on PR #114: URL: https://github.com/apache/solr-site/pull/114#issuecomment-2247878135 @janhoy I can't see the blog post on the online page. Did something go wrong? Do I need to do something else? -- This is an automated message from the Apache Git Service. To respond