janhoy commented on code in PR #2540:
URL: https://github.com/apache/solr/pull/2540#discussion_r1663325672
##
solr/bin/solr.cmd:
##
@@ -246,11 +246,12 @@ set FIRST_ARG=%1
IF [%1]==[] goto usage
-IF "%1"=="-help" goto usage
-IF "%1"=="-usage" goto usage
-IF "%1"=="-h" goto u
janhoy commented on code in PR #2540:
URL: https://github.com/apache/solr/pull/2540#discussion_r1663323040
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -435,11 +503,34 @@ public static boolean exceptionIsAuthRelated(Exception
exc) {
&& Arrays.asList(UN
janhoy commented on PR #2545:
URL: https://github.com/apache/solr/pull/2545#issuecomment-2204736439
> The refactoring looks good, nice to see that we removed lines of code
wrapping! I will look again but I don think I see in this PR the enhancements
to printing out help with custom header o
github-actions[bot] commented on PR #2269:
URL: https://github.com/apache/solr/pull/2269#issuecomment-2204735110
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
github-actions[bot] commented on PR #2268:
URL: https://github.com/apache/solr/pull/2268#issuecomment-2204735153
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
github-actions[bot] commented on PR #2424:
URL: https://github.com/apache/solr/pull/2424#issuecomment-2204735032
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
github-actions[bot] commented on PR #2434:
URL: https://github.com/apache/solr/pull/2434#issuecomment-2204734994
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
dsmiley commented on code in PR #2548:
URL: https://github.com/apache/solr/pull/2548#discussion_r1663245696
##
solr/core/src/java/org/apache/solr/update/UpdateLocks.java:
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribu
dsmiley opened a new pull request, #2548:
URL: https://github.com/apache/solr/pull/2548
https://issues.apache.org/jira/browse/SOLR-17102
DistributedUpdateProcessor some refactoring to balance locks clearly.
VersionInfo: moved locks out to UpdateLocks.
Refactor: OrderedExecutor us
[
https://issues.apache.org/jira/browse/SOLR-17102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-17102:
---
Assignee: David Smiley
> VersionBucket not needed
>
>
>
epugh commented on code in PR #2540:
URL: https://github.com/apache/solr/pull/2540#discussion_r1663203570
##
solr/bin/solr.cmd:
##
@@ -246,11 +246,12 @@ set FIRST_ARG=%1
IF [%1]==[] goto usage
-IF "%1"=="-help" goto usage
-IF "%1"=="-usage" goto usage
-IF "%1"=="-h" goto us
epugh commented on code in PR #2545:
URL: https://github.com/apache/solr/pull/2545#discussion_r1663193576
##
solr/core/src/java/org/apache/solr/cli/ToolBase.java:
##
@@ -66,5 +66,10 @@ public int runTool(CommandLine cli) throws Exception {
return toolExitStatus;
}
+ @
epugh commented on PR #2545:
URL: https://github.com/apache/solr/pull/2545#issuecomment-2204475187
This is awesome. I honestly had been willing to go backwards and lose the
per tool customizations of help in the interest of simplicity... can't wait to
eview this pr.
--
This is an
malliaridis commented on code in PR #2547:
URL: https://github.com/apache/solr/pull/2547#discussion_r1663135743
##
solr/solr-ref-guide/modules/query-guide/pages/standard-query-parser.adoc:
##
@@ -315,7 +315,7 @@ or
=== The Boolean Operator "+"
-The `+` symbol (also known as
cpoerschke commented on code in PR #2547:
URL: https://github.com/apache/solr/pull/2547#discussion_r1662972239
##
solr/solr-ref-guide/modules/query-guide/pages/standard-query-parser.adoc:
##
@@ -315,7 +315,7 @@ or
=== The Boolean Operator "+"
-The `+` symbol (also known as
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1662962160
##
solr/modules/monitor/src/java/org/apache/solr/monitor/search/QueryMatchType.java:
##
@@ -0,0 +1,45 @@
+/*
+ *
+ * * Licensed to the Apache Software Foundation (ASF)
HoustonPutman commented on code in PR #2541:
URL: https://github.com/apache/solr/pull/2541#discussion_r1657812390
##
solr/cross-dc-manager/src/test/org/apache/solr/crossdc/manager/SimpleSolrIntegrationTest.java:
##
@@ -46,21 +45,21 @@ public static void ensureWorkingMockito() {
janhoy commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2200147713
Getting there... All BATS tests now run, except these five:
```
not ok 32 solr help flag prints help in 1521ms
# (from function `assert_output' in file
/home/runner/work/solr/solr
bruno-roustant merged PR #108:
URL: https://github.com/apache/solr-sandbox/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
janhoy commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2200072644
Just fixed the `test_delete_collection.bats` test (Linux only).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
janhoy commented on code in PR #2540:
URL: https://github.com/apache/solr/pull/2540#discussion_r1660997239
##
solr/bin/solr:
##
@@ -982,31 +982,10 @@ else
exit
fi
+# status tool
if [ "$SCRIPT_CMD" == "status" ]; then
- if [ $# -gt 0 ]; then
-while true; do
- cas
janhoy commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2197768183
Pushed some commits that at least makes Solr compile, and Fixes
HealthCheckToolTest.
I propose that we revert most .bats files to testing original (deprecated)
options, so we know the
dsmiley commented on PR #2524:
URL: https://github.com/apache/solr/pull/2524#issuecomment-2197732565
oh the irony; a CHANGES.txt conflict; sigh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cpoerschke commented on PR #2524:
URL: https://github.com/apache/solr/pull/2524#issuecomment-2197018871
> (no CHANGES.txt; just deprecating low level stuff & refactoring stuff that
shouldn't have an effect)
>
> WDYT @cpoerschke
Perhaps `QueryComponent` and `SolrIndexSearcher` m
janhoy opened a new pull request, #2543:
URL: https://github.com/apache/solr/pull/2543
Spinoff from #2540
We should run all tests on PRs against `branch_9x`, to catch errors in
larger backport efforts.
This should work fine at least until we bump main to some newer java versio
cpoerschke commented on code in PR #2524:
URL: https://github.com/apache/solr/pull/2524#discussion_r1654776265
##
solr/core/src/test/org/apache/solr/search/TestSearchPerf.java:
##
@@ -173,7 +172,14 @@ private long doListGen(Query q, List filt) throws
Exception {
long ret =
magibney commented on PR #2535:
URL: https://github.com/apache/solr/pull/2535#issuecomment-2191621534
Opened https://github.com/apache/solr/pull/2537 for the failing test (it's
unrelated to this PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, p
magibney merged PR #2537:
URL: https://github.com/apache/solr/pull/2537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o
magibney opened a new pull request, #2537:
URL: https://github.com/apache/solr/pull/2537
no jira
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: iss
dsmiley commented on code in PR #2524:
URL: https://github.com/apache/solr/pull/2524#discussion_r1654698142
##
solr/core/src/test/org/apache/solr/search/TestSearchPerf.java:
##
@@ -173,7 +172,14 @@ private long doListGen(Query q, List filt) throws
Exception {
long ret = 0;
epugh commented on PR #2499:
URL: https://github.com/apache/solr/pull/2499#issuecomment-2191559171
One idea is that maybe we would want to have a page in the ref guide that
was "The Defensive Solr Setup" and you could reference this type of feature and
other features that enable this? May
31 matches
Mail list logo
