Re: [PR] SOLR-17321: Remove Deprecated URL API in Preparation for Java 21 [solr]

2024-06-05 Thread via GitHub
iamsanjay commented on PR #2501: URL: https://github.com/apache/solr/pull/2501#issuecomment-2151357041 Though `new Locale` is deprecated, however the newer syntax `Locale.of` is not available in Java 11. Therefore It can only be done after migrating to Java21 or along with it. Should

[PR] SOLR-17321: Remove Deprecated URL API in Preparation for Java 21 [solr]

2024-06-05 Thread via GitHub
iamsanjay opened a new pull request, #2501: URL: https://github.com/apache/solr/pull/2501 [SOLR-17321](https://issues.apache.org/jira/browse/SOLR-17321) As we started preparing (https://github.com/apache/solr/pull/2497 ) the move to change the Java version for the main branch,

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-05 Thread via GitHub
dsmiley commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1628677734 ## solr/core/src/java/org/apache/solr/core/SyntheticSolrCore.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-05 Thread via GitHub
dsmiley commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1628676769 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws */

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-05 Thread via GitHub
dsmiley commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1628660388 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws */

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-05 Thread via GitHub
dsmiley commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1628632286 ## solr/core/src/java/org/apache/solr/core/SyntheticSolrCore.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[PR] Remove 'IndexUpgraderTool' page from ref-guide [solr]

2024-06-05 Thread via GitHub
gerlowskija opened a new pull request, #2500: URL: https://github.com/apache/solr/pull/2500 The IndexUpgraderTool doesn't have a clear use case for Solr users, and after some discussion on the mailing list we decided documenting it isn't worth the confusion it causes for users. # Des

Re: [PR] Refactor duplication in UpdateLog.init [solr]

2024-06-05 Thread via GitHub
dsmiley commented on code in PR #2491: URL: https://github.com/apache/solr/pull/2491#discussion_r1628628606 ## solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java: ## @@ -81,31 +77,15 @@ public void init(PluginInfo info) { log.info("Initializing HdfsUp

Re: [PR] force the use jdk21 through Crave [solr]

2024-06-05 Thread via GitHub
iamsanjay commented on PR #2498: URL: https://github.com/apache/solr/pull/2498#issuecomment-2151167656 I tried running this for #2497 (https://foss.crave.io/app/#/build/info/109489?team=5) > BUILD SUCCESSFUL in 7m 25s > 141 actionable tasks: 114 executed, 27 up-to-date I won

Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2024-06-05 Thread via GitHub
github-actions[bot] commented on PR #1994: URL: https://github.com/apache/solr/pull/1994#issuecomment-2151143368 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-05 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1628525202 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws *

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-05 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1628525202 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws *

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-05 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1628525202 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws *

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-05 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1628525202 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws *

Re: [I] Solr 8.11 with SolrMetrics produces duplicate samples with prometheus v2.52 [solr-operator]

2024-06-05 Thread via GitHub
mlbiscoc commented on issue #705: URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2151008756 Did a bit of digging and I think the cause is because of the metrics api in Solr being different from 8->9. Solr 8: ` "ADMIN./admin/ping.totalTime":4869095628,

Re: [I] Solr 8.11 with SolrMetrics produces duplicate samples with prometheus v2.52 [solr-operator]

2024-06-05 Thread via GitHub
whereismyjetpack commented on issue #705: URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2150875216 ``` cat /opt/solr/contrib/prometheus-exporter/conf/solr-exporter-config.xml .metrics | to_entries | .[] | select(.key

Re: [I] Solr 8.11 with SolrMetrics produces duplicate samples with prometheus v2.52 [solr-operator]

2024-06-05 Thread via GitHub
mlbiscoc commented on issue #705: URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2150842730 Do you have a sample of what prometheus-exporter config file is being used? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] Disabling PodDisruptionBudgets for both zk pods and solr pods [solr-operator]

2024-06-05 Thread via GitHub
crptz closed issue #699: Disabling PodDisruptionBudgets for both zk pods and solr pods URL: https://github.com/apache/solr-operator/issues/699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] Disabling PodDisruptionBudgets for both zk pods and solr pods [solr-operator]

2024-06-05 Thread via GitHub
HoustonPutman commented on issue #699: URL: https://github.com/apache/solr-operator/issues/699#issuecomment-2150817882 It would actually be the [zookeeper chart values](https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper/README.md) but I don't see it there either. If

Re: [I] Solr 8.11 with SolrMetrics produces duplicate samples with prometheus v2.52 [solr-operator]

2024-06-05 Thread via GitHub
HoustonPutman commented on issue #705: URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2150815634 that is really strange. Maybe put something on the solr users list and see if anyone has help? -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Solr 8.11 with SolrMetrics produces duplicate samples with prometheus v2.52 [solr-operator]

2024-06-05 Thread via GitHub
whereismyjetpack commented on issue #705: URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2150791056 I believe this is an issue with the solr-prometheus-exporter. I've tried with the same, and latest version. it seems to be duplicating, at least in my case, the /admin/p

Re: [I] Disabling PodDisruptionBudgets for both zk pods and solr pods [solr-operator]

2024-06-05 Thread via GitHub
crptz commented on issue #699: URL: https://github.com/apache/solr-operator/issues/699#issuecomment-2150748520 sorry for my ignorance but are you referring to [these](https://github.com/pravega/zookeeper-operator/tree/master/charts/zookeeper-operator#configuration) values? They don'

Re: [I] Solr 8.11 with SolrMetrics produces duplicate samples with prometheus v2.52 [solr-operator]

2024-06-05 Thread via GitHub
HoustonPutman commented on issue #705: URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2150738603 Yeah, I doubt this is a solr operator bug. But have you tried running the same version of Solr and the Solr Prometheus exporter? -- This is an automated message from the

Re: [I] Replica allocation after Node is DisabledScheduling [solr-operator]

2024-06-05 Thread via GitHub
HoustonPutman commented on issue #703: URL: https://github.com/apache/solr-operator/issues/703#issuecomment-2150736751 This is something that would also have to be implemented in Solr, not just the Solr Operator, because there is no mechanism currently to "cordon-off" nodes when placing rep

Re: [I] Disabling PodDisruptionBudgets for both zk pods and solr pods [solr-operator]

2024-06-05 Thread via GitHub
HoustonPutman commented on issue #699: URL: https://github.com/apache/solr-operator/issues/699#issuecomment-2150735246 Have you checked with the zookeeper operator that they give an option to disable it? -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-05 Thread via GitHub
patsonluk commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1628197733 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws *

Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]

2024-06-05 Thread via GitHub
dsmiley commented on PR #2497: URL: https://github.com/apache/solr/pull/2497#issuecomment-2150480373 References to JavaVersion (a Gradle class) like `>= JavaVersion.VERSION_16` should be reviewed to see if we can make changes to remove conditions that will no longer vary. Searching f

Re: [PR] Refactor duplication in UpdateLog.init [solr]

2024-06-05 Thread via GitHub
magibney commented on code in PR #2491: URL: https://github.com/apache/solr/pull/2491#discussion_r1628080442 ## solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java: ## @@ -81,31 +77,15 @@ public void init(PluginInfo info) { log.info("Initializing HdfsU

Re: [PR] SOLR-17195: Add 'minPrefixLength' soft limit [solr]

2024-06-05 Thread via GitHub
gerlowskija commented on PR #2499: URL: https://github.com/apache/solr/pull/2499#issuecomment-2150379839 Three questions I'd like to answer before this is merged: 1. I can imagine scenarios where an advanced user might want to enable this feature, but still be able to exempt certain q

[PR] SOLR-17195: Add 'minPrefixLength' soft limit [solr]

2024-06-05 Thread via GitHub
gerlowskija opened a new pull request, #2499: URL: https://github.com/apache/solr/pull/2499 https://issues.apache.org/jira/browse/SOLR-17195 # Description Prefix-based queries consume memory in proportion to the number of terms in the index that start with the prefix. Shor

[PR] force the use jdk21 through Crave [solr]

2024-06-05 Thread via GitHub
uvatbc opened a new pull request, #2498: URL: https://github.com/apache/solr/pull/2498 https://issues.apache.org/jira/browse/SOLR-X # Description The Solr project is considering the usage of JDK 21 at some point. We need to control which JDK is used in Crav

Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]

2024-06-05 Thread via GitHub
iamsanjay commented on PR #2497: URL: https://github.com/apache/solr/pull/2497#issuecomment-2150340085 Test case failing, on main branch as well! ``` ./gradlew :solr:core:test --tests "org.apache.solr.search.function.TestDenseVectorFunctionQuery.floatFieldVectors_shouldReturnFloatSimil

Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]

2024-06-05 Thread via GitHub
dsmiley commented on PR #2497: URL: https://github.com/apache/solr/pull/2497#issuecomment-2149871311 I suggest flipping the order. Prep the code for Java 21 compatibility first so that we don't go adding SupressForbidden to many classes to only then fix the issue later. i.e. visit the

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-05 Thread via GitHub
dsmiley commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1627752555 ## solr/core/src/java/org/apache/solr/core/ConfigSetService.java: ## @@ -391,6 +402,21 @@ protected NamedList loadConfigSetFlags(SolrResourceLoader loader) throws */

Re: [PR] Update software.amazon.awssdk:* to v2.25.63 [solr]

2024-06-05 Thread via GitHub
janhoy commented on PR #2056: URL: https://github.com/apache/solr/pull/2056#issuecomment-2149804604 @risdenk @gerlowskija Do you know whether all of the six new dependencies are required for our use or if we can exclude some? -- This is an automated message from the Apache Git Service. T

Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]

2024-06-05 Thread via GitHub
iamsanjay commented on PR #2497: URL: https://github.com/apache/solr/pull/2497#issuecomment-2149791390 > Would it be too much to ask to separate all this URL conversion stuff to a separate PR, ultimately being its own commit focused on exactly that? Needn't be another JIRA; needn't touch CH

Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]

2024-06-05 Thread via GitHub
epugh commented on PR #2497: URL: https://github.com/apache/solr/pull/2497#issuecomment-2149773970 > > RE URL: If you have IntelliJ Ultimate edition (not sure if Community), you could do "Structural Replace" to find & replace systematically everywhere. > > Like always, Thanks for the

Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]

2024-06-05 Thread via GitHub
dsmiley commented on code in PR #2497: URL: https://github.com/apache/solr/pull/2497#discussion_r1627690614 ## solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java: ## @@ -102,8 +104,9 @@ public static String buildRequestUrl( return basePath + path; }

Re: [PR] SOLR-17321: Bump minimum required Java version to 21 [solr]

2024-06-05 Thread via GitHub
iamsanjay commented on PR #2497: URL: https://github.com/apache/solr/pull/2497#issuecomment-2149754684 > RE URL: If you have IntelliJ Ultimate edition (not sure if Community), you could do "Structural Replace" to find & replace systematically everywhere. Like always, Thanks for the air su

Re: [PR] Add 'score' field caveat to cursormark docs [solr]

2024-06-05 Thread via GitHub
gerlowskija merged PR #2492: URL: https://github.com/apache/solr/pull/2492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

Re: [PR] Update software.amazon.awssdk:* to v2.25.63 [solr]

2024-06-05 Thread via GitHub
janhoy commented on PR #2056: URL: https://github.com/apache/solr/pull/2056#issuecomment-2149704266 Precommit fails with ``` > Certain license/ notice files are missing: - License file missing ('software.amazon.awssdk:checksums-spi:2.25.63') - License file missing ('softwa

Re: [PR] Update org.mockito:mockito* to v5.12.0 [solr]

2024-06-05 Thread via GitHub
janhoy merged PR #2490: URL: https://github.com/apache/solr/pull/2490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency io.swagger.core.v3:swagger-annotations-jakarta to v2.2.22 [solr]

2024-06-05 Thread via GitHub
janhoy merged PR #2373: URL: https://github.com/apache/solr/pull/2373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency com.fasterxml.jackson:jackson-bom to v2.17.1 [solr]

2024-06-05 Thread via GitHub
janhoy merged PR #2346: URL: https://github.com/apache/solr/pull/2346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency org.semver4j:semver4j to v5.3.0 [solr]

2024-06-05 Thread via GitHub
janhoy merged PR #2440: URL: https://github.com/apache/solr/pull/2440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17099) Unsolicited snitch tag warnings from AttributeFetcherImpl

2024-06-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852414#comment-17852414 ] ASF subversion and git services commented on SOLR-17099: Commit 9

[jira] [Resolved] (SOLR-17099) Unsolicited snitch tag warnings from AttributeFetcherImpl

2024-06-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17099. Fix Version/s: 9.7 Resolution: Fixed > Unsolicited snitch tag warnings from AttributeFetcher

Re: [PR] SOLR-17099: snitch does not return spurious tags [solr]

2024-06-05 Thread via GitHub
janhoy merged PR #2278: URL: https://github.com/apache/solr/pull/2278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-17099) Unsolicited snitch tag warnings from AttributeFetcherImpl

2024-06-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852413#comment-17852413 ] ASF subversion and git services commented on SOLR-17099: Commit d

Re: [PR] SOLR-17317: Correct 'wt' interpretation for v2 APIs [solr]

2024-06-05 Thread via GitHub
madrob commented on code in PR #2496: URL: https://github.com/apache/solr/pull/2496#discussion_r1627568175 ## solr/core/src/test/org/apache/solr/handler/api/V2ApiUtilsTest.java: ## @@ -36,4 +40,21 @@ public void testReadsDisableV2ApiSysprop() { assertFalse( "v2 API

Re: [PR] SOLR-17317: Correct 'wt' interpretation for v2 APIs [solr]

2024-06-05 Thread via GitHub
gerlowskija commented on code in PR #2496: URL: https://github.com/apache/solr/pull/2496#discussion_r1627530042 ## solr/core/src/test/org/apache/solr/handler/api/V2ApiUtilsTest.java: ## @@ -36,4 +40,21 @@ public void testReadsDisableV2ApiSysprop() { assertFalse( "v

Re: [PR] SOLR-17317: Correct 'wt' interpretation for v2 APIs [solr]

2024-06-05 Thread via GitHub
gerlowskija commented on code in PR #2496: URL: https://github.com/apache/solr/pull/2496#discussion_r1627530042 ## solr/core/src/test/org/apache/solr/handler/api/V2ApiUtilsTest.java: ## @@ -36,4 +40,21 @@ public void testReadsDisableV2ApiSysprop() { assertFalse( "v

Re: [PR] SOLR-17317: Correct 'wt' interpretation for v2 APIs [solr]

2024-06-05 Thread via GitHub
gerlowskija commented on code in PR #2496: URL: https://github.com/apache/solr/pull/2496#discussion_r1627529271 ## solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java: ## @@ -87,13 +88,14 @@ public static void squashIntoNamedListWithoutHeader( squashObjectIntoNam

[jira] [Commented] (SOLR-17099) Unsolicited snitch tag warnings from AttributeFetcherImpl

2024-06-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852385#comment-17852385 ] Jan Høydahl commented on SOLR-17099: Seeing the same, and believe it may be a cause f

[jira] [Assigned] (SOLR-17099) Unsolicited snitch tag warnings from AttributeFetcherImpl

2024-06-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-17099: -- Assignee: Jan Høydahl > Unsolicited snitch tag warnings from AttributeFetcherImpl > --

Re: [PR] SOLR-14673: Add bin/solr stream CLI [solr]

2024-06-05 Thread via GitHub
epugh commented on PR #2479: URL: https://github.com/apache/solr/pull/2479#issuecomment-2149443128 Thanks for sharing the feedback @gerlowskija ! I think the value of the tool is only there if your second comment about being able to run a streaming expression locally is valid, and then ha

Re: [PR] SOLR-17099: snitch does not return spurious tags [solr]

2024-06-05 Thread via GitHub
psalagnac commented on PR #2278: URL: https://github.com/apache/solr/pull/2278#issuecomment-2149396008 > 9.7 is our next release, not 9.6 Oh, good catch. This was opened a while ago and I missed the version number changed. More automation would have definitely helped. -- This i

Re: [PR] SOLR-16796: introduce org.cyclonedx.bom gradle plugin [solr]

2024-06-05 Thread via GitHub
anshumg commented on PR #1203: URL: https://github.com/apache/solr/pull/1203#issuecomment-2149114633 Thanks @HoustonPutman . I think this would be a good first step considering we've been stuck with this for a while. -- This is an automated message from the Apache Git Service. To respond