iamsanjay commented on PR #2501:
URL: https://github.com/apache/solr/pull/2501#issuecomment-2151357041
Though `new Locale` is deprecated, however the newer syntax `Locale.of` is
not available in Java 11. Therefore It can only be done after migrating to
Java21 or along with it.
Should
iamsanjay opened a new pull request, #2501:
URL: https://github.com/apache/solr/pull/2501
[SOLR-17321](https://issues.apache.org/jira/browse/SOLR-17321)
As we started preparing (https://github.com/apache/solr/pull/2497 ) the move
to change the Java version for the main branch,
dsmiley commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1628677734
##
solr/core/src/java/org/apache/solr/core/SyntheticSolrCore.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
dsmiley commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1628676769
##
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##
@@ -391,6 +402,21 @@ protected NamedList
loadConfigSetFlags(SolrResourceLoader loader) throws
*/
dsmiley commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1628660388
##
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##
@@ -391,6 +402,21 @@ protected NamedList
loadConfigSetFlags(SolrResourceLoader loader) throws
*/
dsmiley commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1628632286
##
solr/core/src/java/org/apache/solr/core/SyntheticSolrCore.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
gerlowskija opened a new pull request, #2500:
URL: https://github.com/apache/solr/pull/2500
The IndexUpgraderTool doesn't have a clear use case for Solr users, and
after some discussion on the mailing list we decided documenting it isn't worth
the confusion it causes for users.
# Des
dsmiley commented on code in PR #2491:
URL: https://github.com/apache/solr/pull/2491#discussion_r1628628606
##
solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java:
##
@@ -81,31 +77,15 @@ public void init(PluginInfo info) {
log.info("Initializing HdfsUp
iamsanjay commented on PR #2498:
URL: https://github.com/apache/solr/pull/2498#issuecomment-2151167656
I tried running this for #2497
(https://foss.crave.io/app/#/build/info/109489?team=5)
> BUILD SUCCESSFUL in 7m 25s
> 141 actionable tasks: 114 executed, 27 up-to-date
I won
github-actions[bot] commented on PR #1994:
URL: https://github.com/apache/solr/pull/1994#issuecomment-2151143368
This PR had no visible activity in the past 60 days, labeling it as stale.
Any new activity will remove the stale label. To attract more reviewers, please
tag someone or notify t
patsonluk commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1628525202
##
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##
@@ -391,6 +402,21 @@ protected NamedList
loadConfigSetFlags(SolrResourceLoader loader) throws
*
patsonluk commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1628525202
##
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##
@@ -391,6 +402,21 @@ protected NamedList
loadConfigSetFlags(SolrResourceLoader loader) throws
*
patsonluk commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1628525202
##
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##
@@ -391,6 +402,21 @@ protected NamedList
loadConfigSetFlags(SolrResourceLoader loader) throws
*
patsonluk commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1628525202
##
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##
@@ -391,6 +402,21 @@ protected NamedList
loadConfigSetFlags(SolrResourceLoader loader) throws
*
mlbiscoc commented on issue #705:
URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2151008756
Did a bit of digging and I think the cause is because of the metrics api in
Solr being different from 8->9.
Solr 8:
` "ADMIN./admin/ping.totalTime":4869095628,
whereismyjetpack commented on issue #705:
URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2150875216
```
cat /opt/solr/contrib/prometheus-exporter/conf/solr-exporter-config.xml
.metrics | to_entries | .[] | select(.key
mlbiscoc commented on issue #705:
URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2150842730
Do you have a sample of what prometheus-exporter config file is being used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
crptz closed issue #699: Disabling PodDisruptionBudgets for both zk pods and
solr pods
URL: https://github.com/apache/solr-operator/issues/699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
HoustonPutman commented on issue #699:
URL: https://github.com/apache/solr-operator/issues/699#issuecomment-2150817882
It would actually be the [zookeeper chart
values](https://github.com/pravega/zookeeper-operator/blob/master/charts/zookeeper/README.md)
but I don't see it there either. If
HoustonPutman commented on issue #705:
URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2150815634
that is really strange. Maybe put something on the solr users list and see
if anyone has help?
--
This is an automated message from the Apache Git Service.
To respond to
whereismyjetpack commented on issue #705:
URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2150791056
I believe this is an issue with the solr-prometheus-exporter. I've tried
with the same, and latest version. it seems to be duplicating, at least in my
case, the /admin/p
crptz commented on issue #699:
URL: https://github.com/apache/solr-operator/issues/699#issuecomment-2150748520
sorry for my ignorance but are you referring to
[these](https://github.com/pravega/zookeeper-operator/tree/master/charts/zookeeper-operator#configuration)
values?
They don'
HoustonPutman commented on issue #705:
URL: https://github.com/apache/solr-operator/issues/705#issuecomment-2150738603
Yeah, I doubt this is a solr operator bug. But have you tried running the
same version of Solr and the Solr Prometheus exporter?
--
This is an automated message from the
HoustonPutman commented on issue #703:
URL: https://github.com/apache/solr-operator/issues/703#issuecomment-2150736751
This is something that would also have to be implemented in Solr, not just
the Solr Operator, because there is no mechanism currently to "cordon-off"
nodes when placing rep
HoustonPutman commented on issue #699:
URL: https://github.com/apache/solr-operator/issues/699#issuecomment-2150735246
Have you checked with the zookeeper operator that they give an option to
disable it?
--
This is an automated message from the Apache Git Service.
To respond to the messag
patsonluk commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1628197733
##
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##
@@ -391,6 +402,21 @@ protected NamedList
loadConfigSetFlags(SolrResourceLoader loader) throws
*
dsmiley commented on PR #2497:
URL: https://github.com/apache/solr/pull/2497#issuecomment-2150480373
References to JavaVersion (a Gradle class) like `>= JavaVersion.VERSION_16`
should be reviewed to see if we can make changes to remove conditions that will
no longer vary.
Searching f
magibney commented on code in PR #2491:
URL: https://github.com/apache/solr/pull/2491#discussion_r1628080442
##
solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java:
##
@@ -81,31 +77,15 @@ public void init(PluginInfo info) {
log.info("Initializing HdfsU
gerlowskija commented on PR #2499:
URL: https://github.com/apache/solr/pull/2499#issuecomment-2150379839
Three questions I'd like to answer before this is merged:
1. I can imagine scenarios where an advanced user might want to enable this
feature, but still be able to exempt certain q
gerlowskija opened a new pull request, #2499:
URL: https://github.com/apache/solr/pull/2499
https://issues.apache.org/jira/browse/SOLR-17195
# Description
Prefix-based queries consume memory in proportion to the number of terms in
the index that start with the prefix. Shor
uvatbc opened a new pull request, #2498:
URL: https://github.com/apache/solr/pull/2498
https://issues.apache.org/jira/browse/SOLR-X
# Description
The Solr project is considering the usage of JDK 21 at some point.
We need to control which JDK is used in Crav
iamsanjay commented on PR #2497:
URL: https://github.com/apache/solr/pull/2497#issuecomment-2150340085
Test case failing, on main branch as well!
```
./gradlew :solr:core:test --tests
"org.apache.solr.search.function.TestDenseVectorFunctionQuery.floatFieldVectors_shouldReturnFloatSimil
dsmiley commented on PR #2497:
URL: https://github.com/apache/solr/pull/2497#issuecomment-2149871311
I suggest flipping the order. Prep the code for Java 21 compatibility
first so that we don't go adding SupressForbidden to many classes to only
then fix the issue later. i.e. visit the
dsmiley commented on code in PR #2438:
URL: https://github.com/apache/solr/pull/2438#discussion_r1627752555
##
solr/core/src/java/org/apache/solr/core/ConfigSetService.java:
##
@@ -391,6 +402,21 @@ protected NamedList
loadConfigSetFlags(SolrResourceLoader loader) throws
*/
janhoy commented on PR #2056:
URL: https://github.com/apache/solr/pull/2056#issuecomment-2149804604
@risdenk @gerlowskija Do you know whether all of the six new dependencies
are required for our use or if we can exclude some?
--
This is an automated message from the Apache Git Service.
T
iamsanjay commented on PR #2497:
URL: https://github.com/apache/solr/pull/2497#issuecomment-2149791390
> Would it be too much to ask to separate all this URL conversion stuff to a
separate PR, ultimately being its own commit focused on exactly that? Needn't
be another JIRA; needn't touch CH
epugh commented on PR #2497:
URL: https://github.com/apache/solr/pull/2497#issuecomment-2149773970
> > RE URL: If you have IntelliJ Ultimate edition (not sure if Community),
you could do "Structural Replace" to find & replace systematically everywhere.
>
> Like always, Thanks for the
dsmiley commented on code in PR #2497:
URL: https://github.com/apache/solr/pull/2497#discussion_r1627690614
##
solr/solrj/src/java/org/apache/solr/client/solrj/util/ClientUtils.java:
##
@@ -102,8 +104,9 @@ public static String buildRequestUrl(
return basePath + path;
}
iamsanjay commented on PR #2497:
URL: https://github.com/apache/solr/pull/2497#issuecomment-2149754684
> RE URL: If you have IntelliJ Ultimate edition (not sure if Community), you
could do "Structural Replace" to find & replace systematically everywhere.
Like always, Thanks for the air su
gerlowskija merged PR #2492:
URL: https://github.com/apache/solr/pull/2492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
janhoy commented on PR #2056:
URL: https://github.com/apache/solr/pull/2056#issuecomment-2149704266
Precommit fails with
```
> Certain license/ notice files are missing:
- License file missing ('software.amazon.awssdk:checksums-spi:2.25.63')
- License file missing ('softwa
janhoy merged PR #2490:
URL: https://github.com/apache/solr/pull/2490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy merged PR #2373:
URL: https://github.com/apache/solr/pull/2373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy merged PR #2346:
URL: https://github.com/apache/solr/pull/2346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy merged PR #2440:
URL: https://github.com/apache/solr/pull/2440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852414#comment-17852414
]
ASF subversion and git services commented on SOLR-17099:
Commit 9
[
https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-17099.
Fix Version/s: 9.7
Resolution: Fixed
> Unsolicited snitch tag warnings from AttributeFetcher
janhoy merged PR #2278:
URL: https://github.com/apache/solr/pull/2278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852413#comment-17852413
]
ASF subversion and git services commented on SOLR-17099:
Commit d
madrob commented on code in PR #2496:
URL: https://github.com/apache/solr/pull/2496#discussion_r1627568175
##
solr/core/src/test/org/apache/solr/handler/api/V2ApiUtilsTest.java:
##
@@ -36,4 +40,21 @@ public void testReadsDisableV2ApiSysprop() {
assertFalse(
"v2 API
gerlowskija commented on code in PR #2496:
URL: https://github.com/apache/solr/pull/2496#discussion_r1627530042
##
solr/core/src/test/org/apache/solr/handler/api/V2ApiUtilsTest.java:
##
@@ -36,4 +40,21 @@ public void testReadsDisableV2ApiSysprop() {
assertFalse(
"v
gerlowskija commented on code in PR #2496:
URL: https://github.com/apache/solr/pull/2496#discussion_r1627530042
##
solr/core/src/test/org/apache/solr/handler/api/V2ApiUtilsTest.java:
##
@@ -36,4 +40,21 @@ public void testReadsDisableV2ApiSysprop() {
assertFalse(
"v
gerlowskija commented on code in PR #2496:
URL: https://github.com/apache/solr/pull/2496#discussion_r1627529271
##
solr/core/src/java/org/apache/solr/handler/api/V2ApiUtils.java:
##
@@ -87,13 +88,14 @@ public static void squashIntoNamedListWithoutHeader(
squashObjectIntoNam
[
https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852385#comment-17852385
]
Jan Høydahl commented on SOLR-17099:
Seeing the same, and believe it may be a cause f
[
https://issues.apache.org/jira/browse/SOLR-17099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-17099:
--
Assignee: Jan Høydahl
> Unsolicited snitch tag warnings from AttributeFetcherImpl
> --
epugh commented on PR #2479:
URL: https://github.com/apache/solr/pull/2479#issuecomment-2149443128
Thanks for sharing the feedback @gerlowskija ! I think the value of the
tool is only there if your second comment about being able to run a streaming
expression locally is valid, and then ha
psalagnac commented on PR #2278:
URL: https://github.com/apache/solr/pull/2278#issuecomment-2149396008
> 9.7 is our next release, not 9.6
Oh, good catch. This was opened a while ago and I missed the version number
changed. More automation would have definitely helped.
--
This i
anshumg commented on PR #1203:
URL: https://github.com/apache/solr/pull/1203#issuecomment-2149114633
Thanks @HoustonPutman . I think this would be a good first step considering
we've been stuck with this for a while.
--
This is an automated message from the Apache Git Service.
To respond
58 matches
Mail list logo