Re: [PR] Introduce support for Reciprocal Rank Fusion (combining queries) [solr]

2024-06-02 Thread via GitHub
renatoh commented on code in PR #2489: URL: https://github.com/apache/solr/pull/2489#discussion_r1623870400 ## solr/core/src/java/org/apache/solr/search/combining/ReciprocalRankFusion.java: ## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Commented] (SOLR-16093) Tests should not require a working IPv6 networking stack

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851512#comment-17851512 ] ASF subversion and git services commented on SOLR-16093: Commit 5

[jira] [Commented] (SOLR-17277) Circuit Breakers should support a "Warn-only" mode

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851506#comment-17851506 ] ASF subversion and git services commented on SOLR-17277: Commit e

[jira] [Commented] (SOLR-17284) Remove deprecated Blobapi and runtime lib

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851504#comment-17851504 ] ASF subversion and git services commented on SOLR-17284: Commit 2

[jira] [Commented] (SOLR-17307) CachingDirectoryFactory uses the wrong separator on Windows

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851501#comment-17851501 ] ASF subversion and git services commented on SOLR-17307: Commit 9

[jira] [Commented] (SOLR-17290) Update SyncStrategy and PeerSyncWithLeader to use the recovery Http2SolrClient

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851505#comment-17851505 ] ASF subversion and git services commented on SOLR-17290: Commit 2

[jira] [Commented] (SOLR-17302) Migrate filestore APIs to JAX-RS

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851510#comment-17851510 ] ASF subversion and git services commented on SOLR-17302: Commit 8

[jira] [Commented] (SOLR-12813) SolrCloud + 2 shards + subquery + auth = 401 Exception

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851500#comment-17851500 ] ASF subversion and git services commented on SOLR-12813: Commit 0

[jira] [Commented] (SOLR-17271) PerReplicaState: Shard leader elections still impact state.json

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851513#comment-17851513 ] ASF subversion and git services commented on SOLR-17271: Commit b

[jira] [Commented] (SOLR-17044) Improve API path specifying in SolrJ

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851508#comment-17851508 ] ASF subversion and git services commented on SOLR-17044: Commit 4

[jira] [Commented] (SOLR-17137) Prometheus-exporter support SSL on Solr standalone

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851511#comment-17851511 ] ASF subversion and git services commented on SOLR-17137: Commit 5

[jira] [Commented] (SOLR-17247) 'WWW-Authenticate' headers missing in MultiAuthPlugin

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851509#comment-17851509 ] ASF subversion and git services commented on SOLR-17247: Commit 1

[jira] [Commented] (SOLR-16659) DistribPackageStore.distribute may alter node name

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851502#comment-17851502 ] ASF subversion and git services commented on SOLR-16659: Commit 8

[jira] [Commented] (SOLR-17302) Migrate filestore APIs to JAX-RS

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851507#comment-17851507 ] ASF subversion and git services commented on SOLR-17302: Commit 8

[jira] [Commented] (SOLR-17284) Remove deprecated Blobapi and runtime lib

2024-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851503#comment-17851503 ] ASF subversion and git services commented on SOLR-17284: Commit f

Re: [PR] SOLR-17134: Bucketed rate limiting [solr]

2024-06-02 Thread via GitHub
noblepaul closed pull request #2383: SOLR-17134: Bucketed rate limiting URL: https://github.com/apache/solr/pull/2383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Resolved] (SOLR-17271) PerReplicaState: Shard leader elections still impact state.json

2024-06-02 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-17271. --- Fix Version/s: 9.7 Resolution: Fixed fixed > PerReplicaState: Shard leader elections still im

Re: [PR] SOLR-17269: Do not publish synthetic solr core (of Coordinator node) to ZK [solr]

2024-06-02 Thread via GitHub
noblepaul commented on code in PR #2438: URL: https://github.com/apache/solr/pull/2438#discussion_r1623666372 ## solr/core/src/test/org/apache/solr/search/TestCoordinatorRole.java: ## @@ -105,14 +102,11 @@ public void testSimple() throws Exception { assertEquals(10, rsl

Re: [PR] Refactor duplication in UpdateLog.init [solr]

2024-06-02 Thread via GitHub
dsmiley commented on code in PR #2491: URL: https://github.com/apache/solr/pull/2491#discussion_r1623635690 ## solr/core/src/java/org/apache/solr/update/UpdateLog.java: ## @@ -373,11 +373,48 @@ public void init(PluginInfo info) { */ public void init(UpdateHandler uhandler

[PR] Refactor duplication in UpdateLog.init [solr]

2024-06-02 Thread via GitHub
dsmiley opened a new pull request, #2491: URL: https://github.com/apache/solr/pull/2491 with HdfsUpdateLog.init Should just be a wrote refactor here. UpdateLog.init does a bunch of stuff, and HdfsUpdateLog.init does even more stuff yet some same stuff too (without calling su