[PR] Update dependency org.bouncycastle:bcpkix-jdk18on to v1.78.1 [solr]

2024-04-30 Thread via GitHub
solrbot opened a new pull request, #2434: URL: https://github.com/apache/solr/pull/2434 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.bouncycastle:bcpkix-jdk18on](https://www.bouncycastle.org/java.html) ([source](https://to

Re: [PR] SOLR-16810: Under certain situations Solr produces managed schema XML with duplicate fields [solr]

2024-04-30 Thread via GitHub
github-actions[bot] commented on PR #1654: URL: https://github.com/apache/solr/pull/1654#issuecomment-2087740588 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

[PR] SOLR-17263: HttpJdkSolrClient doesn't encode curly braces etc [solr]

2024-04-30 Thread via GitHub
andywebb1975 opened a new pull request, #2433: URL: https://github.com/apache/solr/pull/2433 https://issues.apache.org/jira/browse/SOLR-17263 # Description HttpJdkSolrClient doesn't encode curly braces etc # Solution Use SolrParams' toQueryString() method rather th

[jira] [Commented] (SOLR-599) Lightweight SolrJ client

2024-04-30 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842507#comment-17842507 ] Andy Webb commented on SOLR-599: Sure, I've raised SOLR-17263. > Lightweight SolrJ client

[jira] [Created] (SOLR-17263) HttpJdkSolrClient doesn't encode curly braces etc

2024-04-30 Thread Andy Webb (Jira)
Andy Webb created SOLR-17263: Summary: HttpJdkSolrClient doesn't encode curly braces etc Key: SOLR-17263 URL: https://issues.apache.org/jira/browse/SOLR-17263 Project: Solr Issue Type: Bug

Re: [PR] SOLR-17247: Fix bug - 'WWW-Authenticate' headers missing in MultiAuthPlugin [solr]

2024-04-30 Thread via GitHub
laminelam commented on code in PR #2416: URL: https://github.com/apache/solr/pull/2416#discussion_r1585473717 ## solr/core/src/test/org/apache/solr/security/MultiAuthPluginTest.java: ## @@ -105,6 +110,10 @@ public void testMultiAuthEditAPI() throws Exception { new Sec

Re: [PR] SOLR-17247: Fix bug - 'WWW-Authenticate' headers missing in MultiAuthPlugin [solr]

2024-04-30 Thread via GitHub
laminelam commented on code in PR #2416: URL: https://github.com/apache/solr/pull/2416#discussion_r1585473717 ## solr/core/src/test/org/apache/solr/security/MultiAuthPluginTest.java: ## @@ -105,6 +110,10 @@ public void testMultiAuthEditAPI() throws Exception { new Sec

[jira] [Commented] (SOLR-599) Lightweight SolrJ client

2024-04-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842494#comment-17842494 ] Jan Høydahl commented on SOLR-599: -- Definitely sounds like a bug. Would you mind opening a

Re: [PR] SOLR-17192: Add "field-limiting" URP to catch ill-designed schemas [solr]

2024-04-30 Thread via GitHub
gerlowskija commented on PR #2395: URL: https://github.com/apache/solr/pull/2395#issuecomment-2086978057 Alright, I've removed a lot of the leadership and shard checking logic based on review feedback. I think this should be ready to go, unless you have remaining concerns @dsmiley ?

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-30 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1585444338 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-30 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1585444338 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17192: Add "field-limiting" URP to catch ill-designed schemas [solr]

2024-04-30 Thread via GitHub
gerlowskija commented on code in PR #2395: URL: https://github.com/apache/solr/pull/2395#discussion_r1585300753 ## solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Founda

[jira] [Created] (SOLR-17262) Add SolrParams-style convenience methods to NamedList

2024-04-30 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17262: -- Summary: Add SolrParams-style convenience methods to NamedList Key: SOLR-17262 URL: https://issues.apache.org/jira/browse/SOLR-17262 Project: Solr Issue

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-04-30 Thread via GitHub
dsmiley commented on code in PR #2276: URL: https://github.com/apache/solr/pull/2276#discussion_r1585244557 ## solr/core/src/test-files/solr/collection1/conf/solrconfig-follower-auth.xml: ## Review Comment: This isn't used; right? -- This is an automated message from th

[jira] [Commented] (SOLR-6572) lineshift in solrconfig.xml is not supported

2024-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842445#comment-17842445 ] ASF subversion and git services commented on SOLR-6572: --- Commit 8b4f

[jira] [Resolved] (SOLR-6572) lineshift in solrconfig.xml is not supported

2024-04-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-6572. --- Fix Version/s: 9.7 Resolution: Fixed Merged in main and branch_9x, targeting 9.7. No CHANGES..

[jira] [Commented] (SOLR-6572) lineshift in solrconfig.xml is not supported

2024-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842443#comment-17842443 ] ASF subversion and git services commented on SOLR-6572: --- Commit 033b

Re: [PR] SOLR-6572 Trim whitespace for shards.tolerant and leaderUrl [solr]

2024-04-30 Thread via GitHub
janhoy merged PR #2311: URL: https://github.com/apache/solr/pull/2311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17261: Allow cores to load without a timeout [solr]

2024-04-30 Thread via GitHub
dsmiley commented on code in PR #2431: URL: https://github.com/apache/solr/pull/2431#discussion_r1585179206 ## solr/solrj/src/java/org/apache/solr/common/util/ExecutorUtil.java: ## @@ -143,6 +173,37 @@ static void awaitTermination(ExecutorService pool, long timeout, TimeUnit un

[jira] [Commented] (SOLR-599) Lightweight SolrJ client

2024-04-30 Thread Andy Webb (Jira)
[ https://issues.apache.org/jira/browse/SOLR-599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842429#comment-17842429 ] Andy Webb commented on SOLR-599: hey all, many thanks for your efforts here! We've just be

[jira] [Created] (SOLR-17261) Core loading is capped at 60 seconds

2024-04-30 Thread Houston Putman (Jira)
Houston Putman created SOLR-17261: - Summary: Core loading is capped at 60 seconds Key: SOLR-17261 URL: https://issues.apache.org/jira/browse/SOLR-17261 Project: Solr Issue Type: Bug Sec

Re: [PR] SOLR-17260 ReleaseWizard should remove old minor versions from Docker Hub [solr]

2024-04-30 Thread via GitHub
janhoy commented on PR #2430: URL: https://github.com/apache/solr/pull/2430#issuecomment-2085660550 > Should we remove 9.x.0 when we release 9.x.1? That already happens automatically today since the Dockerfile is `x.y/Dockerfile` in the repo. So you could argue that someone usi

Re: [PR] SOLR-16962: Restore ability to configure tlog directory [solr]

2024-04-30 Thread via GitHub
magibney commented on PR #1895: URL: https://github.com/apache/solr/pull/1895#issuecomment-2085654297 Agreed, and thanks for the nudge @jkrauss82. This got too close to the 9.6 release and I didn't want to rush it in, but I'll go ahead and merge this today or tomorrow. I'm personally hoping

Re: [PR] SOLR-17260 ReleaseWizard should remove old minor versions from Docker Hub [solr]

2024-04-30 Thread via GitHub
madrob commented on PR #2430: URL: https://github.com/apache/solr/pull/2430#issuecomment-2085563407 Should we remove 9.x.0 when we release 9.x.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (SOLR-14115) Deprecate zkcli.sh

2024-04-30 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-14115: - Fix Version/s: main (10.0) > Deprecate zkcli.sh > -- > > Key: SOLR-14115

Re: [PR] SOLR-16962: Restore ability to configure tlog directory [solr]

2024-04-30 Thread via GitHub
jkrauss82 commented on PR #1895: URL: https://github.com/apache/solr/pull/1895#issuecomment-2085519112 When is this going to be merged? I am in progress of configuring a Solr Cloud cluster and was baffled the ulog dir is silently ignored by the Solr server. I believe any seriou

[jira] [Commented] (SOLR-14115) Deprecate zkcli.sh

2024-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842409#comment-17842409 ] ASF subversion and git services commented on SOLR-14115: Commit f

Re: [PR] SOLR-14115: Remove deprecated zkcli script. [solr]

2024-04-30 Thread via GitHub
epugh merged PR #2427: URL: https://github.com/apache/solr/pull/2427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-04-30 Thread via GitHub
HoustonPutman commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-2085509862 Thanks for putting in the work @risdenk ! I will push to add this for 10x only this summer. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-30 Thread via GitHub
epugh commented on PR #2417: URL: https://github.com/apache/solr/pull/2417#issuecomment-2085361541 @laminelam I'm following up my response last night. What do you think about removing the class loader stuff from this PR and just getting the refactor in, and then having a seperate PR targe

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-04-30 Thread via GitHub
risdenk commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-2085355210 > This is an important initiative. If you've given up on it @risdenk, let us know so someone can take over. I'm not actively working on it. @HoustonPutman started this and I just tried

[jira] [Commented] (SOLR-6572) lineshift in solrconfig.xml is not supported

2024-04-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842382#comment-17842382 ] Jan Høydahl commented on SOLR-6572: --- PR for more targeted fix: https://github.com/apache

[jira] [Commented] (SOLR-14115) Deprecate zkcli.sh

2024-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842380#comment-17842380 ] ASF subversion and git services commented on SOLR-14115: Commit 9

[jira] [Commented] (SOLR-14115) Deprecate zkcli.sh

2024-04-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842379#comment-17842379 ] ASF subversion and git services commented on SOLR-14115: Commit b

Re: [PR] SOLR-14115: Update the docs to reference to the bin/solr equivalent of the zkcli.sh [solr]

2024-04-30 Thread via GitHub
epugh merged PR #2428: URL: https://github.com/apache/solr/pull/2428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] [SOLR-10059] Handle appended fq params with macros in distributed requests [solr]

2024-04-30 Thread via GitHub
epugh commented on PR #2303: URL: https://github.com/apache/solr/pull/2303#issuecomment-2085295149 @risdenk didn't you in the past work/deal with some challenges like this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] SOLR-6572 Trim whitespace for shards.tolerant and leaderUrl [solr]

2024-04-30 Thread via GitHub
epugh commented on PR #2311: URL: https://github.com/apache/solr/pull/2311#issuecomment-2085290711 Seems fine... Worth committing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Commented] (SOLR-17032) Jersey MessagingBinders class logs "A class javax.activation.DataSource for a default provider MessageBodyWriter was not found" warning on

2024-04-30 Thread Bernd Wahlen (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842354#comment-17842354 ] Bernd Wahlen commented on SOLR-17032: - still there with jakarta.activation.DataSource

[jira] [Commented] (SOLR-17150) Create MemQueryLimit implementation

2024-04-30 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842339#comment-17842339 ] Andrzej Bialecki commented on SOLR-17150: - After discussing this with other peopl