Re: [PR] SOLR-16825: Generate v2 API SolrRequest bindings [solr]

2024-04-26 Thread via GitHub
dsmiley commented on code in PR #1793: URL: https://github.com/apache/solr/pull/1793#discussion_r1581719562 ## solr/solrj/build.gradle: ## @@ -85,3 +94,73 @@ dependencies { testImplementation 'org.apache.commons:commons-lang3' testImplementation 'io.dropwizard.metrics:metr

Re: [PR] SOLR-16825: Generate v2 API SolrRequest bindings [solr]

2024-04-26 Thread via GitHub
dsmiley commented on PR #1793: URL: https://github.com/apache/solr/pull/1793#issuecomment-2080334301 Quoting me: > At least the use of Jackson is optional. Which is to say, if there is a client that is just doing index/query then it need not include our new "api" module either I h

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-04-26 Thread via GitHub
kotman12 commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1581643844 ## solr/modules/monitor/src/java/org/apache/solr/monitor/update/MonitorUpdateRequestProcessor.java: ## @@ -0,0 +1,265 @@ +/* + * + * * Licensed to the Apache Software Fo

Re: [PR] SOLR-15829: IllegalStateException when using Managed resources (e.g. ManagedSynonymGraphFilterFactory) [solr]

2024-04-26 Thread via GitHub
github-actions[bot] commented on PR #440: URL: https://github.com/apache/solr/pull/440#issuecomment-2080246570 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the

Re: [PR] Parses CHANGES.txt to identify contributors [solr]

2024-04-26 Thread via GitHub
janhoy commented on code in PR #2424: URL: https://github.com/apache/solr/pull/2424#discussion_r1581586209 ## dev-tools/scripts/parseContributorsFromChanges.py: ## @@ -0,0 +1,63 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agr

Re: [PR] Parse authors from git log [solr]

2024-04-26 Thread via GitHub
janhoy commented on PR #2423: URL: https://github.com/apache/solr/pull/2423#issuecomment-2080172984 I did a diff between contributors found by this script and those found by David's CHANGES.txt parser * Most names were the same * Some diffs due to using different name variant in co

Re: [PR] Improving array list and map init [solr]

2024-04-26 Thread via GitHub
dsmiley merged PR #2197: URL: https://github.com/apache/solr/pull/2197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Parses CHANGES.txt to identify contributors [solr]

2024-04-26 Thread via GitHub
dsmiley commented on PR #2424: URL: https://github.com/apache/solr/pull/2424#issuecomment-2080157816 Unlike a Git log, CHANGES.txt has cleaner data and can be edited if we see a formatting or spelling glitch. For better or worse (?), it doesn't have more trivial changes that were not worth

[PR] Parse authors from git log [solr]

2024-04-26 Thread via GitHub
janhoy opened a new pull request, #2423: URL: https://github.com/apache/solr/pull/2423 Script that parses authors and co-authors from git log since last release. Intended for use by Release Manager to obtain a list of developers to credit for a release. ``` usage: parseAuthorsFrom

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-26 Thread via GitHub
rseitz commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r158126 ## solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java: ## @@ -61,22 +75,51 @@ public static void setupCluster() throws Exception {

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-26 Thread via GitHub
rseitz commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r158126 ## solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java: ## @@ -61,22 +75,51 @@ public static void setupCluster() throws Exception {

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-26 Thread via GitHub
rseitz commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r1568077123 ## solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java: ## @@ -61,22 +75,51 @@ public static void setupCluster() throws Exception {

[PR] Remove encryption log prefix. [solr-sandbox]

2024-04-26 Thread via GitHub
bruno-roustant opened a new pull request, #104: URL: https://github.com/apache/solr-sandbox/pull/104 The "encryption" is not useful to search logs as one can search with the package name "encrypt". Remove this prefix for simpler code. -- This is an automated message from the Apache Git Se

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-26 Thread via GitHub
epugh commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1581166810 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost; }

Re: [PR] Shard split supports encryption. [solr-sandbox]

2024-04-26 Thread via GitHub
bruno-roustant commented on PR #103: URL: https://github.com/apache/solr-sandbox/pull/103#issuecomment-2079571812 Oh. I'm glad that you look at this PR, and sorry for being so fast. My previous experience with the PRs waiting in sandbox received no attention. Please let your remarks and I

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-26 Thread via GitHub
epugh commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1581159633 ## solr/core/src/test/org/apache/solr/cloud/SolrCLIZkUtilsTest.java: ## @@ -69,6 +70,7 @@ public static void closeConn() { zkClient = null; } zkAddr = null;

Re: [PR] Shard split supports encryption. [solr-sandbox]

2024-04-26 Thread via GitHub
dsmiley commented on PR #103: URL: https://github.com/apache/solr-sandbox/pull/103#issuecomment-2079561253 I know this is only a "sandbox", but it's disappointing to see a PR proposed and merged inside of an hour with no description or other involvement at all. It's the Wild West here. I

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-26 Thread via GitHub
dsmiley commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1581151423 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] Shard split supports encryption. [solr-sandbox]

2024-04-26 Thread via GitHub
bruno-roustant merged PR #103: URL: https://github.com/apache/solr-sandbox/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[PR] Shard split supports encryption. [solr-sandbox]

2024-04-26 Thread via GitHub
bruno-roustant opened a new pull request, #103: URL: https://github.com/apache/solr-sandbox/pull/103 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc