ichar created SOLR-17233:
Summary: The parameters of q.op are recommended to be trim()
Key: SOLR-17233
URL: https://issues.apache.org/jira/browse/SOLR-17233
Project: Solr
Issue Type: Improvement
HoustonPutman commented on PR #2336:
URL: https://github.com/apache/solr/pull/2336#issuecomment-2057545040
Closing in favor of https://github.com/apache/solr/pull/2349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
HoustonPutman closed pull request #2336: SOLR-16866: Deleting a non-existent
directory should not fail
URL: https://github.com/apache/solr/pull/2336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
magibney commented on code in PR #2349:
URL: https://github.com/apache/solr/pull/2349#discussion_r1566213067
##
solr/core/src/test/org/apache/solr/core/CachingDirectoryFactoryTest.java:
##
@@ -46,6 +57,90 @@ private static class Tracker {
Directory dir;
}
+ @Test
+ p
gus-asf commented on code in PR #2403:
URL: https://github.com/apache/solr/pull/2403#discussion_r1566112815
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -621,46 +684,72 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse
jdyer1 commented on PR #2402:
URL: https://github.com/apache/solr/pull/2402#issuecomment-2057301844
I would like to merge this tomorrow, and also include with 9.6.0, unless
someone says it is too late.
--
This is an automated message from the Apache Git Service.
To respond to the message,
gus-asf commented on code in PR #2403:
URL: https://github.com/apache/solr/pull/2403#discussion_r1566094054
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -621,46 +684,72 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse
gus-asf commented on code in PR #2403:
URL: https://github.com/apache/solr/pull/2403#discussion_r1566090370
##
solr/core/src/java/org/apache/solr/search/QueryLimits.java:
##
@@ -108,12 +110,21 @@ public String formatExceptionMessage(String label) {
* @throws QueryLimitsExcee
[
https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837343#comment-17837343
]
James Dyer commented on SOLR-14763:
---
[PR 2402|https://github.com/apache/solr/pull/2402]
[
https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Dyer updated SOLR-14763:
--
Fix Version/s: main (10.0)
9.6
> SolrJ Client Async HTTP/2 Requests
> --
[
https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Dyer reassigned SOLR-14763:
-
Assignee: James Dyer
> SolrJ Client Async HTTP/2 Requests
> --
>
sigram commented on code in PR #2403:
URL: https://github.com/apache/solr/pull/2403#discussion_r1566013026
##
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##
@@ -621,46 +684,72 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse
gus-asf opened a new pull request, #2403:
URL: https://github.com/apache/solr/pull/2403
https://issues.apache.org/jira/browse/SOLR-17151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
gus-asf commented on PR #2403:
URL: https://github.com/apache/solr/pull/2403#issuecomment-2057147058
Still needs unit test...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sigram commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1565966780
##
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##
@@ -384,6 +384,9 @@ private static NodeConfig
fillSolrSection(NodeConfig.NodeConfigBuilder builder,
kotman12 commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1565959687
##
solr/modules/monitor/src/test-files/solr/collection1/solrconfig-no-cache.xml:
##
@@ -0,0 +1,185 @@
+
+
+
+
+ 9.4
Review Comment:
thanks for catching this! .. I ha
HoustonPutman commented on code in PR #2349:
URL: https://github.com/apache/solr/pull/2349#discussion_r1565912035
##
solr/core/src/test/org/apache/solr/core/CachingDirectoryFactoryTest.java:
##
@@ -46,6 +57,90 @@ private static class Tracker {
Directory dir;
}
+ @Test
jdyer1 commented on code in PR #2402:
URL: https://github.com/apache/solr/pull/2402#discussion_r1565857878
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/Http2SolrClientTest.java:
##
@@ -299,7 +299,9 @@ public void testAsyncException() throws Exception {
public void
jdyer1 commented on code in PR #2402:
URL: https://github.com/apache/solr/pull/2402#discussion_r1565855347
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/LBHttp2SolrClientTest.java:
##
@@ -51,4 +67,249 @@ public void
testLBHttp2SolrClientWithTheseParamNamesInTheUrl()
[
https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837246#comment-17837246
]
Alessandro Benedetti commented on SOLR-17018:
-
The bugfix has been also backp
[
https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro Benedetti updated SOLR-17018:
Fix Version/s: 9.1.2
> LTR queries producing out of memory issues
> ---
[
https://issues.apache.org/jira/browse/SOLR-17018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837242#comment-17837242
]
ASF subversion and git services commented on SOLR-17018:
Commit 1
alessandrobenedetti merged PR #2358:
URL: https://github.com/apache/solr/pull/2358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@so
cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1565699615
##
solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java:
##
@@ -0,0 +1,415 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1565673302
##
solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java:
##
@@ -0,0 +1,415 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cpoerschke commented on PR #2248:
URL: https://github.com/apache/solr/pull/2248#issuecomment-2056670213
> Definitely the segment bit sets need to be sized to the segment, plus no
more than 63 bits for long-alignment.
https://github.com/apache/solr/pull/2248/commits/b1ac97649081aed058
cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1565666020
##
solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java:
##
@@ -0,0 +1,415 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cpoerschke commented on code in PR #2248:
URL: https://github.com/apache/solr/pull/2248#discussion_r1565662583
##
solr/core/src/java/org/apache/solr/search/MultiThreadedSearcher.java:
##
@@ -0,0 +1,415 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cpoerschke commented on code in PR #2382:
URL: https://github.com/apache/solr/pull/2382#discussion_r1565648742
##
solr/modules/monitor/src/test-files/solr/collection1/solrconfig-no-cache.xml:
##
@@ -0,0 +1,185 @@
+
+
+
+
+ 9.4
Review Comment:
minor/maybe
```suggestion
29 matches
Mail list logo
