[jira] [Commented] (SOLR-17221) Http2SolrClient merges case sensitive solr params

2024-04-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834127#comment-17834127 ] David Smiley commented on SOLR-17221: - Yeah that's a bug! PR welcome. > Http2SolrCl

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-04 Thread via GitHub
dsmiley commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2038656809 ehhh, no I don't TBH. At least it's somewhat easy to create a new server/etc/jetty-customAdditions.xml and it'll be loaded. -- This is an automated message from the Apache Git Service. T

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-04 Thread via GitHub
wwelling commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2038265317 @dsmiley, thanks. I'll look into additional Jetty routing. Do think it is a reasonable request of the [Solr Docker](https://hub.docker.com/_/solr) image to afford environment driven context

Re: [PR] SOLR-17018: add QueryLimits support to Learning To Rank rescoring [solr]

2024-04-04 Thread via GitHub
alessandrobenedetti commented on PR #2348: URL: https://github.com/apache/solr/pull/2348#issuecomment-2037757523 All tests are green, I am finalising some checks and I'll merge them tomorrow! Thanks to everyone involved with this contribution! -- This is an automated message from the A

Re: [PR] SOLR-17018: add QueryLimits support to Learning To Rank rescoring [solr]

2024-04-04 Thread via GitHub
alessandrobenedetti commented on code in PR #2348: URL: https://github.com/apache/solr/pull/2348#discussion_r1552106534 ## solr/modules/ltr/src/test/org/apache/solr/ltr/TestLTRQParserPlugin.java: ## @@ -137,4 +140,92 @@ public void ltrNoResultsTest() throws Exception { quer

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-04 Thread via GitHub
dsmiley commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2037652388 @wwelling You can configure Solr's Jetty to map `/foo` to `/solr` if that would help. I think the overall objective was to reduce internal code maintenance on an option that didn't se

Re: [PR] SOLR-17194: CloudHttp2SolrClient doesn't properly use httpClient Builder on certain paths [solr]

2024-04-04 Thread via GitHub
dsmiley commented on code in PR #2378: URL: https://github.com/apache/solr/pull/2378#discussion_r1551972946 ## solr/core/src/test/org/apache/solr/cli/TestExportTool.java: ## @@ -218,6 +231,66 @@ public void testVeryLargeCluster() throws Exception { } } + @Test + publ

[jira] [Comment Edited] (SOLR-15730) Modularize SolrJ

2024-04-04 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833987#comment-17833987 ] Jason Gerlowski edited comment on SOLR-15730 at 4/4/24 3:48 PM: ---

[jira] [Commented] (SOLR-15730) Modularize SolrJ

2024-04-04 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833987#comment-17833987 ] Jason Gerlowski commented on SOLR-15730: bq. Is it strictly needed for SolrJ runt

[jira] [Commented] (SOLR-17158) Terminate distributed processing quickly when query limit is reached

2024-04-04 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833972#comment-17833972 ] Gus Heck commented on SOLR-17158: - Even prior to this change success/fail is a more limit

Re: [PR] Use hostContext property for RewriteHandler rules [solr]

2024-04-04 Thread via GitHub
wwelling commented on PR #2388: URL: https://github.com/apache/solr/pull/2388#issuecomment-2037401821 Hi @epugh, our use case is through a constraint from load balancing requiring matching path with application context path. We have a solution with an additional application sidecar proxy bu

[jira] [Commented] (SOLR-17158) Terminate distributed processing quickly when query limit is reached

2024-04-04 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833944#comment-17833944 ] Andrzej Bialecki commented on SOLR-17158: - [~dsmiley] these are not exactly equiv

Re: [PR] SOLR-17194: CloudHttp2SolrClient doesn't properly use httpClient Builder on certain paths [solr]

2024-04-04 Thread via GitHub
epugh commented on PR #2378: URL: https://github.com/apache/solr/pull/2378#issuecomment-2037299366 Pinged community for feedback, I'd like to merge this week... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Updated] (SOLR-17194) CloudHttp2SolrClient doesn't properly use httpClient Builder on certain paths

2024-04-04 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-17194: - Priority: Major (was: Minor) Summary: CloudHttp2SolrClient doesn't properly use httpClient Builder o

Re: [PR] Ref Guide: Remove note about Zookeeper client TLS support [solr]

2024-04-04 Thread via GitHub
epugh commented on PR #2385: URL: https://github.com/apache/solr/pull/2385#issuecomment-2037284394 Read through this, and it make sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Ref Guide: Remove note about Zookeeper client TLS support [solr]

2024-04-04 Thread via GitHub
epugh commented on PR #2385: URL: https://github.com/apache/solr/pull/2385#issuecomment-2037286214 Thank you for the documentation improvement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Ref Guide: Remove note about Zookeeper client TLS support [solr]

2024-04-04 Thread via GitHub
epugh merged PR #2385: URL: https://github.com/apache/solr/pull/2385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] fix: gen-pkcs12-keystore adds ca.crt input option if it exists (#684) [solr-operator]

2024-04-04 Thread via GitHub
smoldenhauer-ish commented on PR #685: URL: https://github.com/apache/solr-operator/pull/685#issuecomment-2036343833 @HoustonPutman applied your suggestions and added a test that will omit the creation of the keystore and invokes the gen-pkcs12-keystore init container. The shell command ex