dsmiley commented on PR #2376:
URL: https://github.com/apache/solr/pull/2376#issuecomment-2028438789
+1 to murblanc -- SolrClient.close must be called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dsmiley commented on code in PR #1557:
URL: https://github.com/apache/solr/pull/1557#discussion_r1545466879
##
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##
@@ -114,9 +114,33 @@ public class SolrDocumentFetcher {
private final Set largeFields;
-
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1545301666
##
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##
@@ -1828,13 +1823,17 @@ private int fetchPackets(FastInputStream fis) throws
Exception {
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1545293836
##
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##
@@ -1828,13 +1823,17 @@ private int fetchPackets(FastInputStream fis) throws
Exception {
dsmiley commented on code in PR #2374:
URL: https://github.com/apache/solr/pull/2374#discussion_r1545278812
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/DebugServlet.java:
##
@@ -136,6 +137,16 @@ private void recordRequest(HttpServletRequest req,
HttpServletResponse
[
https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832434#comment-17832434
]
David Smiley commented on SOLR-14763:
-
This missed 9.0 sadly; I suppose we could add
[
https://issues.apache.org/jira/browse/SOLR-17211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17832433#comment-17832433
]
David Smiley commented on SOLR-17211:
-
James, please see SOLR-14763 which suggests an
