Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-03-11 Thread via GitHub
dsmiley commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r1520495658 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java: ## @@ -278,64 +285,74 @@ private HttpResponse doPutOrPost( return response; } -

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-03-11 Thread via GitHub
dsmiley commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1520372343 ## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ## @@ -1187,25 +1178,19 @@ private void createEphemeralLiveNode() throws KeeperException, InterruptedExcept

Re: [PR] Add default/optional tables to common-query-parameters.adoc [solr]

2024-03-11 Thread via GitHub
cdrini commented on PR #2340: URL: https://github.com/apache/solr/pull/2340#issuecomment-1989495734 Awesome thanks for the quick review @epugh ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Update required JTS version [solr]

2024-03-11 Thread via GitHub
janhoy commented on PR #2273: URL: https://github.com/apache/solr/pull/2273#issuecomment-1989452934 @dsmiley What do you propose as next steps? Can we cross-link issues in spatial4j and/or lucene that would be dependencies? -- This is an automated message from the Apache Git Service. To r

Re: [PR] Add default/optional tables to common-query-parameters.adoc [solr]

2024-03-11 Thread via GitHub
epugh merged PR #2340: URL: https://github.com/apache/solr/pull/2340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Add default/optional tables to common-query-parameters.adoc [solr]

2024-03-11 Thread via GitHub
epugh commented on PR #2340: URL: https://github.com/apache/solr/pull/2340#issuecomment-1989418043 I built the page locally and it looks great... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] Update dependency org.bitbucket.b_c:jose4j to v0.9.6 [solr]

2024-03-11 Thread via GitHub
janhoy merged PR #2342: URL: https://github.com/apache/solr/pull/2342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[PR] Update dependency org.bitbucket.b_c:jose4j to v0.9.6 [solr]

2024-03-11 Thread via GitHub
solrbot opened a new pull request, #2342: URL: https://github.com/apache/solr/pull/2342 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.bitbucket.b_c:jose4j](https://bitbucket.org/b_c/jose4j/) ([source](https://bitbucket.org/

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-03-11 Thread via GitHub
jdyer1 commented on PR #2259: URL: https://github.com/apache/solr/pull/2259#issuecomment-1989281014 Today I did my best in covering all the possible security manager permissions in *solr-tests.policy*. The *NOCOMIT* with the "all permission" is gone. I will be surprised though once we hav

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-03-11 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r1520321105 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java: ## @@ -287,6 +278,64 @@ private HttpResponse doPutOrPost( return response; } + p

Re: [PR] SOLR-599 New Solr Client Using Java 11+ java.net.http.HttpClient [solr]

2024-03-11 Thread via GitHub
jdyer1 commented on code in PR #2259: URL: https://github.com/apache/solr/pull/2259#discussion_r1520321105 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrJdkClient.java: ## @@ -287,6 +278,64 @@ private HttpResponse doPutOrPost( return response; } + p

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-03-11 Thread via GitHub
risdenk commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-1989244863 @HoustonPutman @dsmiley I'm happy to merge main into this again and resolve any conflicts. can you do another review to make sure all is good before merging to main? -- This is an automated

[jira] [Updated] (SOLR-17200) "False Positive" Race conditions using "/health?requireHealthyCores=true" near startup

2024-03-11 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-17200: -- Summary: "False Positive" Race conditions using "/health?requireHealthyCores=true" near

[jira] [Commented] (SOLR-17200) Race conditions on startup using /health?requireHealthyCores=true

2024-03-11 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825412#comment-17825412 ] Chris M. Hostetter commented on SOLR-17200: --- FWIW: * I found these race condit

[jira] [Created] (SOLR-17200) Race conditions on startup using /health?requireHealthyCores=true

2024-03-11 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-17200: - Summary: Race conditions on startup using /health?requireHealthyCores=true Key: SOLR-17200 URL: https://issues.apache.org/jira/browse/SOLR-17200 Project: So

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-03-11 Thread via GitHub
HoustonPutman commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-1989013704 Yeah let's get this in main. Probably best to not introduce it in a late 9x version -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[PR] Update org.apache.zookeeper:* to v3.9.2 [solr]

2024-03-11 Thread via GitHub
solrbot opened a new pull request, #2341: URL: https://github.com/apache/solr/pull/2341 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.apache.zookeeper:zookeeper-jute](http://zookeeper.apache.org) ([source](https://gitbox.ap

[jira] [Commented] (SOLR-16806) Add a BalanceReplicas API

2024-03-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825358#comment-17825358 ] David Smiley commented on SOLR-16806: - I noticed WAIT_FOR_FINAL_STATE defaults to fal

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2024-03-11 Thread via GitHub
dsmiley commented on PR #760: URL: https://github.com/apache/solr/pull/760#issuecomment-1988385713 AFAIK, ever since #1743 landed, we're no longer blocked on Hadoop-Auth -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use