dsmiley commented on PR #2335:
URL: https://github.com/apache/solr/pull/2335#issuecomment-1985044638
BTW I looked into the test failure in the first run; can't have anything to
do with this PR. I filed https://github.com/apache/solr/pull/2337 to avoid
that NPE.
--
This is an automated m
solrbot commented on PR #2136:
URL: https://github.com/apache/solr/pull/2136#issuecomment-1985017934
### Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not
recognize the last commit author and assumes somebody else may have edited the
PR.
cdrini commented on code in PR #2162:
URL: https://github.com/apache/solr/pull/2162#discussion_r1517147908
##
solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc:
##
@@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the
list of constraints to
|O
cdrini commented on code in PR #2162:
URL: https://github.com/apache/solr/pull/2162#discussion_r1517147908
##
solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc:
##
@@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the
list of constraints to
|O
cdrini commented on PR #2162:
URL: https://github.com/apache/solr/pull/2162#issuecomment-1985016847
Thanks for the review @cpoerschke ! Ok @epugh , this should be ready to go
now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
cdrini commented on code in PR #2162:
URL: https://github.com/apache/solr/pull/2162#discussion_r1517147908
##
solr/solr-ref-guide/modules/query-guide/pages/faceting.adoc:
##
@@ -168,7 +166,7 @@ The `facet.offset` parameter indicates an offset into the
list of constraints to
|O
cdrini commented on PR #2162:
URL: https://github.com/apache/solr/pull/2162#issuecomment-1985010050
Ah apologies for the delay! Will update this week :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
risdenk commented on PR #2136:
URL: https://github.com/apache/solr/pull/2136#issuecomment-1984985404
Pushed e0d36967626d1e261c172739974d534dc81ce219 updating the assertions in
the percentiles for tests.
--
This is an automated message from the Apache Git Service.
To respond to the message
risdenk commented on PR #2136:
URL: https://github.com/apache/solr/pull/2136#issuecomment-1984975758
The nitty gritty details look to be here:
https://github.com/tdunning/t-digest/issues/171
and
https://github.com/opensearch-project/OpenSearch/pull/3634
basically f
risdenk commented on PR #2136:
URL: https://github.com/apache/solr/pull/2136#issuecomment-1984966867
t-digest 3.2 looks fine but 3.3 seems to have different stats assertions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
risdenk commented on PR #2336:
URL: https://github.com/apache/solr/pull/2336#issuecomment-1984950183
The stack trace to me looks like it could be there are 2 things doing the
delete and its a race condition who gets there first? Otherwise I don't see how
we would end up getting this excepti
[
https://issues.apache.org/jira/browse/SOLR-17106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824591#comment-17824591
]
Chris M. Hostetter commented on SOLR-17106:
---
Hi Aparna,
This looks pretty good
dsmiley opened a new pull request, #2337:
URL: https://github.com/apache/solr/pull/2337
Very simple little check. I saw in a failure here:
https://github.com/apache/solr/actions/runs/8180447387/job/22376604762?pr=2335
for TestLBHttp2SolrClient.
--
This is an automated message from the A
HoustonPutman commented on PR #2336:
URL: https://github.com/apache/solr/pull/2336#issuecomment-1984577087
Not sure if this is the end-all-be-all approach. Maybe the error occurs
while it's deleting a child tree, and the rest of the files arent' deleted?
Here's the stack trace:
HoustonPutman commented on PR #2336:
URL: https://github.com/apache/solr/pull/2336#issuecomment-1984574418
> I'm curious, was there a reason for replacing FileUtils.deleteDirectory()
with PathUtils.deleteDirectory()?
@magibney https://issues.apache.org/jira/browse/SOLR-16074
--
Thi
dsmiley commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-1984571357
BTW it's nice to see PRS used/tested more :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
magibney commented on PR #2336:
URL: https://github.com/apache/solr/pull/2336#issuecomment-1984545453
I'm curious, was there a reason for replacing `FileUtils.deleteDirectory()`
with `PathUtils.deleteDirectory()`?
Related: I've been in the CachingDirectoryFactory code recently and I r
dsmiley commented on PR #2230:
URL: https://github.com/apache/solr/pull/2230#issuecomment-1984524318
I believe this has caused NullPointerExceptions in OverseerStatusTest --
createcollection is null. Quite a number of test failures for this since this
was merged.
--
This is an automated
[
https://issues.apache.org/jira/browse/SOLR-17173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev reassigned SOLR-17173:
---
Assignee: Mikhail Khludnev
> Be explicit if distrib.statsCache=true but there's no s
[
https://issues.apache.org/jira/browse/SOLR-17173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mikhail Khludnev updated SOLR-17173:
Fix Version/s: 9.6.0
> Be explicit if distrib.statsCache=true but there's no statsCache con
HoustonPutman commented on code in PR #2336:
URL: https://github.com/apache/solr/pull/2336#discussion_r1516795796
##
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##
@@ -192,7 +191,7 @@ protected void createCore(CommandLine cli, SolrClient
solrClient) throws Excepti
epugh commented on PR #2336:
URL: https://github.com/apache/solr/pull/2336#issuecomment-1984396468
I think I saw some problems with the `RunExampleTool` when I was trying to
make it so you could run it twice, and it would reset the state on the second
run.. weird things happened, so eventu
epugh commented on code in PR #2336:
URL: https://github.com/apache/solr/pull/2336#discussion_r1516792080
##
solr/core/src/java/org/apache/solr/cli/CreateTool.java:
##
@@ -192,7 +191,7 @@ protected void createCore(CommandLine cli, SolrClient
solrClient) throws Excepti
}
[
https://issues.apache.org/jira/browse/SOLR-16866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824530#comment-17824530
]
Houston Putman commented on SOLR-16866:
---
I made a PR for this. Was seeing it in the
HoustonPutman opened a new pull request, #2336:
URL: https://github.com/apache/solr/pull/2336
https://issues.apache.org/jira/browse/SOLR-16866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
HoustonPutman commented on PR #2277:
URL: https://github.com/apache/solr/pull/2277#issuecomment-1983824945
> Hmm, if I'm not mistaken, a merge of this fix to `branch_9_5` may actually
update the 9.5 guide. Let me try.
You are not mistaken!
--
This is an automated message from the A
dsmiley commented on code in PR #2276:
URL: https://github.com/apache/solr/pull/2276#discussion_r1516376085
##
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java:
##
@@ -261,22 +260,23 @@ public String getMessage() {
}
}
- private static HttpClient createHtt
iamsanjay commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-1983485002
Test case which is failing.
> ./gradlew :solr:core:test --tests
"org.apache.solr.handler.TestHealthCheckHandlerLegacyMode.doTestHealthCheckWithReplication"
-Ptests.jvms=2 "-Ptests.jvma
janhoy commented on PR #2277:
URL: https://github.com/apache/solr/pull/2277#issuecomment-1983479315
The theory behind the guide build is that there is not supposed to be any
functional change within a minor version, so any fixes pushed to `branch_9_5`
are by definition bug fixes, including
janhoy commented on PR #2277:
URL: https://github.com/apache/solr/pull/2277#issuecomment-1983469119
I did a push, let's wait for daily build of
https://ci-builds.apache.org/job/Solr/job/solr-reference-guide-official/ - I
think it will kick off in an hour or so.
--
This is an automated me
epugh commented on PR #2277:
URL: https://github.com/apache/solr/pull/2277#issuecomment-1983464922
If this works...I wonder if we should try an establish a stronger
pattern for doc fixes going `main` --> `branch_9x` and --> `branch_9_5` ?
Though it is a whole nother step
--
Thi
janhoy commented on PR #2277:
URL: https://github.com/apache/solr/pull/2277#issuecomment-1983460238
Hmm, if I'm not mistaken, a merge of this fix to `branch_9_5` may actually
update the 9.5 guide. Let me try.
--
This is an automated message from the Apache Git Service.
To respond to the m
epugh commented on PR #2162:
URL: https://github.com/apache/solr/pull/2162#issuecomment-1983459204
hey @cdrini do you want to take another spin though this PR and finalize
some of the changes? Then I'd love to merge this!
--
This is an automated message from the Apache Git Service.
To
epugh commented on PR #2277:
URL: https://github.com/apache/solr/pull/2277#issuecomment-1983453157
I don't believe changes to ref guides go immediately (unlike the website
changes)...We don't have a "quick push this change to productioin ref
guide" that isn't tied to a release. Hopefu
iamsanjay commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-1983413759
There will be no need to add the extra code at SolrRequest level. I can just
call add header for SolrRequest to add "ACCEPT_ENCODING:gzip"
--
This is an automated message from the Ap
iamsanjay commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-1983401595
### Allow Compression
HttpSolrClient provides feature to enable external compression that would
add "ACCEPT_ENCODING: gzip" to the request headers. And we are using this
feature in `Ind
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824384#comment-17824384
]
Andrzej Bialecki commented on SOLR-17199:
-
I didn't see it - thanks for fixing it
janhoy commented on PR #2136:
URL: https://github.com/apache/solr/pull/2136#issuecomment-1983316503
So turns out the Streaming tests fail consistently with this upgrade. Have
not dived into it, but there must be some incompatible behavior between these
versions causing this. Anyone knows wh
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-17199:
--
Assignee: Jan Høydahl
> EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-17199.
Resolution: Fixed
> EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from
> solr-
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17199:
---
Fix Version/s: 9.6.0
> EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from
> solr
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17199:
---
Affects Version/s: 9.5.0
> EnvUtils in solr-solrj is missing EnvToSyspropMappings.properties from
>
janhoy commented on PR #2320:
URL: https://github.com/apache/solr/pull/2320#issuecomment-1983311288
Related JIRA just opened: https://issues.apache.org/jira/browse/SOLR-17199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/SOLR-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824372#comment-17824372
]
Jan Høydahl commented on SOLR-17199:
Hi, did you see [https://github.com/apache/solr/
Andrzej Bialecki created SOLR-17199:
---
Summary: EnvUtils in solr-solrj is missing
EnvToSyspropMappings.properties from solr-core
Key: SOLR-17199
URL: https://issues.apache.org/jira/browse/SOLR-17199
syats commented on PR #2277:
URL: https://github.com/apache/solr/pull/2277#issuecomment-1983196506
The fact that this PR is not yet in the productive documentation
https://solr.apache.org/guide/solr/latest/deployment-guide/docker-faq.html as
of 2023-03-07 is a source of confusion! The curre
janhoy merged PR #2064:
URL: https://github.com/apache/solr/pull/2064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy merged PR #2325:
URL: https://github.com/apache/solr/pull/2325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
48 matches
Mail list logo
