Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

2024-01-15 Thread via GitHub
dsmiley commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1452859545 ## solr/core/src/java/org/apache/solr/util/ThreadStats.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] SOLR-17096: Cluster Singleton plugin support in solr.xml [solr]

2024-01-15 Thread via GitHub
dsmiley commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1452857904 ## solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java: ## @@ -75,6 +73,8 @@ public class ContainerPluginsRegistry implements ClusterPropertiesListener,

Re: [PR] SOLR-17096: Cluster Singleton plugin support in solr.xml [solr]

2024-01-15 Thread via GitHub
dsmiley commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1452677893 ## solr/core/src/java/org/apache/solr/api/ClusterPluginsSourceConfigurator.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Build: validation.git.failOnModified default to isCIBuild [solr]

2024-01-15 Thread via GitHub
dsmiley merged PR #2196: URL: https://github.com/apache/solr/pull/2196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] Update org.mockito:mockito* to v5.8.0 [solr]

2024-01-15 Thread via GitHub
cpoerschke merged PR #2055: URL: https://github.com/apache/solr/pull/2055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] add "test history where?" to dev-docs/FAQ.adoc [solr]

2024-01-15 Thread via GitHub
cpoerschke merged PR #2171: URL: https://github.com/apache/solr/pull/2171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] Update copyright year in NOTICE.txt file. [solr]

2024-01-15 Thread via GitHub
cpoerschke merged PR #2170: URL: https://github.com/apache/solr/pull/2170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] SOLR-16796: introduce org.cyclonedx.bom gradle plugin [solr]

2024-01-15 Thread via GitHub
raboof commented on PR #1203: URL: https://github.com/apache/solr/pull/1203#issuecomment-1892358239 > We should create a JIRA for this btw. Created https://issues.apache.org/jira/browse/SOLR-16796 There's probably more to improve from here, such as: * Generating SBOMs 'per ar

Re: [PR] SOLR-16986: log cpuTime in addition to QTime [solr]

2024-01-15 Thread via GitHub
gbellaton commented on code in PR #2118: URL: https://github.com/apache/solr/pull/2118#discussion_r1452330785 ## solr/core/src/test/org/apache/solr/TestCpuTimeSearch.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib