Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-12 Thread via GitHub
stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1853204160 hmm, it seems the assertion introduced some chaos in the replication tests. will need to check. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2023-12-12 Thread via GitHub
dsmiley commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1424771268 ## solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java: ## @@ -654,11 +655,28 @@ private static PluginInfo[] getClusterSingletonPluginInfos(List node if (node

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-12 Thread via GitHub
stillalex commented on code in PR #2101: URL: https://github.com/apache/solr/pull/2101#discussion_r1424787277 ## solr/core/src/java/org/apache/solr/core/SolrCore.java: ## @@ -1899,6 +1899,18 @@ public boolean isClosed() { return refCount.get() <= 0; } + /** + * Whet

Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2023-12-12 Thread via GitHub
dsmiley commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1424764915 ## solr/core/src/test-files/solr/solr-50-all.xml: ## @@ -76,4 +76,9 @@ + + + + Review Comment: Enforcement would be ideal but not essential. -- T

Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2023-12-12 Thread via GitHub
pjmcarthur commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1424690508 ## solr/core/src/test-files/solr/solr-50-all.xml: ## @@ -76,4 +76,9 @@ + + + + Review Comment: I changed the element name here to `clusterSingleto

Re: [PR] Fix typos and improve grammar in Query Guide [solr]

2023-12-12 Thread via GitHub
epugh commented on PR #2024: URL: https://github.com/apache/solr/pull/2024#issuecomment-1852831270 Thank you @mkhludnev and @AndreyBozhko for pinging me on this. Really great to see our docs getting some :love: -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Fix typos and improve grammar in Query Guide [solr]

2023-12-12 Thread via GitHub
epugh merged PR #2024: URL: https://github.com/apache/solr/pull/2024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Fix typos and improve grammar in Query Guide [solr]

2023-12-12 Thread via GitHub
epugh commented on code in PR #2024: URL: https://github.com/apache/solr/pull/2024#discussion_r1424583805 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -277,7 +277,7 @@ For example: [source,text] -q=supervillians&debugQuery=on&expl

Re: [PR] Fix typos and improve grammar in Query Guide [solr]

2023-12-12 Thread via GitHub
epugh commented on code in PR #2024: URL: https://github.com/apache/solr/pull/2024#discussion_r1424581287 ## solr/solr-ref-guide/modules/query-guide/pages/common-query-parameters.adoc: ## @@ -277,7 +277,7 @@ For example: [source,text] -q=supervillians&debugQuery=on&expl

Re: [PR] Fix typos and improve grammar in Query Guide [solr]

2023-12-12 Thread via GitHub
AndreyBozhko commented on PR #2024: URL: https://github.com/apache/solr/pull/2024#issuecomment-1852819156 Hi @epugh - could you please take a look once more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Clarify the docs about the Package Manager [solr]

2023-12-12 Thread via GitHub
AndreyBozhko commented on code in PR #2147: URL: https://github.com/apache/solr/pull/2147#discussion_r1424577782 ## solr/solr-ref-guide/modules/configuration-guide/pages/package-manager-internals.adoc: ## @@ -394,7 +411,9 @@ Note that the `Version` value is `"2"`, which means th

Re: [PR] clarify the behavior of package manager (#2147) [solr]

2023-12-12 Thread via GitHub
mkhludnev merged PR #2150: URL: https://github.com/apache/solr/pull/2150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[PR] clarify the behavior of package manager (#2147) [solr]

2023-12-12 Thread via GitHub
mkhludnev opened a new pull request, #2150: URL: https://github.com/apache/solr/pull/2150 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Clarify the docs about the Package Manager [solr]

2023-12-12 Thread via GitHub
epugh commented on code in PR #2147: URL: https://github.com/apache/solr/pull/2147#discussion_r1424506268 ## solr/solr-ref-guide/modules/configuration-guide/pages/package-manager-internals.adoc: ## @@ -394,7 +411,9 @@ Note that the `Version` value is `"2"`, which means the plug

Re: [PR] Clarify the docs about the Package Manager [solr]

2023-12-12 Thread via GitHub
mkhludnev merged PR #2147: URL: https://github.com/apache/solr/pull/2147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[PR] Improve jsClient building for gradle caching [solr]

2023-12-12 Thread via GitHub
HoustonPutman opened a new pull request, #2149: URL: https://github.com/apache/solr/pull/2149 Running "gradle clean" should no longer be necessary when changing branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (SOLR-16743) Auto reload keystore/truststore on change

2023-12-12 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795845#comment-17795845 ] Houston Putman commented on SOLR-16743: --- I'll fix the bats test. It's bizarre that

Re: [I] Uninstalling solr helm chart without uninstalling Zookeeper [solr-operator]

2023-12-12 Thread via GitHub
HoustonPutman commented on issue #665: URL: https://github.com/apache/solr-operator/issues/665#issuecomment-1852406673 So if you deploy Solr using the "provided" zookeeper, then it will be managed in tandem with your SolrCloud. If you want the Zookeeper Cluster's lifecycle to be independent

Re: [PR] remove duplicate section from solrconfig.xml (#2146) [solr]

2023-12-12 Thread via GitHub
mkhludnev merged PR #2148: URL: https://github.com/apache/solr/pull/2148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] Remove duplicate section from solrconfig.xml [solr]

2023-12-12 Thread via GitHub
mkhludnev commented on PR #2146: URL: https://github.com/apache/solr/pull/2146#issuecomment-1852329937 Thanks, @AndreyBozhko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] remove duplicate section from solrconfig.xml (#2146) [solr]

2023-12-12 Thread via GitHub
mkhludnev opened a new pull request, #2148: URL: https://github.com/apache/solr/pull/2148 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Remove duplicate section from solrconfig.xml [solr]

2023-12-12 Thread via GitHub
mkhludnev merged PR #2146: URL: https://github.com/apache/solr/pull/2146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-15484) Frequent test failures for JWTAuthPluginIntegrationTest

2023-12-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795819#comment-17795819 ] ASF subversion and git services commented on SOLR-15484: Commit b

[PR] Clarify the docs about the Package Manager [solr]

2023-12-12 Thread via GitHub
AndreyBozhko opened a new pull request, #2147: URL: https://github.com/apache/solr/pull/2147 # Description Update the Reference Guide to clarify the actual behavior of Package Manager, - specifically, how it processes the version strings of packages. # Tests NA #

[PR] Remove duplicate section from solrconfig.xml [solr]

2023-12-12 Thread via GitHub
AndreyBozhko opened a new pull request, #2146: URL: https://github.com/apache/solr/pull/2146 # Description Remove the "Use Filter For Sorted Query" section from solrconfig.xml, since this exact section already appears at lines 464-479 in the same file. I also checked other solr

[jira] [Comment Edited] (SOLR-16367) Umbrella: Migrate away from Apache HttpClient.

2023-12-12 Thread Julio J. Gomez Diaz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795793#comment-17795793 ] Julio J. Gomez Diaz edited comment on SOLR-16367 at 12/12/23 2:57 PM: -

[jira] [Comment Edited] (SOLR-16367) Umbrella: Migrate away from Apache HttpClient.

2023-12-12 Thread Julio J. Gomez Diaz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795793#comment-17795793 ] Julio J. Gomez Diaz edited comment on SOLR-16367 at 12/12/23 2:52 PM: -

[jira] [Commented] (SOLR-15484) Frequent test failures for JWTAuthPluginIntegrationTest

2023-12-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795779#comment-17795779 ] ASF subversion and git services commented on SOLR-15484: Commit 6

Re: [PR] SOLR-15484: use latest version of bouncycastle libraries [solr]

2023-12-12 Thread via GitHub
jdyer1 merged PR #2145: URL: https://github.com/apache/solr/pull/2145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update dependency org.bitbucket.b_c:jose4j to v0.9.4 [solr]

2023-12-12 Thread via GitHub
janhoy merged PR #2143: URL: https://github.com/apache/solr/pull/2143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-15484) Frequent test failures for JWTAuthPluginIntegrationTest

2023-12-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795662#comment-17795662 ] Jan Høydahl commented on SOLR-15484: Looking at http://fucit.org/solr-jenkins-reports