Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-11 Thread via GitHub
dsmiley commented on code in PR #2101: URL: https://github.com/apache/solr/pull/2101#discussion_r1423477681 ## solr/core/src/java/org/apache/solr/core/SolrCore.java: ## @@ -1899,6 +1899,18 @@ public boolean isClosed() { return refCount.get() <= 0; } + /** + * Whethe

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-11 Thread via GitHub
stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1851332731 > But I do think we need a new test to show that "segments" can return a non-null value. I think it should work now but I observed it didn't work on your first try. Basically, a new assert

[PR] SOLR-15484: use latest version of bouncycastle libraries [solr]

2023-12-11 Thread via GitHub
jdyer1 opened a new pull request, #2145: URL: https://github.com/apache/solr/pull/2145 There is now a new failure for `JWTAuthPluginIntegrationTest` [1] because the version of BouncyCastle we are using parses dates using the default locale. (see `org.bouncycastle.asn1.x509.Time`) This is f

Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2023-12-11 Thread via GitHub
dsmiley commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1423212973 ## solr/core/src/test/org/apache/solr/api/NodeConfigContainerPluginsSourceTest.java: ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] SOLR-17060 CoreContainer#create may deadlock with concurrent requests for metrics [solr]

2023-12-11 Thread via GitHub
stillalex commented on PR #2101: URL: https://github.com/apache/solr/pull/2101#issuecomment-1850893336 took a swing at it and could not get it working based on refCount only. I don't think it can be done without major changes (happy to be shown otherwise). the trouble I had was: the init co

Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2023-12-11 Thread via GitHub
pjmcarthur commented on code in PR #2126: URL: https://github.com/apache/solr/pull/2126#discussion_r1423015389 ## solr/core/src/test/org/apache/solr/api/NodeConfigContainerPluginsSourceTest.java: ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Commented] (SOLR-17048) solr-api dependency sope in solr-solrj is wrong

2023-12-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795486#comment-17795486 ] David Smiley commented on SOLR-17048: - Heh; I remember telling Jason about this in [

[jira] [Commented] (SOLR-16743) Auto reload keystore/truststore on change

2023-12-11 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795473#comment-17795473 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-16743: -- It looks lik

[jira] [Resolved] (SOLR-17080) Solr highlights terms that part of the query even though they don't match the actual query

2023-12-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-17080. - Resolution: Not A Problem I suspect you have set {{hl.usePhraseHighlighter=false}} https://solr.

[I] Uninstalling solr helm chart without uninstalling Zookeeper [solr-operator]

2023-12-11 Thread via GitHub
brickpattern opened a new issue, #665: URL: https://github.com/apache/solr-operator/issues/665 hi - this is more of a general Q. I installed Solrcloud with these options to use a ZK-operator installed seperately. --set zookeeper-operator.install=false --set zookeeper-operator.us

[jira] [Commented] (SOLR-16743) Auto reload keystore/truststore on change

2023-12-11 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795441#comment-17795441 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-16743: -- Ugh, sorry,

Re: [I] /var/solr/data with incorrect ownership : Pod not able to write [solr-operator]

2023-12-11 Thread via GitHub
brickpattern commented on issue #662: URL: https://github.com/apache/solr-operator/issues/662#issuecomment-1850476880 I reinstalled the chart. closing the ticket. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (SOLR-15484) Frequent test failures for JWTAuthPluginIntegrationTest

2023-12-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795412#comment-17795412 ] ASF subversion and git services commented on SOLR-15484: Commit 8

Re: [PR] SOLR-16880: Add OAS to 'assembleRelease' task [solr]

2023-12-11 Thread via GitHub
gerlowskija commented on PR #2125: URL: https://github.com/apache/solr/pull/2125#issuecomment-1850287249 > Does anything test this, or must it be manually inspected? I've been validating using the `buildAndPushRelease.py` script, paired with the smoketester. As far as I know we don't

[jira] [Commented] (SOLR-15484) Frequent test failures for JWTAuthPluginIntegrationTest

2023-12-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795384#comment-17795384 ] ASF subversion and git services commented on SOLR-15484: Commit 7

Re: [PR] SOLR-15484 JWTAuthPluginIntegrationTest - dynamically generate the self-signed certificate using the localhost loopback address [solr]

2023-12-11 Thread via GitHub
jdyer1 merged PR #2099: URL: https://github.com/apache/solr/pull/2099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [I] The SolrPrometheusExporter should detect whether to use a basicAuth secret [solr-operator]

2023-12-11 Thread via GitHub
radu-gheorghe commented on issue #654: URL: https://github.com/apache/solr-operator/issues/654#issuecomment-1849972097 I've fiddled with this enough to think that I understand the use-case. It sounds like we have two paths: 1) The user [bootstapped basic auth](https://apache.github.io/so

[PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2023-12-11 Thread via GitHub
iamsanjay opened a new pull request, #2144: URL: https://github.com/apache/solr/pull/2144 https://issues.apache.org/jira/browse/SOLR-16397 # Description V2(JAX-RS) Endpoints for core admin op "command-status". # Solution This commit changes the v2 "comm

[jira] [Created] (SOLR-17103) Add documentation about Hybrid Search with Apache Solr

2023-12-11 Thread Alessandro Benedetti (Jira)
Alessandro Benedetti created SOLR-17103: --- Summary: Add documentation about Hybrid Search with Apache Solr Key: SOLR-17103 URL: https://issues.apache.org/jira/browse/SOLR-17103 Project: Solr

Re: [PR] SOLR-15960 Unified use of system properties and environment variables [solr]

2023-12-11 Thread via GitHub
janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1422315202 ## solr/core/src/java/org/apache/solr/util/EnvUtils.java: ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

Re: [PR] SOLR-16995: Associate with each replica type a property for "numReplicas" [solr]

2023-12-11 Thread via GitHub
pvcnt commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1422275525 ## solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java: ## @@ -18,31 +18,92 @@ import java.util.Arrays; import java.util.EnumMap; +import java.util.EnumSe

Re: [PR] SOLR-15960 Unified use of system properties and environment variables [solr]

2023-12-11 Thread via GitHub
janhoy commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1422119962 ## solr/core/src/java/org/apache/solr/util/EnvUtils.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li