[jira] [Commented] (SOLR-16943) Add client tracing spans to HTTP interaction; at least for Jetty HttpClient

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774706#comment-17774706 ] ASF subversion and git services commented on SOLR-16943: Commit 4

Re: [PR] SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory [solr]

2023-10-12 Thread via GitHub
dsmiley merged PR #1856: URL: https://github.com/apache/solr/pull/1856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] No Jira: some release script tweaks [solr]

2023-10-12 Thread via GitHub
janhoy commented on PR #1976: URL: https://github.com/apache/solr/pull/1976#issuecomment-1760397840 A tip if you just want to familiarize yourself with the release process is to generate html version of wizard on first page. Or use dry-run mode. -- This is an automated message from the Ap

Re: [PR] SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory [solr]

2023-10-12 Thread via GitHub
stillalex commented on code in PR #1856: URL: https://github.com/apache/solr/pull/1856#discussion_r1357397245 ## solr/core/src/java/org/apache/solr/core/TracerConfigurator.java: ## @@ -46,24 +50,49 @@ public static Tracer loadTracer(SolrResourceLoader loader, PluginInfo info) {

Re: [PR] SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory [solr]

2023-10-12 Thread via GitHub
dsmiley commented on code in PR #1856: URL: https://github.com/apache/solr/pull/1856#discussion_r1357356202 ## solr/core/src/java/org/apache/solr/core/TracerConfigurator.java: ## @@ -46,24 +50,49 @@ public static Tracer loadTracer(SolrResourceLoader loader, PluginInfo info) {

[jira] [Updated] (SOLR-16995) Refactor replica types to make it easier to add new ones

2023-10-12 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-16995: Fix Version/s: main (10.0) Resolution: Fixed Status: Resolved (was: Patch Availab

[jira] [Commented] (SOLR-16995) Refactor replica types to make it easier to add new ones

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774674#comment-17774674 ] ASF subversion and git services commented on SOLR-16995: Commit 9

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

2023-10-12 Thread via GitHub
dsmiley merged PR #1928: URL: https://github.com/apache/solr/pull/1928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-16995 Add a ReplicaCount to keep track of replicas per type [solr]

2023-10-12 Thread via GitHub
dsmiley commented on PR #1928: URL: https://github.com/apache/solr/pull/1928#issuecomment-1760281500 HdfsCloudIncrementalBackupTest has been flapping since 2022-08, and lately steadily increasing. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[PR] Support ./gradlew modernizer [solr]

2023-10-12 Thread via GitHub
risdenk opened a new pull request, #2006: URL: https://github.com/apache/solr/pull/2006 https://issues.apache.org/jira/browse/SOLR-X A long time ago I was looking at ways to improve the build process to detect out of date usages. This adds `./gradlew modernizer` that will find thi

[jira] [Updated] (SOLR-17028) Upgrade build tool versions

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17028: Fix Version/s: 9.5 > Upgrade build tool versions > --- > >

Re: [PR] SOLR-16943 Move Jetty HttpClient tracing into InstrumentedHttpListenerFactory [solr]

2023-10-12 Thread via GitHub
stillalex commented on PR #1856: URL: https://github.com/apache/solr/pull/1856#issuecomment-1760243052 @dsmiley pushed the proposed changes.txt and fixed the test. do you think you can review & merge if ok? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] SOLR-17028: Upgrade build tool versions [solr]

2023-10-12 Thread via GitHub
risdenk merged PR #2005: URL: https://github.com/apache/solr/pull/2005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17028: Upgrade build tool versions [solr]

2023-10-12 Thread via GitHub
risdenk commented on PR #2005: URL: https://github.com/apache/solr/pull/2005#issuecomment-1760218626 > my one nit, since I don't understand gradle, is, so, in build.gradlew we have ' and in buildSrc/scriptDepVersions.gradle we have " ;-) yea I made it consistent in the small section i

[jira] [Commented] (SOLR-16995) Refactor replica types to make it easier to add new ones

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774660#comment-17774660 ] ASF subversion and git services commented on SOLR-16995: Commit f

Re: [PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-12 Thread via GitHub
dsmiley merged PR #1981: URL: https://github.com/apache/solr/pull/1981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

Re: [PR] SOLR-17028: Upgrade build tool versions [solr]

2023-10-12 Thread via GitHub
epugh commented on PR #2005: URL: https://github.com/apache/solr/pull/2005#issuecomment-1760101918 is this something `solrbot` could be configured to help us with? Or is our gradle build too idiosyncratic? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Bump golang.org/x/net from 0.15.0 to 0.17.0 [solr-operator]

2023-10-12 Thread via GitHub
HoustonPutman merged PR #644: URL: https://github.com/apache/solr-operator/pull/644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[jira] [Resolved] (SOLR-16431) Can't build Solr with OpenJDK 19

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-16431. - Fix Version/s: 9.2 Resolution: Fixed This was overall fixed by SOLR-16508 and Gradle 7.6

[jira] [Commented] (SOLR-16431) Can't build Solr with OpenJDK 19

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774617#comment-17774617 ] Kevin Risden commented on SOLR-16431: - With SOLR-17026 merged and Gradle 8.4 - its po

[jira] [Resolved] (SOLR-16318) Use up to JDK 11 features - avoid type declaration when <> can be used and Collections.sort(List, Comparator)

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-16318. - Resolution: Fixed Going to mark this as "fixed" for now. I updated the title thanks [~cpoerschke

[jira] [Assigned] (SOLR-16318) Use up to JDK 11 features - avoid type declaration when <> can be used and Collections.sort(List, Comparator)

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16318: --- Assignee: Christine Poerschke > Use up to JDK 11 features - avoid type declaration when <> c

[jira] [Updated] (SOLR-16318) Use up to JDK 11 features - avoid type declaration when <> can be used and Collections.sort(List, Comparator)

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16318: Summary: Use up to JDK 11 features - avoid type declaration when <> can be used and Collections.sor

[jira] [Updated] (SOLR-16318) Use up to JDK 11 features

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16318: Fix Version/s: main (10.0) > Use up to JDK 11 features > - > >

[jira] [Updated] (SOLR-16318) Use up to JDK 11 features

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16318: Fix Version/s: 9.2 > Use up to JDK 11 features > - > > Key:

[jira] [Updated] (SOLR-16318) Use up to JDK 11 features - avoid type declaration when <> can be used and

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16318: Summary: Use up to JDK 11 features - avoid type declaration when <> can be used and (was: Use up

[jira] [Updated] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17026: Resolution: Fixed Status: Resolved (was: Patch Available) > Upgrade to Gradle 8.4 > --

[jira] [Updated] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17026: Fix Version/s: 9.5 > Upgrade to Gradle 8.4 > - > > Key: SOLR-17

[jira] [Updated] (SOLR-16887) The new "Crash On Out Of Memory Error" capability breaks auto-restart on the docker container

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16887: Affects Version/s: 9.2 (was: 9.2.0) > The new "Crash On Out Of Memory Er

[jira] [Updated] (SOLR-17012) Update Apache Hadoop to 3.3.6 and Apache Curator to 5.5.0

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17012: Fix Version/s: 9.5 (was: 9.5.0) > Update Apache Hadoop to 3.3.6 and Apache C

[jira] [Commented] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774607#comment-17774607 ] ASF subversion and git services commented on SOLR-17026: Commit a

[jira] [Commented] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774608#comment-17774608 ] ASF subversion and git services commented on SOLR-17026: Commit 7

[jira] [Commented] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774609#comment-17774609 ] ASF subversion and git services commented on SOLR-17026: Commit f

[jira] [Commented] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774606#comment-17774606 ] ASF subversion and git services commented on SOLR-17026: Commit 9

[jira] [Commented] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774600#comment-17774600 ] ASF subversion and git services commented on SOLR-17026: Commit f

[jira] [Commented] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774603#comment-17774603 ] ASF subversion and git services commented on SOLR-17026: Commit 2

Re: [PR] SOLR-17026: Upgrade to Gradle 8.4 [solr]

2023-10-12 Thread via GitHub
risdenk merged PR #1997: URL: https://github.com/apache/solr/pull/1997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Updated] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17026: Fix Version/s: main (10.0) > Upgrade to Gradle 8.4 > - > > Key:

[jira] [Commented] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774602#comment-17774602 ] ASF subversion and git services commented on SOLR-17026: Commit 8

[jira] [Commented] (SOLR-17026) Upgrade to Gradle 8.4

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774601#comment-17774601 ] ASF subversion and git services commented on SOLR-17026: Commit 3

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2023-10-12 Thread via GitHub
risdenk commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1357066251 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -138,82 +143,82 @@ private SolrZkClient( return; } this.zkServerAddre

Re: [PR] SOLR-16995: Use leaderEligible property where it makes sense [solr]

2023-10-12 Thread via GitHub
HoustonPutman commented on PR #1981: URL: https://github.com/apache/solr/pull/1981#issuecomment-1759837688 I love this. To many single-class/enum cases across the codebase, which makes adding new options much harder. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2023-10-12 Thread via GitHub
HoustonPutman commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1356982674 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/SolrZkClient.java: ## @@ -138,82 +143,82 @@ private SolrZkClient( return; } this.zkServe

Re: [PR] SOLR-16116: Use apache curator to manage the Solr Zookeeper interactions [solr]

2023-10-12 Thread via GitHub
HoustonPutman commented on code in PR #760: URL: https://github.com/apache/solr/pull/760#discussion_r1356972638 ## solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/BeforeReconnect.java: ## @@ -16,6 +16,17 @@ */ package org.apache.solr.common.cloud; -public interfa

Re: [PR] SOLR-17026: Upgrade to Gradle 8.4 [solr]

2023-10-12 Thread via GitHub
risdenk commented on PR #1997: URL: https://github.com/apache/solr/pull/1997#issuecomment-1759782504 They are already fixed. I pulled the one specific to Solr into this branch already - specifically the RUNTIME JAVA env variable stuff. The other was for some of the multi release jars for ve

[jira] [Resolved] (SOLR-17019) ZkCli should create subpaths when necessary

2023-10-12 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-17019. --- Fix Version/s: 9.5 Assignee: Houston Putman Resolution: Fixed > ZkCli should

Re: [PR] SOLR-17027: Removing list.toArray calls with pre sized arrays - core [solr]

2023-10-12 Thread via GitHub
renatoh commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759743725 @risdenk oh, I was searching exactly for this feature when I was doing the clean up, but was not able to find it. thanks al lot, that is very useful! -- This is an automated message

[jira] [Commented] (SOLR-17019) ZkCli should create subpaths when necessary

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774557#comment-17774557 ] ASF subversion and git services commented on SOLR-17019: Commit e

[jira] [Commented] (SOLR-17019) ZkCli should create subpaths when necessary

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774556#comment-17774556 ] ASF subversion and git services commented on SOLR-17019: Commit 2

Re: [PR] SOLR-17027: Removing list.toArray calls with pre sized arrays - core [solr]

2023-10-12 Thread via GitHub
risdenk commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759729386 IntelliJ -> right click on top level project module `solr-root` -> Analyze -> Run Inspection By Name -> search for "toArray call style" -> whole project -> wait for it to finish -- This i

[PR] Gradle deps [solr]

2023-10-12 Thread via GitHub
risdenk opened a new pull request, #2005: URL: https://github.com/apache/solr/pull/2005 https://issues.apache.org/jira/browse/SOLR-X Builds on https://github.com/apache/solr/pull/1997 to get to latest Gradle build dependency versions. -- This is an automated message from th

Re: [PR] SOLR-17027: Removing list.toArray calls with pre sized arrays - core [solr]

2023-10-12 Thread via GitHub
renatoh commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759721213 @risdenk were you able to scan the code for this specific issue within intellij to get the tally for each module for that exact warning? if so how did you do it? -- This is an automated m

Re: [PR] SOLR-17027: Removing list.toArray calls with pre sized arrays - core [solr]

2023-10-12 Thread via GitHub
risdenk commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759697335 @renatoh feel free to open another PR or two for the remaining: Remaining findings solr-root.solr.core.test - 40 solr-root.solr.modules.analysis-extras.main - 1 solr-root.solr.

[jira] [Commented] (SOLR-17027) Removing list.toArray calls with pre sized arrays

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774547#comment-17774547 ] Kevin Risden commented on SOLR-17027: - Remaining findings solr-root.solr.core.test -

[jira] [Commented] (SOLR-17027) Removing list.toArray calls with pre sized arrays

2023-10-12 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774546#comment-17774546 ] ASF subversion and git services commented on SOLR-17027: Commit 6

Re: [PR] SOLR-17027: Removing list.toArray calls with pre sized arrays - core [solr]

2023-10-12 Thread via GitHub
risdenk merged PR #2003: URL: https://github.com/apache/solr/pull/2003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Updated] (SOLR-17027) Removing list.toArray calls with pre sized arrays

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17027: Status: Patch Available (was: Open) > Removing list.toArray calls with pre sized arrays >

[jira] [Commented] (SOLR-17027) Removing list.toArray calls with pre sized arrays

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774543#comment-17774543 ] Kevin Risden commented on SOLR-17027: - Core is being worked on here - https://github.

Re: [PR] SOLR-17027: Removing list.toArray calls with pre sized arrays - core [solr]

2023-10-12 Thread via GitHub
risdenk commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759687304 Ah thanks @renatoh makes sense - I created https://issues.apache.org/jira/browse/SOLR-17027 and updated the description to mention this is just core so far. We can use SOLR-17027 to tie othe

[jira] [Created] (SOLR-17027) Removing list.toArray calls with pre sized arrays

2023-10-12 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-17027: --- Summary: Removing list.toArray calls with pre sized arrays Key: SOLR-17027 URL: https://issues.apache.org/jira/browse/SOLR-17027 Project: Solr Issue Type: Task

Re: [PR] Removing list.toArray calls with pre sized arrays [solr]

2023-10-12 Thread via GitHub
renatoh commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759679190 @risdenk yes, since I only cleaned them up in the module solr/core -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Removing list.toArray calls with pre sized arrays [solr]

2023-10-12 Thread via GitHub
risdenk commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759655586 @renatoh on your branch - I see that there are still ~54 outstanding toArray with sizes according to intellij? Is that expected? -- This is an automated message from the Apache Git Service

Re: [PR] Removing list.toArray calls with pre sized arrays [solr]

2023-10-12 Thread via GitHub
renatoh commented on PR #2003: URL: https://github.com/apache/solr/pull/2003#issuecomment-1759635212 @risdenk thanks for review my PR, are you able to merge the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (SOLR-16795) Upgrade gradle wrapper to 7.6.1

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-16795. - Resolution: Won't Fix > Upgrade gradle wrapper to 7.6.1 > --- > >

[jira] [Commented] (SOLR-16795) Upgrade gradle wrapper to 7.6.1

2023-10-12 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774500#comment-17774500 ] Kevin Risden commented on SOLR-16795: - Looking at Gradle 8.4 here - SOLR-17026 > Upg

[PR] Curator remove retry on conn loss [solr]

2023-10-12 Thread via GitHub
risdenk opened a new pull request, #2004: URL: https://github.com/apache/solr/pull/2004 https://issues.apache.org/jira/browse/SOLR-X This is a follow up to https://github.com/apache/solr/pull/760 that removes `retryOnConnLoss` methods -- This is an automated message from the Ap

[jira] [Commented] (SOLR-13726) Krb5HttpClientBuilder avoid setting javax.security.auth.useSubjectCredsOnly

2023-10-12 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-13726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774350#comment-17774350 ] Bence Szabó commented on SOLR-13726: Hi [~krisden]  We again run into this issue and