David Smiley created SOLR-16960:
---
Summary: Tests should sometimes run with a Tracer (not no-op)
Key: SOLR-16960
URL: https://issues.apache.org/jira/browse/SOLR-16960
Project: Solr
Issue Type: T
dsmiley commented on code in PR #1884:
URL: https://github.com/apache/solr/pull/1884#discussion_r1315389130
##
solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java:
##
@@ -239,7 +239,13 @@ private void dispatch(
if (log.isDebugEnabled()) {
log.debug
janhoy commented on PR #96:
URL: https://github.com/apache/solr/pull/96#issuecomment-1705735290
Keen to get this in, as it blocks a few other related MRs, have you
concluded on your back-compat concerns?
--
This is an automated message from the Apache Git Service.
To respond to the messag
janhoy commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1315215619
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -17,54 +17,49 @@
package org.apache.solr.util.circuitbreaker;
+import com.codahale.
janhoy commented on code in PR #1871:
URL: https://github.com/apache/solr/pull/1871#discussion_r1315169354
##
solr/solr-ref-guide/modules/deployment-guide/pages/circuit-breakers.adoc:
##
@@ -72,6 +73,30 @@ To enable and configure the CPU utilization based circuit
breaker:
Th
janhoy commented on code in PR #1871:
URL: https://github.com/apache/solr/pull/1871#discussion_r1315168456
##
solr/core/src/java/org/apache/solr/handler/ContentStreamHandlerBase.java:
##
@@ -101,6 +112,30 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse
janhoy commented on code in PR #1871:
URL: https://github.com/apache/solr/pull/1871#discussion_r1315162891
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/RequestType.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1705604995
@cpoerschke do you know why patches are applied e.g. "Applying: SOLR-16871:
Synchronize on a larger block to avoid race condition in
CoordinatorHttpSolrCall init" as a part of the build?
psalagnac commented on code in PR #1871:
URL: https://github.com/apache/solr/pull/1871#discussion_r1315124617
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/RequestType.java:
##
@@ -0,0 +1,23 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
[
https://issues.apache.org/jira/browse/SOLR-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Primault updated SOLR-16959:
Status: Patch Available (was: Open)
> Make CoresContainer class configurable
> ---
cpoerschke commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1705524540
> ... (#error: patch failed:
solr/core/src/java/org/apache/solr/cli/AssertTool.java:35
Hmm, I saw on the dev-list some thread(s) w.r.t. the crave CI but didn't
follow too closely a
[
https://issues.apache.org/jira/browse/SOLR-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Primault updated SOLR-16959:
Issue Type: New Feature (was: Improvement)
> Make CoresContainer class configurable
>
pvcnt commented on code in PR #1891:
URL: https://github.com/apache/solr/pull/1891#discussion_r1315064356
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -154,6 +155,7 @@ private NodeConfig(
Set allowPaths,
List allowUrls,
String configSetS
[
https://issues.apache.org/jira/browse/SOLR-16953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761857#comment-17761857
]
Pierre Salagnac commented on SOLR-16953:
I already experienced similar issues wit
renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1705440090
@cpoerschke I did that, and it shows me that my fork is up to date, but I am
getting:
(#error: patch failed:
solr/core/src/java/org/apache/solr/cli/AssertTool.java:35
--
This is an aut
murblanc commented on code in PR #1891:
URL: https://github.com/apache/solr/pull/1891#discussion_r1314992428
##
solr/core/src/java/org/apache/solr/core/CoresLocator.java:
##
@@ -72,4 +73,26 @@ public interface CoresLocator {
* @return a list of all CoreDescriptors found
[
https://issues.apache.org/jira/browse/SOLR-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Primault updated SOLR-16959:
Description:
I would like to be able to hook into the process of discovering and persisting
[
https://issues.apache.org/jira/browse/SOLR-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Primault updated SOLR-16959:
Description:
I would like to be able to hook into the process of discovering and persisting
[
https://issues.apache.org/jira/browse/SOLR-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Primault updated SOLR-16959:
Description:
I would like to be able to hook into the process of discovering and persisting
[
https://issues.apache.org/jira/browse/SOLR-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent Primault updated SOLR-16959:
Component/s: (was: blobstore)
> Make CoresContainer class configurable
> --
Vincent Primault created SOLR-16959:
---
Summary: Make CoresContainer class configurable
Key: SOLR-16959
URL: https://issues.apache.org/jira/browse/SOLR-16959
Project: Solr
Issue Type: Improve
pvcnt opened a new pull request, #1891:
URL: https://github.com/apache/solr/pull/1891
https://issues.apache.org/jira/browse/SOLR-16959
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Plea
cpoerschke opened a new pull request, #1890:
URL: https://github.com/apache/solr/pull/1890
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
janhoy commented on PR #1871:
URL: https://github.com/apache/solr/pull/1871#issuecomment-1705131966
@dsmiley Preparing to merge this, please weigh in with experience from
similar work in your private fork.
--
This is an automated message from the Apache Git Service.
To respond to the mess
cpoerschke commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1705005303
> hmm, now JavaSpotless check is failing on a class I have not touched, this
one:
>
src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java
Hi @rena
cpoerschke commented on PR #1880:
URL: https://github.com/apache/solr/pull/1880#issuecomment-1704992451
> ... it suggests running shellcheck. That isn't actually something I've
ever done, and I wonder if it's the type of thing that should be run as part of
precommit ...
I've not yet
26 matches
Mail list logo