[GitHub] [solr] epugh commented on a diff in pull request #1869: logging, MDC: collection for action=DELETE

2023-08-28 Thread via GitHub
epugh commented on code in PR #1869: URL: https://github.com/apache/solr/pull/1869#discussion_r1308048295 ## solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java: ## @@ -113,7 +113,9 @@ public OverseerCollectionMessageHandler( @Over

[jira] [Commented] (SOLR-16194) Updating Time Routed Alias Parameters Loses Existing Collection List

2023-08-28 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759748#comment-17759748 ] Alex Deparvu commented on SOLR-16194: - [~gus] I think there might have been some issu

[GitHub] [solr] dsmiley opened a new pull request, #1869: logging, MDC: collection for action=DELETE

2023-08-28 Thread via GitHub
dsmiley opened a new pull request, #1869: URL: https://github.com/apache/solr/pull/1869 Logging MDC "collection" is sometimes not set for certain admin API commands like DELETE. Been using this for awhile. I don't love that an assumption is made that perhaps isn't necessaril

[GitHub] [solr] magibney commented on pull request #1351: SOLR-16654: Add support for node-level caches

2023-08-28 Thread via GitHub
magibney commented on PR #1351: URL: https://github.com/apache/solr/pull/1351#issuecomment-1696483941 I'm still pursuing the [mailing list discussion](https://lists.apache.org/thread/ybmp5xz3c9549opqgktdb4cxlpmdmwy4) -- ideally I would not have had to force-push, but I didn't want to hold t

[GitHub] [solr] HoustonPutman commented on pull request #1867: SOLR-16825: Fix response serialization bug

2023-08-28 Thread via GitHub
HoustonPutman commented on PR #1867: URL: https://github.com/apache/solr/pull/1867#issuecomment-1696431220 Ok, rewrote this so that it will use a Reflection-based writer by default, but still use a string writer if no reflection fields are found. This means that we don't need to worry about

[jira] [Commented] (SOLR-16933) The API Tool throws away the response for Solr Queries

2023-08-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759718#comment-17759718 ] Jason Gerlowski commented on SOLR-16933: (A commit I added for SOLR-16825 is defi

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2023-08-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759716#comment-17759716 ] Jason Gerlowski commented on SOLR-16825: Thanks for raising the issue Hoss - it w

[GitHub] [solr] stillalex commented on pull request #1868: SOLR-15367 [9.x] Convert "rid" functionality into a default Tracer

2023-08-28 Thread via GitHub
stillalex commented on PR #1868: URL: https://github.com/apache/solr/pull/1868#issuecomment-1696261185 @dsmiley raising this PR for a discussion on building an OpenTracing version of the always-on tracer that went into main branch based on OTEL. -- This is an automated message from the A

[GitHub] [solr] stillalex opened a new pull request, #1868: SOLR-15367 [9.x] Convert "rid" functionality into a default Tracer

2023-08-28 Thread via GitHub
stillalex opened a new pull request, #1868: URL: https://github.com/apache/solr/pull/1868 https://issues.apache.org/jira/browse/SOLR-15367 # Description **PR for 9.x branch** This is a 9.x version of https://github.com/apache/solr/pull/1854 for evaluation.

[GitHub] [solr] gerlowskija commented on pull request #1867: SOLR-16825: Fix response serialization bug

2023-08-28 Thread via GitHub
gerlowskija commented on PR #1867: URL: https://github.com/apache/solr/pull/1867#issuecomment-1696156967 I considered that approach initially, but ended up scrapping the idea as I was worried that changing JavaBinCodec's default would be too broad and "dangerous". But in hindsight ma

[GitHub] [solr] HoustonPutman commented on pull request #1867: SOLR-16825: Fix response serialization bug

2023-08-28 Thread via GitHub
HoustonPutman commented on PR #1867: URL: https://github.com/apache/solr/pull/1867#issuecomment-1696147981 Ok we don't need to use `ReflectWritable` I think... Basically we can assume that any non-known class uses ReflectWritable... By changing: - `JavaBinCodec:276` -> `writeMap(ne

[GitHub] [solr] HoustonPutman commented on pull request #1867: SOLR-16825: Fix response serialization bug

2023-08-28 Thread via GitHub
HoustonPutman commented on PR #1867: URL: https://github.com/apache/solr/pull/1867#issuecomment-1696136821 Hmm might be able to "fix" this... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [solr] epugh commented on pull request #1867: SOLR-16825: Fix response serialization bug

2023-08-28 Thread via GitHub
epugh commented on PR #1867: URL: https://github.com/apache/solr/pull/1867#issuecomment-1696131760 This feels like a bit of a "sigh" change... So for now through the end of time every pojo gets a rather opaque interface that they implement? ;-). -- This is an automated message from

[GitHub] [solr] gerlowskija opened a new pull request, #1867: SOLR-16825: Fix response serialization bug

2023-08-28 Thread via GitHub
gerlowskija opened a new pull request, #1867: URL: https://github.com/apache/solr/pull/1867 https://issues.apache.org/jira/browse/SOLR-16825 # Description Request and response body POJOs in the 'api' module must implement 'ReflectWritable', a marker interface that indicates

[jira] [Commented] (SOLR-16933) The API Tool throws away the response for Solr Queries

2023-08-28 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759672#comment-17759672 ] Houston Putman commented on SOLR-16933: --- Thanks for finding this [~hossman] , I thi

[jira] [Commented] (SOLR-16933) The API Tool throws away the response for Solr Queries

2023-08-28 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759664#comment-17759664 ] Chris M. Hostetter commented on SOLR-16933: --- For the past 4 days, every testc

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2023-08-28 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759663#comment-17759663 ] Chris M. Hostetter commented on SOLR-16825: --- For the past 4 days, every testcla

[GitHub] [solr] gerlowskija opened a new pull request, #1866: SOLR-16825: Migrate API definitions to submodule, pt 2

2023-08-28 Thread via GitHub
gerlowskija opened a new pull request, #1866: URL: https://github.com/apache/solr/pull/1866 https://issues.apache.org/jira/browse/SOLR-16825 # Description [SOLR-16825](https://issues.apache.org/jira/browse/SOLR-16825) added a new gradle module, 'api', which holds v2 API definit

[jira] [Resolved] (SOLR-16623) SolrClientTestRule for JettySolrRunner

2023-08-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-16623. - Fix Version/s: 9.4 Assignee: David Smiley Resolution: Fixed Thanks [~joshgogz] fo

[jira] [Commented] (SOLR-16623) SolrClientTestRule for JettySolrRunner

2023-08-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759608#comment-17759608 ] ASF subversion and git services commented on SOLR-16623: Commit 1

[jira] [Created] (SOLR-16952) solr.DenseVectorField does not work on a collection with more than 1 shards

2023-08-28 Thread Qais Qadri (Jira)
Qais Qadri created SOLR-16952: - Summary: solr.DenseVectorField does not work on a collection with more than 1 shards Key: SOLR-16952 URL: https://issues.apache.org/jira/browse/SOLR-16952 Project: Solr