[GitHub] [solr] noblepaul merged pull request #1795: SOLR-16898: Remove a println statement from JSONTestUtil

2023-07-18 Thread via GitHub
noblepaul merged PR #1795: URL: https://github.com/apache/solr/pull/1795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[GitHub] [solr] risdenk commented on pull request #1795: SOLR-16898: Remove a println statement from JSONTestUtil

2023-07-18 Thread via GitHub
risdenk commented on PR #1795: URL: https://github.com/apache/solr/pull/1795#issuecomment-1641211575 If it's needed could even leave it as a debug log using the logger, we should not be using println in general -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [solr] patsonluk opened a new pull request, #1795: SOLR-16898: Remove a println statement from JSONTestUtil

2023-07-18 Thread via GitHub
patsonluk opened a new pull request, #1795: URL: https://github.com/apache/solr/pull/1795 https://issues.apache.org/jira/browse/SOLR-16898 # Description It's found that a possibly debug statement https://github.com/apache/solr/commit/e5ca599f51f859834efde2e190ba1e3f17cbb4b1#dif

[jira] [Created] (SOLR-16898) Remove debug println from JSONTestUtil

2023-07-18 Thread Patson Luk (Jira)
Patson Luk created SOLR-16898: - Summary: Remove debug println from JSONTestUtil Key: SOLR-16898 URL: https://issues.apache.org/jira/browse/SOLR-16898 Project: Solr Issue Type: Test Security

[GitHub] [solr] patsonluk commented on pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-18 Thread via GitHub
patsonluk commented on PR #1762: URL: https://github.com/apache/solr/pull/1762#issuecomment-1641127815 @noblepaul what do u think about this proposed fix? 😊 https://github.com/apache/solr/pull/1794 -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [solr] patsonluk opened a new pull request, #1794: SOLR-16871: Fix for duplicated replica added from first coordinator node

2023-07-18 Thread via GitHub
patsonluk opened a new pull request, #1794: URL: https://github.com/apache/solr/pull/1794 https://issues.apache.org/jira/browse/SOLR-16871 # Description PR https://github.com/apache/solr/pull/1762 fixes various race condition for coordinator node. One of the fixes restricts the

[GitHub] [solr] patsonluk commented on pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-18 Thread via GitHub
patsonluk commented on PR #1762: URL: https://github.com/apache/solr/pull/1762#issuecomment-1641101321 @noblepaul I think setting the core name does not work as it would not avoid duplicated core on the first coordinator node. I printed out the replica list on failure and it shows:

[GitHub] [solr] patsonluk commented on pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-18 Thread via GitHub
patsonluk commented on PR #1762: URL: https://github.com/apache/solr/pull/1762#issuecomment-1641086154 > @noblepaul @patsonluk, This test has been failing very frequently since merged, did you have time to take a look? @tflobbe thanks for raising the concern, do u have any links to fa

[GitHub] [solr] tflobbe commented on pull request #1762: SOLR-16871: Race condition in `CoordinatorHttpSolrCall` synthetic collection/replica init

2023-07-18 Thread via GitHub
tflobbe commented on PR #1762: URL: https://github.com/apache/solr/pull/1762#issuecomment-1641078172 @noblepaul @patsonluk, This test has been failing very frequently since merged, did you have time to take a look? -- This is an automated message from the Apache Git Service. To respond t

[jira] [Updated] (SOLR-16896) add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-07-18 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16896: -- Description:   Solr’s JWT authentication plugin uses _implicit flow_ to request _Access_ & _ID tokens_ via OI

[jira] [Updated] (SOLR-16896) add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-07-18 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16896: -- Description:   Solr’s JWT authentication plugin uses _implicit flow_ to request _Access_ & _ID tokens_ via OI

[jira] [Updated] (SOLR-16896) add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-07-18 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16896: -- Description:   Solr’s JWT authentication plugin uses _implicit flow_ to request _Access_ & _ID tokens_ via OI

[GitHub] [solr] gerlowskija commented on pull request #1793: SOLR-16825: Generate v2 API SolrRequest bindings

2023-07-18 Thread via GitHub
gerlowskija commented on PR #1793: URL: https://github.com/apache/solr/pull/1793#issuecomment-1640957209 `./gradlew clean solr:solrj:openApiGenerate` generates the v2 SolrRequest and SolrResponse objects and puts them in `solr/solrj/build/generated`. That said, there's really no reaso

[GitHub] [solr] gerlowskija opened a new pull request, #1793: SOLR-16825: Generate v2 API SolrRequest bindings

2023-07-18 Thread via GitHub
gerlowskija opened a new pull request, #1793: URL: https://github.com/apache/solr/pull/1793 https://issues.apache.org/jira/browse/SOLR-16825 # Description SolrJ contains many SolrRequest implementations (which correspond to individual Solr APIs), but keeping them at parity and

[jira] [Updated] (SOLR-16897) add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-07-18 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16897: -- Description: This is the "back-end" part of '[code with PKCE|https://issues.apache.org/jira/browse/SOLR-16896]

[jira] [Updated] (SOLR-16897) add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-07-18 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16897: -- Description: This is the "back-end" part of '[code with PKCE|https://issues.apache.org/jira/browse/SOLR-16896]

[jira] [Updated] (SOLR-16897) add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-07-18 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16897: -- Description: This is the "back-end" part of 'code with PKCE' contribution.  The back-end code is mainly for c

[jira] [Updated] (SOLR-16897) add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-07-18 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16897: -- Description: This is the "back-end" part of '[code with PKCE](https://issues.apache.org/jira/browse/SOLR-16896

[GitHub] [solr] laminelam opened a new pull request, #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-07-18 Thread via GitHub
laminelam opened a new pull request, #1792: URL: https://github.com/apache/solr/pull/1792 https://issues.apache.org/jira/browse/SOLR-16897 This is the "back-end" part of '[code with PKCE](https://github.com/apache/solr/pull/1791)' contribution. The back-end code is mainly for

[jira] [Created] (SOLR-16897) add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-07-18 Thread Lamine (Jira)
Lamine created SOLR-16897: - Summary: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end) Key: SOLR-16897 URL: https://issues.apache.org/jira/browse/SOLR-16897 Project: Solr Issue Type: Im

[jira] [Updated] (SOLR-16896) add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-07-18 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16896: -- Description:   Solr’s JWT authentication plugin uses _implicit flow_ to request _Access_ & _ID tokens_ via OI

[GitHub] [solr] laminelam opened a new pull request, #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-07-18 Thread via GitHub
laminelam opened a new pull request, #1791: URL: https://github.com/apache/solr/pull/1791 https://issues.apache.org/jira/browse/SOLR-16896 # Description Solr’s JWT authentication plugin uses _implicit flow_ to request _Access_ & _ID tokens_ via OIDC/OAuth 2.0. Due to its

[jira] [Created] (SOLR-16896) add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-07-18 Thread Lamine (Jira)
Lamine created SOLR-16896: - Summary: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end) Key: SOLR-16896 URL: https://issues.apache.org/jira/browse/SOLR-16896 Project: Solr Issue Type: I

[GitHub] [solr] dsmiley commented on pull request #1721: Add CodeQL workflow

2023-07-18 Thread via GitHub
dsmiley commented on PR #1721: URL: https://github.com/apache/solr/pull/1721#issuecomment-1640231849 FYI I requested removal of Lift https://issues.apache.org/jira/browse/INFRA-24802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (SOLR-16842) Eliminate special case code in solrCLI by introducing VersionTool

2023-07-18 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744214#comment-17744214 ] Eric Pugh commented on SOLR-16842: -- Hey [~willdotwhite], would you mind checking out bra

[jira] [Resolved] (SOLR-16842) Eliminate special case code in solrCLI by introducing VersionTool

2023-07-18 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16842. -- Fix Version/s: 9.4 Resolution: Fixed > Eliminate special case code in solrCLI by introducing Ver

[jira] [Commented] (SOLR-16842) Eliminate special case code in solrCLI by introducing VersionTool

2023-07-18 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744213#comment-17744213 ] ASF subversion and git services commented on SOLR-16842: Commit b

[GitHub] [solr] stillalex commented on pull request #1780: SOLR-16889 Rate Limiter should stop processing on 429

2023-07-18 Thread via GitHub
stillalex commented on PR #1780: URL: https://github.com/apache/solr/pull/1780#issuecomment-1640156939 as suggested, I moved the resource cleanup to `doFilter`. I also removed another layer of try/catch blocks. please review carefully, I did my best to not introduce any bugs but I might

[jira] [Commented] (SOLR-16859) Missing Proxy support for Http2SolrClient

2023-07-18 Thread Rainer Koschnick (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744112#comment-17744112 ] Rainer Koschnick commented on SOLR-16859: - [~stillalex] For me testing this is pr

[GitHub] [solr] sonatype-lift[bot] commented on pull request #1790: Update v2-api.adoc: remove mention of /api/c

2023-07-18 Thread via GitHub
sonatype-lift[bot] commented on PR #1790: URL: https://github.com/apache/solr/pull/1790#issuecomment-1639735018 ## Sonatype Lift is retiring Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointme

[GitHub] [solr] mkhludnev opened a new pull request, #1790: Update v2-api.adoc: remove mention of /api/c

2023-07-18 Thread via GitHub
mkhludnev opened a new pull request, #1790: URL: https://github.com/apache/solr/pull/1790 I haven't found this alias anywhere in code. When I checked 9.3 RC1 /api/c isn't handled either. Perhaps I miss something. -- This is an automated message from the Apache Git Service. To resp