[GitHub] [solr] tflobbe commented on a diff in pull request #1359: SOLR-16658 List of permissions returned to Admin UI is not complete

2023-03-30 Thread via GitHub
tflobbe commented on code in PR #1359: URL: https://github.com/apache/solr/pull/1359#discussion_r1153902800 ## solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java: ## @@ -339,7 +341,10 @@ public SimpleOrderedMap getSecurityInfo(SolrQueryRequest req) {

[GitHub] [solr] stillalex commented on pull request #1504: ShardSplitTest flakiness investigation

2023-03-30 Thread via GitHub
stillalex commented on PR #1504: URL: https://github.com/apache/solr/pull/1504#issuecomment-1491075979 minor update. it seems that the 'delete' flow has some version checks in place https://github.com/apache/solr/blob/288e5123dec8f604fe57a9cb13e9770001c0ed57/solr/core/src/java/org/apache/so

[GitHub] [solr-operator] HoustonPutman commented on issue #533: Default liveliness and readiness probes return 401

2023-03-30 Thread via GitHub
HoustonPutman commented on issue #533: URL: https://github.com/apache/solr-operator/issues/533#issuecomment-1490919570 it should be at the top level of your chroot. So `//security.json`. Since you are using LDAP, I would expect other Solr Operator commands to fail, since BasicAuth is

[GitHub] [solr] HoustonPutman commented on pull request #1510: WIP JDK 17

2023-03-30 Thread via GitHub
HoustonPutman commented on PR #1510: URL: https://github.com/apache/solr/pull/1510#issuecomment-1490918161 Looks like it work 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Updated] (SOLR-16727) Support Node Autoscaling in coordination with the Solr Operator

2023-03-30 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-16727: -- Description: This is a part of [SIP-17|https://cwiki.apache.org/confluence/display/SOLR/SIP-17

[GitHub] [solr-operator] HoustonPutman opened a new issue, #536: Support SolrNode autoscaling using the HPA

2023-03-30 Thread via GitHub
HoustonPutman opened a new issue, #536: URL: https://github.com/apache/solr-operator/issues/536 Using Kubernetes' HorizontalPodAutoscaler and new & existing Solr APIs, support autoscaling of Solr Nodes on Kubernetes. This Issue will track the Solr Operator parts of [SIP-17](https://c

[jira] [Created] (SOLR-16727) Support Node Autoscaling in coordination with the Solr Operator

2023-03-30 Thread Houston Putman (Jira)
Houston Putman created SOLR-16727: - Summary: Support Node Autoscaling in coordination with the Solr Operator Key: SOLR-16727 URL: https://issues.apache.org/jira/browse/SOLR-16727 Project: Solr

[jira] [Resolved] (SOLR-8975) SolrClient setters should be deprecated in favor of Solr Client Builder methods

2023-03-30 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-8975. - Fix Version/s: main (10.0) 9.3 Resolution: Fixed > SolrClient setters should be

[jira] [Resolved] (SOLR-16604) Use Builders directly in tests instead of delegating to SolrTestCaseJ4

2023-03-30 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16604. -- Fix Version/s: main (10.0) 9.3 Resolution: Fixed > Use Builders directly in t

[jira] [Commented] (SOLR-16604) Use Builders directly in tests instead of delegating to SolrTestCaseJ4

2023-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707005#comment-17707005 ] ASF subversion and git services commented on SOLR-16604: Commit 2

[GitHub] [solr] epugh merged pull request #1499: SOLR-16604: Use the Builders directly in unit tests

2023-03-30 Thread via GitHub
epugh merged PR #1499: URL: https://github.com/apache/solr/pull/1499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] risdenk commented on pull request #1510: WIP JDK 17

2023-03-30 Thread via GitHub
risdenk commented on PR #1510: URL: https://github.com/apache/solr/pull/1510#issuecomment-1490802621 @HoustonPutman just because you asked here is an example of going to minimum JDK 17 :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [solr] risdenk opened a new pull request, #1510: WIP JDK 17

2023-03-30 Thread via GitHub
risdenk opened a new pull request, #1510: URL: https://github.com/apache/solr/pull/1510 https://issues.apache.org/jira/browse/SOLR-X -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Commented] (SOLR-7609) ShardSplitTest NPE

2023-03-30 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706995#comment-17706995 ] Kevin Risden commented on SOLR-7609: [~stillalex] added some debug to find out that "_

[jira] [Resolved] (SOLR-8122) ShardSplitTest failure due to NPE.

2023-03-30 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden resolved SOLR-8122. Resolution: Duplicate Duplicate of SOLR-7609 > ShardSplitTest failure due to NPE. > ---

[jira] [Assigned] (SOLR-7609) ShardSplitTest NPE

2023-03-30 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-7609: -- Assignee: (was: Shalin Shekhar Mangar) > ShardSplitTest NPE > -- > >

[GitHub] [solr] risdenk commented on pull request #1509: WIP SOLR-16441: Upgrade Jetty to 11.x

2023-03-30 Thread via GitHub
risdenk commented on PR #1509: URL: https://github.com/apache/solr/pull/1509#issuecomment-1490748459 This is NOT ready to merge yet, but tagging some folks to at least look and see if this is something that we want to pursue. I think eventually we will need to go in this direction, but I do

[jira] [Commented] (SOLR-16697) New API support to import index files generated by Embedded SOLR into SOLR Cloud

2023-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706986#comment-17706986 ] ASF subversion and git services commented on SOLR-16697: Commit 0

[jira] [Commented] (SOLR-16441) Upgrade Jetty to 11.x

2023-03-30 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706985#comment-17706985 ] Kevin Risden commented on SOLR-16441: - So kinda as expected modules hadoop-auth and s

[GitHub] [solr] risdenk opened a new pull request, #1509: WIP SOLR-16441: Upgrade Jetty to 11.x

2023-03-30 Thread via GitHub
risdenk opened a new pull request, #1509: URL: https://github.com/apache/solr/pull/1509 https://issues.apache.org/jira/browse/SOLR-16441 This is just an example of what this might look like. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[jira] [Resolved] (SOLR-16726) Include Dath Math expression unit options in Solr Docs

2023-03-30 Thread Justin Sweeney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Sweeney resolved SOLR-16726. --- Resolution: Fixed > Include Dath Math expression unit options in Solr Docs >

[jira] [Commented] (SOLR-16726) Include Dath Math expression unit options in Solr Docs

2023-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706984#comment-17706984 ] ASF subversion and git services commented on SOLR-16726: Commit b

[jira] [Commented] (SOLR-16726) Include Dath Math expression unit options in Solr Docs

2023-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706983#comment-17706983 ] ASF subversion and git services commented on SOLR-16726: Commit 9

[GitHub] [solr] justinrsweeney merged pull request #1507: SOLR-16726: Adding Date Math expression units to docs

2023-03-30 Thread via GitHub
justinrsweeney merged PR #1507: URL: https://github.com/apache/solr/pull/1507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.ap

[GitHub] [solr] epugh commented on a diff in pull request #1507: SOLR-16726: Adding Date Math expression units to docs

2023-03-30 Thread via GitHub
epugh commented on code in PR #1507: URL: https://github.com/apache/solr/pull/1507#discussion_r1153531961 ## solr/core/src/java/org/apache/solr/util/DateMathParser.java: ## @@ -134,6 +134,10 @@ private static Map makeUnitsMap() { // NOTE: Maybe eventually support NANOS

[GitHub] [solr] laminelam opened a new pull request, #1508: SOLR-16687: Add a SolrClassLoader to SolrZkClient

2023-03-30 Thread via GitHub
laminelam opened a new pull request, #1508: URL: https://github.com/apache/solr/pull/1508 https://issues.apache.org/jira/browse/SOLR-16687 # Description A Solr class loader is needed in SolrZKClient to instantiate classes part of modules. This is part of a bigger PR

[GitHub] [solr] justinrsweeney opened a new pull request, #1507: Adding Date Math expression units to docs

2023-03-30 Thread via GitHub
justinrsweeney opened a new pull request, #1507: URL: https://github.com/apache/solr/pull/1507 https://issues.apache.org/jira/browse/SOLR-16726 # Description Adding the Date Math expression units to the Solr Ref Guide. # Solution Just a documenation upd

[jira] [Updated] (SOLR-16687) Add a SolrClassLoader to SolrZkClient

2023-03-30 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16687: -- Summary: Add a SolrClassLoader to SolrZkClient (was: Add AWS Secret Manager support for storing Zookeeper cre

[jira] [Updated] (SOLR-16687) Add AWS Secret Manager support for storing Zookeeper credentials

2023-03-30 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16687: -- Description:   A Solr class loader is needed in SolrZKClient to instantiate classes part of  {_}modules{_}. T

[jira] [Created] (SOLR-16726) Include Dath Math expression unit options in Solr Docs

2023-03-30 Thread Justin Sweeney (Jira)
Justin Sweeney created SOLR-16726: - Summary: Include Dath Math expression unit options in Solr Docs Key: SOLR-16726 URL: https://issues.apache.org/jira/browse/SOLR-16726 Project: Solr Issue T

[jira] [Assigned] (SOLR-16726) Include Dath Math expression unit options in Solr Docs

2023-03-30 Thread Justin Sweeney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Sweeney reassigned SOLR-16726: - Assignee: Justin Sweeney > Include Dath Math expression unit options in Solr Docs >

[jira] [Updated] (SOLR-16687) Add AWS Secret Manager support for storing Zookeeper credentials

2023-03-30 Thread Lamine (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lamine updated SOLR-16687: -- Description:   A Solr class loader is needed in SolrZKClient to instantiate classes part of  {_}modules{_}.  

[GitHub] [solr-operator] j-coll commented on pull request #343: Use global.imagePullSecrets at solr-operator helm chart #338

2023-03-30 Thread via GitHub
j-coll commented on PR #343: URL: https://github.com/apache/solr-operator/pull/343#issuecomment-1490522921 Hi, sorry for the silence. Yes, I'll do the required changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [solr-operator] HoustonPutman commented on a diff in pull request #530: Add readinessCondition to stop traffic to pods that will be stopped

2023-03-30 Thread via GitHub
HoustonPutman commented on code in PR #530: URL: https://github.com/apache/solr-operator/pull/530#discussion_r1153449875 ## controllers/util/solr_update_util_test.go: ## @@ -180,6 +205,26 @@ func TestPickPodsToUpgrade(t *testing.T) { solrCloud.Spec.Replicas = Replicas(4)

[GitHub] [solr] risdenk commented on pull request #1506: WIP JDK 19

2023-03-30 Thread via GitHub
risdenk commented on PR #1506: URL: https://github.com/apache/solr/pull/1506#issuecomment-1490441853 Mostly just testing it out to see if it works. I know there are some float issues with JDK 19 and errorprone - https://issues.apache.org/jira/browse/SOLR-16431 you can see it in the test ab

[GitHub] [solr] HoustonPutman commented on pull request #1506: WIP JDK 19

2023-03-30 Thread via GitHub
HoustonPutman commented on PR #1506: URL: https://github.com/apache/solr/pull/1506#issuecomment-1490433684 Why JDK19/20 over JDK 17? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [solr] dsmiley commented on a diff in pull request #1499: SOLR-16604: Use the Builders directly in unit tests

2023-03-30 Thread via GitHub
dsmiley commented on code in PR #1499: URL: https://github.com/apache/solr/pull/1499#discussion_r1153320060 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractUnloadDistributedZkTestBase.java: ## @@ -285,7 +287,11 @@ private void testCoreUnloadAndLeaders() throws Exce

[GitHub] [solr] epugh commented on pull request #1499: SOLR-16604: Use the Builders directly in unit tests

2023-03-30 Thread via GitHub
epugh commented on PR #1499: URL: https://github.com/apache/solr/pull/1499#issuecomment-1490387080 Tests ran for me @dsmiley... What do you think? Is this ready for merging? It's the last sub ticket under SOLR-8975!!! -- This is an automated message from the Apache Git Service. To res

[jira] [Assigned] (SOLR-16604) Use Builders directly in tests instead of delegating to SolrTestCaseJ4

2023-03-30 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-16604: Assignee: Eric Pugh > Use Builders directly in tests instead of delegating to SolrTestCaseJ4 > ---

[jira] [Resolved] (SOLR-16601) Remove Deprecated Methods from Solr Clients

2023-03-30 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16601. -- Fix Version/s: main (10.0) Resolution: Fixed > Remove Deprecated Methods from Solr Clients > ---

[jira] [Commented] (SOLR-16601) Remove Deprecated Methods from Solr Clients

2023-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706908#comment-17706908 ] ASF subversion and git services commented on SOLR-16601: Commit d

[GitHub] [solr] epugh merged pull request #1496: SOLR-16601: Remove Deprecated Methods from SolrClients

2023-03-30 Thread via GitHub
epugh merged PR #1496: URL: https://github.com/apache/solr/pull/1496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] epugh commented on pull request #1496: SOLR-16601: Remove Deprecated Methods from SolrClients

2023-03-30 Thread via GitHub
epugh commented on PR #1496: URL: https://github.com/apache/solr/pull/1496#issuecomment-1490371981 > @epugh I pushed [9d50904](https://github.com/apache/solr/commit/9d509044238297b0b2fe7bcb7aef946f3f3034f1) which simplifies things I think a lot to just compute a random client if it hasn't

[jira] [Resolved] (SOLR-16706) Reduce the ZLibCompressor compression buffer size

2023-03-30 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant resolved SOLR-16706. --- Resolution: Fixed > Reduce the ZLibCompressor compression buffer size > -

[jira] [Updated] (SOLR-16706) Reduce the ZLibCompressor compression buffer size

2023-03-30 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant updated SOLR-16706: -- Fix Version/s: 9.3 > Reduce the ZLibCompressor compression buffer size > --

[jira] [Commented] (SOLR-16706) Reduce the ZLibCompressor compression buffer size

2023-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706884#comment-17706884 ] ASF subversion and git services commented on SOLR-16706: Commit f

[GitHub] [solr] noblepaul commented on pull request #1485: SOLR-16507: Remove NodeStateProvider & Snitch

2023-03-30 Thread via GitHub
noblepaul commented on PR #1485: URL: https://github.com/apache/solr/pull/1485#issuecomment-1490213738 > hen please share in the JIRA issue as there's a conversation there already. I shall submit a PR for the JIRA -- This is an automated message from the Apache Git Service. To respo

[jira] [Commented] (SOLR-16706) Reduce the ZLibCompressor compression buffer size

2023-03-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706847#comment-17706847 ] ASF subversion and git services commented on SOLR-16706: Commit 3

[GitHub] [solr] bruno-roustant merged pull request #1469: SOLR-16706: Reduce the ZLibCompressor compression buffer size.

2023-03-30 Thread via GitHub
bruno-roustant merged PR #1469: URL: https://github.com/apache/solr/pull/1469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.ap

[jira] [Commented] (SOLR-16722) API to flag a solr node NOT READY for requests

2023-03-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17706754#comment-17706754 ] Thomas Wöckinger commented on SOLR-16722: - When using k8s with solr-operator such

[GitHub] [solr] andywebb1975 commented on pull request #1502: SOLR-16721 Java version detection fails when `_JAVA_OPTIONS` is set

2023-03-30 Thread via GitHub
andywebb1975 commented on PR #1502: URL: https://github.com/apache/solr/pull/1502#issuecomment-1489819681 Removing the `head -1` means multiple lines will pass through - so if `java -version` changed to something along these lines we'd get a multi-line value back: ``` openjdk vers