[jira] [Resolved] (SOLR-10465) setIdField should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-10465. - Resolution: Duplicate Right, Erick removed it years ago. > setIdField should be deprecated in fa

[GitHub] [solr-operator] tzelch opened a new issue, #513: elegant way to enable cross origin resource sharing?

2022-12-29 Thread GitBox
tzelch opened a new issue, #513: URL: https://github.com/apache/solr-operator/issues/513 Hi guys, First of all thanks for everybody working on this operator, it was quite easy to use even for a Solr noob like me :) I need to access my solr cloud from an angular Application and

[GitHub] [solr] epugh commented on a diff in pull request #1177: SOLR-16544: Adding documentation for how to contribute to Solr

2022-12-29 Thread GitBox
epugh commented on code in PR #1177: URL: https://github.com/apache/solr/pull/1177#discussion_r1059084425 ## dev-docs/solr-source-code.adoc: ## @@ -0,0 +1,74 @@ +# Working With Solr Source Code + +## Building Solr from Source + +Download the Java 11 JDK (Java Development Kit) or

[GitHub] [solr] justinrsweeney commented on a diff in pull request #1177: SOLR-16544: Adding documentation for how to contribute to Solr

2022-12-29 Thread GitBox
justinrsweeney commented on code in PR #1177: URL: https://github.com/apache/solr/pull/1177#discussion_r1059084031 ## dev-docs/solr-source-code.adoc: ## @@ -0,0 +1,74 @@ +# Working With Solr Source Code + +## Building Solr from Source + +Download the Java 11 JDK (Java Developmen

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
sonatype-lift[bot] commented on code in PR #1256: URL: https://github.com/apache/solr/pull/1256#discussion_r1059074849 ## solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java: ## @@ -331,10 +331,8 @@ protected boolean useTlogReplicas() { }

[jira] [Commented] (SOLR-16595) Standardize Builder handling of times

2022-12-29 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652903#comment-17652903 ] Gus Heck commented on SOLR-16595: - Or maybe use Duration? > Standardize Builder handling

[jira] [Commented] (SOLR-16595) Standardize Builder handling of times

2022-12-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652902#comment-17652902 ] Eric Pugh commented on SOLR-16595: -- Copied from one of the discussions: Can you use Tim

[GitHub] [solr] epugh commented on a diff in pull request #1247: SOLR-10464: setCollectionCacheTTL should be deprecated in favor of Solr Client Builder methods

2022-12-29 Thread GitBox
epugh commented on code in PR #1247: URL: https://github.com/apache/solr/pull/1247#discussion_r1059069780 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java: ## @@ -270,6 +271,17 @@ public Builder withLBHttpSolrClient(LBHttpSolrClient loadBalanc

[GitHub] [solr] epugh commented on a diff in pull request #1247: SOLR-10464: setCollectionCacheTTL should be deprecated in favor of Solr Client Builder methods

2022-12-29 Thread GitBox
epugh commented on code in PR #1247: URL: https://github.com/apache/solr/pull/1247#discussion_r1059069458 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java: ## @@ -87,6 +87,7 @@ protected CloudLegacySolrClient(Builder builder) { this.stat

[GitHub] [solr] epugh commented on a diff in pull request #1177: SOLR-16544: Adding documentation for how to contribute to Solr

2022-12-29 Thread GitBox
epugh commented on code in PR #1177: URL: https://github.com/apache/solr/pull/1177#discussion_r1059066649 ## dev-docs/solr-source-code.adoc: ## @@ -0,0 +1,74 @@ +# Working With Solr Source Code + +## Building Solr from Source + +Download the Java 11 JDK (Java Development Kit) or

[GitHub] [solr] epugh commented on pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
epugh commented on PR #1256: URL: https://github.com/apache/solr/pull/1256#issuecomment-1367461056 Okay, now I need some ideas @stillalex @dsmiley I've migrated to the Builder all the examples where we create a new SolrCloudClient, so it's easy to add the builder logic. The remainin

[GitHub] [solr] justinrsweeney commented on pull request #1177: SOLR-16544: Adding documentation for how to contribute to Solr

2022-12-29 Thread GitBox
justinrsweeney commented on PR #1177: URL: https://github.com/apache/solr/pull/1177#issuecomment-1367451644 @epugh @janhoy Thank you for the initial feedback, I think this is at a point now for further review when you have some time! -- This is an automated message from the Apache Git Ser

[GitHub] [solr] justinrsweeney commented on pull request #1177: SOLR-16544: Adding documentation for how to contribute to Solr

2022-12-29 Thread GitBox
justinrsweeney commented on PR #1177: URL: https://github.com/apache/solr/pull/1177#issuecomment-1367451097 > I love what you've done here. So, it feels like you have two potential PR's, one on the contributing to solr and the other on moving various `/help/*.txt` files out into proper `.ad

[GitHub] [solr] epugh commented on pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
epugh commented on PR #1256: URL: https://github.com/apache/solr/pull/1256#issuecomment-1367439055 We have places in our tests where the code looks like: ``` indexDoc("collection2", getDoc(id, "1000")); indexDoc("collection2", getDoc(id, "1001")); indexDoc("col

[GitHub] [solr] alessandrobenedetti commented on a diff in pull request #1245: SOLR-16567: KnnQueryParser support for both pre-filters and post-filter

2022-12-29 Thread GitBox
alessandrobenedetti commented on code in PR #1245: URL: https://github.com/apache/solr/pull/1245#discussion_r1059036781 ## solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java: ## @@ -84,30 +84,20 @@ public Query parse() { } private Query getFilterQuery() thr

[jira] [Commented] (SOLR-788) MoreLikeThis should support distributed search

2022-12-29 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652892#comment-17652892 ] Mikhail Khludnev commented on SOLR-788: --- Right. Interesting terms is exactly what we

[GitHub] [solr] mkhludnev closed pull request #1233: SOLR-788: POC transfer MLT queries back and forth.

2022-12-29 Thread GitBox
mkhludnev closed pull request #1233: SOLR-788: POC transfer MLT queries back and forth. URL: https://github.com/apache/solr/pull/1233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [solr] mkhludnev closed pull request #1251: SOLR-788: POC transfer MLT queries via {!bool}

2022-12-29 Thread GitBox
mkhludnev closed pull request #1251: SOLR-788: POC transfer MLT queries via {!bool} URL: https://github.com/apache/solr/pull/1251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [solr] epugh commented on pull request #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
epugh commented on PR #1256: URL: https://github.com/apache/solr/pull/1256#issuecomment-1367432482 @stillalex would love you eyes on this... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [solr] epugh opened a new pull request, #1256: SOLR-10466: setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
epugh opened a new pull request, #1256: URL: https://github.com/apache/solr/pull/1256 https://issues.apache.org/jira/browse/SOLR-10466 # Description SolrClient's should be immutable, and right now for CloudSolrClient the defaultCollection is part of the state and changeable.

[GitHub] [solr] alessandrobenedetti opened a new pull request, #1255: Fix/solr 16588 set default knn algorithm

2022-12-29 Thread GitBox
alessandrobenedetti opened a new pull request, #1255: URL: https://github.com/apache/solr/pull/1255 https://issues.apache.org/jira/browse/SOLR-16588 # Description Bugfix for Hnsw algorithm # Solution Better param validation # Tests minor test reformat

[jira] [Commented] (SOLR-16588) solr.DenseVectorField fieldType without a knnAlgorithm parameter results in error

2022-12-29 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652882#comment-17652882 ] Alessandro Benedetti commented on SOLR-16588: - We are working on the issue an

[jira] [Assigned] (SOLR-10466) setDefaultCollection should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh reassigned SOLR-10466: Assignee: Eric Pugh > setDefaultCollection should be deprecated in favor of SolrClientBuilder > m

[GitHub] [solr] stillalex commented on pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
stillalex commented on PR #1253: URL: https://github.com/apache/solr/pull/1253#issuecomment-1367381679 yep, looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (SOLR-16599) Use ventilated prose in our ascii docs

2022-12-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652872#comment-17652872 ] Eric Pugh commented on SOLR-16599: -- I got some help from the nice folks at https://asci

[GitHub] [solr] epugh commented on pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
epugh commented on PR #1253: URL: https://github.com/apache/solr/pull/1253#issuecomment-1367376695 Okay, are we done? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [solr] epugh commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
epugh commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058982050 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -128,7 +128,7 @@ public class Http2SolrClient extends SolrClient { private static fin

[GitHub] [solr] stillalex commented on a diff in pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
stillalex commented on code in PR #1253: URL: https://github.com/apache/solr/pull/1253#discussion_r1058956658 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -128,7 +128,7 @@ public class Http2SolrClient extends SolrClient { private static

[jira] [Comment Edited] (SOLR-10465) setIdField should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652839#comment-17652839 ] Eric Pugh edited comment on SOLR-10465 at 12/29/22 1:18 PM: U

[jira] [Commented] (SOLR-16590) Standardize Builder method names

2022-12-29 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652843#comment-17652843 ] Uwe Schindler commented on SOLR-16590: -- In Lucene we use with/add: https://lucene.ap

[jira] [Commented] (SOLR-10465) setIdField should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652839#comment-17652839 ] Eric Pugh commented on SOLR-10465: -- Ummmwhere did setIdField go? I swear I saw

[jira] [Commented] (SOLR-10465) setIdField should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652832#comment-17652832 ] Eric Pugh commented on SOLR-10465: -- So [~gerlowskija][~dsmiley] I think I'm going to nee

[jira] [Commented] (SOLR-16590) Standardize Builder method names

2022-12-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652827#comment-17652827 ] Eric Pugh commented on SOLR-16590: -- In working with the various Builders on the Solr cl

[GitHub] [solr] epugh commented on pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
epugh commented on PR #1248: URL: https://github.com/apache/solr/pull/1248#issuecomment-1367286764 I just fixed the lint problem. While it would be good to think about what properties should be settable and which should be system properties, I actually am thinking that is out of scope. I

[jira] [Created] (SOLR-16600) Use Array instead of ObjectList when dealling with parallelCachesRefresh in CloudSolrClient

2022-12-29 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16600: Summary: Use Array instead of ObjectList when dealling with parallelCachesRefresh in CloudSolrClient Key: SOLR-16600 URL: https://issues.apache.org/jira/browse/SOLR-16600 Pro

[GitHub] [solr] epugh commented on pull request #1248: SOLR-10470: setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
epugh commented on PR #1248: URL: https://github.com/apache/solr/pull/1248#issuecomment-1367285064 > > left a few minor comments, overall this looks good. > > is updating the `objectList` method on the table? I find this code a bit ugly (bigger change would be to use an array everywhere,

[GitHub] [solr] epugh commented on pull request #1253: SOLR-10452: setQueryParams should be deprecated in favor of SolrClientBuilder methods

2022-12-29 Thread GitBox
epugh commented on PR #1253: URL: https://github.com/apache/solr/pull/1253#issuecomment-1367273190 > I've seen you only partially took changes from [stillalex@0490ab4](https://github.com/stillalex/solr/commit/0490ab420ff1d90536f3572fc7b17b194f0724c1) was there anything failing? or was the c

[GitHub] [solr-operator] mmoscher commented on issue #489: Add support to set capabilities on Solr cloud container's security context

2022-12-29 Thread GitBox
mmoscher commented on issue #489: URL: https://github.com/apache/solr-operator/issues/489#issuecomment-1367166254 @ollixy you cannot set capabilities on the podSecurityContext, cf. https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#podsecuritycontext-v1-core. What we need