dsmiley commented on code in PR #1215:
URL: https://github.com/apache/solr/pull/1215#discussion_r1054005304
##
solr/core/src/java/org/apache/solr/handler/admin/SplitOp.java:
##
@@ -263,8 +263,9 @@ private void handleGetRanges(CoreAdminHandler.CallInfo it,
String coreName) thro
noblepaul commented on code in PR #1215:
URL: https://github.com/apache/solr/pull/1215#discussion_r1053984023
##
solr/core/src/java/org/apache/solr/handler/admin/SplitOp.java:
##
@@ -263,8 +263,9 @@ private void handleGetRanges(CoreAdminHandler.CallInfo it,
String coreName) thr
[
https://issues.apache.org/jira/browse/SOLR-16332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650051#comment-17650051
]
Jigar Shah commented on SOLR-16332:
---
+1 [~janhoy] and [~krisden], many thanks for the f
dsmiley commented on PR #1215:
URL: https://github.com/apache/solr/pull/1215#issuecomment-1360572392
I can sympathize somewhat but the change/PR as it is strengthens a weak
abstraction, even if it's not pluggable. _Not all abstractions need to be
pluggable_. I could remove some comments a
noblepaul commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1053868722
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -488,4 +468,35 @@ public interface CollectionStateProps {
String SHARDS = "shards";
noblepaul commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1053868722
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -488,4 +468,35 @@ public interface CollectionStateProps {
String SHARDS = "shards";
noblepaul commented on PR #1215:
URL: https://github.com/apache/solr/pull/1215#issuecomment-1360554944
IMHO this PR is mixing both the new capability and impl. If we could just
have a pluggable option, then only experts would use it and that should be fine
--
This is an automated message
Rudi Seitz created SOLR-16594:
-
Summary: eDismax should use startOffset when converting per-field
to per-term queries
Key: SOLR-16594
URL: https://issues.apache.org/jira/browse/SOLR-16594
Project: Solr
dsmiley commented on PR #1215:
URL: https://github.com/apache/solr/pull/1215#issuecomment-1360449384
We could; I just chose not to go that far in this PR. If I did something
trivial, I'd be inclined to then document it, test it. If you think I could
skip some of that (rationale: this is "
hiteshk25 commented on code in PR #1242:
URL: https://github.com/apache/solr/pull/1242#discussion_r1053824406
##
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##
@@ -488,4 +468,35 @@ public interface CollectionStateProps {
String SHARDS = "shards";
noblepaul commented on PR #1215:
URL: https://github.com/apache/solr/pull/1215#issuecomment-1360406066
why can't we make it properly pluggable?
```
"router" : {"class": "fully.qualified.clasName"}
```
--
This is an automated message from the Apache Git Service.
To respond to t
dsmiley commented on PR #1221:
URL: https://github.com/apache/solr/pull/1221#issuecomment-1360080469
We should also probably set & clear the MDC so that if we log an issue, we
have more context (e.g. *which* core).
--
This is an automated message from the Apache Git Service.
To respond to
dsmiley commented on code in PR #1245:
URL: https://github.com/apache/solr/pull/1245#discussion_r1053656524
##
solr/core/src/java/org/apache/solr/search/neural/KnnQParser.java:
##
@@ -80,44 +82,68 @@ public Query parse() {
float[] parsedVectorToSearch = parseVector(vectorTo
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649940#comment-17649940
]
Gabriel Magno commented on SOLR-16567:
--
Not sure if I understood it correctly this "
dsmiley commented on code in PR #1221:
URL: https://github.com/apache/solr/pull/1221#discussion_r1043577392
##
solr/CHANGES.txt:
##
@@ -160,6 +160,8 @@ Other Changes
SOLR-16575: splitshard should honour createNodeSet (noble)
+* SOLR-16577: Always log core load issues (Hayth
HoustonPutman merged PR #508:
URL: https://github.com/apache/solr-operator/pull/508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
[
https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649815#comment-17649815
]
Joel Bernstein edited comment on SOLR-16556 at 12/20/22 3:08 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649815#comment-17649815
]
Joel Bernstein edited comment on SOLR-16556 at 12/20/22 3:07 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649815#comment-17649815
]
Joel Bernstein edited comment on SOLR-16556 at 12/20/22 3:03 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649815#comment-17649815
]
Joel Bernstein edited comment on SOLR-16556 at 12/20/22 3:02 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649815#comment-17649815
]
Joel Bernstein commented on SOLR-16556:
---
[~mnrathod], I did a review of PagingStrea
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649702#comment-17649702
]
Alessandro Benedetti commented on SOLR-16567:
-
And by the way, I think the "t
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17649701#comment-17649701
]
Alessandro Benedetti commented on SOLR-16567:
-
We are checking the PR, when w
23 matches
Mail list logo
