[GitHub] [solr] debe commented on pull request #1155: [SOLR-16497] Allow finer grained locking in SolrCores

2022-12-04 Thread GitBox
debe commented on PR #1155: URL: https://github.com/apache/solr/pull/1155#issuecomment-1336824353 Just as a side note, we are not using transient cores at all. It's just about the lock contention when working with normal cores. Many thanks for providing the benchmark, I'll try to review, ru

[GitHub] [solr] dsmiley commented on pull request #1155: [SOLR-16497] Allow finer grained locking in SolrCores

2022-12-04 Thread GitBox
dsmiley commented on PR #1155: URL: https://github.com/apache/solr/pull/1155#issuecomment-1336723354 Transient cores is not supported in SolrCoud. I know this because I have a hack to make it sort-of work in SolrCloud at work. I've been meaning to review your PR finally; I keep telling m

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-04 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643108#comment-17643108 ] Ishan Chattopadhyaya edited comment on SOLR-16347 at 12/5/22 3:56 AM: -

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-12-04 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643108#comment-17643108 ] Ishan Chattopadhyaya commented on SOLR-16347: - I'm still awaiting clarificati

[jira] [Commented] (SOLR-15732) queries to missing collection are slow

2022-12-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643107#comment-17643107 ] David Smiley commented on SOLR-15732: - Updating Aliases and updating collections are

[jira] [Commented] (SOLR-15732) queries to missing collection are slow

2022-12-04 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643080#comment-17643080 ] Noble Paul commented on SOLR-15732: --- {quote} what about the line below, forceUpdateColl

[jira] [Commented] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

2022-12-04 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643078#comment-17643078 ] Alessandro Benedetti commented on SOLR-16567: - Interesting use case! I'll tak

[jira] [Commented] (SOLR-15732) queries to missing collection are slow

2022-12-04 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643077#comment-17643077 ] Noble Paul commented on SOLR-15732: ---   {quote} Interesting. So you've found that it's f

[GitHub] [solr] noblepaul commented on a diff in pull request #1205: SOLR-16569: Add java system property to overseer queue size

2022-12-04 Thread GitBox
noblepaul commented on code in PR #1205: URL: https://github.com/apache/solr/pull/1205#discussion_r1039052983 ## solr/core/src/java/org/apache/solr/cloud/Overseer.java: ## @@ -336,8 +337,8 @@ public void run() { for (Pair head : queue) { byte[] da

[GitHub] [solr] noblepaul commented on pull request #1210: SOLR-16347: Skip JerseyApp creation when v2 disabled

2022-12-04 Thread GitBox
noblepaul commented on PR #1210: URL: https://github.com/apache/solr/pull/1210#issuecomment-1336554029 There is not reason to disable V2 in the first place. It has been there forever and it is performant. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [solr] dsmiley commented on a diff in pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

2022-12-04 Thread GitBox
dsmiley commented on code in PR #1211: URL: https://github.com/apache/solr/pull/1211#discussion_r1038808801 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java: ## @@ -132,6 +141,8 @@ public static class Builder { protected boolean parallelUpd

[GitHub] [solr] ben-manes commented on pull request #1198: SOLR-16562: Upgrade to Caffeine 3.1.2

2022-12-04 Thread GitBox
ben-manes commented on PR #1198: URL: https://github.com/apache/solr/pull/1198#issuecomment-1336503053 Solr worked around the same issue wrt managed dependencies being unintentionally exported. While this fixes the pom, the gradle module metadata still includes these and, as Gradle prefers