[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-11-30 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641720#comment-17641720 ] Ishan Chattopadhyaya edited comment on SOLR-16347 at 12/1/22 7:32 AM: -

[jira] [Comment Edited] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-11-30 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641720#comment-17641720 ] Ishan Chattopadhyaya edited comment on SOLR-16347 at 12/1/22 7:30 AM: -

[jira] [Commented] (SOLR-16347) Add JAX-RS integration for defining v2 APIs

2022-11-30 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641720#comment-17641720 ] Ishan Chattopadhyaya commented on SOLR-16347: - This last commit here caused a

[GitHub] [solr] dsmiley commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-11-30 Thread GitBox
dsmiley commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1036604971 ## solr/core/src/test/org/apache/solr/core/TestFileSystemConfigSetService.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

[jira] [Commented] (SOLR-16523) gosu binary version

2022-11-30 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641609#comment-17641609 ] Jan Høydahl commented on SOLR-16523: Where is the location of your branch? If you for

[GitHub] [solr] NazerkeBS commented on a diff in pull request #146: SOLR-15787: Implement FileSystemConfigSetService

2022-11-30 Thread GitBox
NazerkeBS commented on code in PR #146: URL: https://github.com/apache/solr/pull/146#discussion_r1036508637 ## solr/core/src/test/org/apache/solr/core/TestFileSystemConfigSetService.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or m

[GitHub] [solr] risdenk merged pull request #1202: Lower gradle heap: 3GB is unnecessary (#11936)

2022-11-30 Thread GitBox
risdenk merged PR #1202: URL: https://github.com/apache/solr/pull/1202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16523) gosu binary version

2022-11-30 Thread Ritchie Gu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641562#comment-17641562 ] Ritchie Gu commented on SOLR-16523: --- Looks like I can't create a branch out of main and

[GitHub] [solr-operator] HoustonPutman commented on issue #497: solr prometheus exporter crashloopbackoff

2022-11-30 Thread GitBox
HoustonPutman commented on issue #497: URL: https://github.com/apache/solr-operator/issues/497#issuecomment-1332632924 is that the same basic auth secret that the SolrCloud is setup to use? have you changed the solrcloud security after creating the cloud? The [default roles provided by the

[jira] [Commented] (SOLR-16523) gosu binary version

2022-11-30 Thread Ritchie Gu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641511#comment-17641511 ] Ritchie Gu commented on SOLR-16523: --- Also, i noticed [https://github.com/apache/solr-d

[GitHub] [solr] risdenk commented on pull request #1202: Lower gradle heap: 3GB is unnecessary (#11936)

2022-11-30 Thread GitBox
risdenk commented on PR #1202: URL: https://github.com/apache/solr/pull/1202#issuecomment-1332613978 Not that I've seen - at least not drastically so. I haven't measured it to be honest. I can say that `./gradlew check -Pvalidation.errorprone=true` on my machine stays at around 20min plus o

[GitHub] [solr] risdenk commented on pull request #1198: SOLR-16562: Upgrade to Caffeine 3.1.2

2022-11-30 Thread GitBox
risdenk commented on PR #1198: URL: https://github.com/apache/solr/pull/1198#issuecomment-1332612611 > Why is this upgrading more than one thing? Pure convenience? Caffeine has no dependencies. https://mvnrepository.com/artifact/com.github.ben-manes.caffeine/caffeine/3.1.2 Caf

[GitHub] [solr] dsmiley commented on pull request #1198: SOLR-16562: Upgrade to Caffeine 3.1.2

2022-11-30 Thread GitBox
dsmiley commented on PR #1198: URL: https://github.com/apache/solr/pull/1198#issuecomment-1332598850 Why is this upgrading more than one thing? Pure convenience? Caffeine has no dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [solr] dsmiley commented on a diff in pull request #1198: SOLR-16562: Upgrade to Caffeine 3.1.2

2022-11-30 Thread GitBox
dsmiley commented on code in PR #1198: URL: https://github.com/apache/solr/pull/1198#discussion_r1036336770 ## solr/CHANGES.txt: ## @@ -140,6 +140,8 @@ Other Changes * SOLR-15861: ConcurrentUpdateSolrClient should work with ManagedExecutorService (Sammy Chu, Kevin Risden)

[GitHub] [solr] gerlowskija commented on a diff in pull request #1196: SOLR-11029 Create a v2 API equivalent for DELETENODE API

2022-11-30 Thread GitBox
gerlowskija commented on code in PR #1196: URL: https://github.com/apache/solr/pull/1196#discussion_r1036281320 ## solr/core/src/test/org/apache/solr/handler/admin/api/DeleteNodeAPITest.java: ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] raboof opened a new pull request, #1203: introduce org.cyclonedx.bom gradle plugin

2022-11-30 Thread GitBox
raboof opened a new pull request, #1203: URL: https://github.com/apache/solr/pull/1203 This draft PR shows one way to generate an SBOM for Solr, mostly for discussion at https://lists.apache.org/thread/j35clzm48s7xxc9671qogzr54bsdj1lz . If we want to take this further I'll create a JIRA iss

[GitHub] [solr] risdenk commented on pull request #1202: Lower gradle heap: 3GB is unnecessary (#11936)

2022-11-30 Thread GitBox
risdenk commented on PR #1202: URL: https://github.com/apache/solr/pull/1202#issuecomment-1332392510 Anecdotally - this has improved using Gradle in Intellij for builds - the machine doesn't seem to freak out as much with smaller Gradle heap. -- This is an automated message from the Apach

[GitHub] [solr] risdenk opened a new pull request, #1202: Lower gradle heap: 3GB is unnecessary (#11936)

2022-11-30 Thread GitBox
risdenk opened a new pull request, #1202: URL: https://github.com/apache/solr/pull/1202 Ports https://github.com/apache/lucene/pull/11936 over to Solr. I've been testing this the past week or so and haven't seen any issues. You need to clear `gradle.properties` in the Solr directory a

[GitHub] [solr] risdenk commented on a diff in pull request #1200: Invert error-prone configuration to be allow-list vs deny-list

2022-11-30 Thread GitBox
risdenk commented on code in PR #1200: URL: https://github.com/apache/solr/pull/1200#discussion_r1036137861 ## gradle/validation/error-prone.gradle: ## @@ -62,53 +62,421 @@ allprojects { prj -> options.errorprone.disableWarningsInGeneratedCode = true options.

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1198: SOLR-16562: Upgrade to Caffeine 3.1.2

2022-11-30 Thread GitBox
HoustonPutman commented on code in PR #1198: URL: https://github.com/apache/solr/pull/1198#discussion_r1036131767 ## solr/CHANGES.txt: ## @@ -140,6 +140,8 @@ Other Changes * SOLR-15861: ConcurrentUpdateSolrClient should work with ManagedExecutorService (Sammy Chu, Kevin Risd

[GitHub] [solr] rmuir commented on a diff in pull request #1200: Invert error-prone configuration to be allow-list vs deny-list

2022-11-30 Thread GitBox
rmuir commented on code in PR #1200: URL: https://github.com/apache/solr/pull/1200#discussion_r1036127682 ## gradle/validation/error-prone.gradle: ## @@ -62,53 +62,421 @@ allprojects { prj -> options.errorprone.disableWarningsInGeneratedCode = true options.er

[GitHub] [solr] gerlowskija commented on a diff in pull request #1144: SOLR-16488: Create a v2 equivalent for /admin/zookeeper v1 APIs

2022-11-30 Thread GitBox
gerlowskija commented on code in PR #1144: URL: https://github.com/apache/solr/pull/1144#discussion_r1036084453 ## solr/core/src/java/org/apache/solr/handler/admin/ZookeeperInfoHandler.java: ## @@ -116,22 +114,22 @@ public Name getPermissionName(AuthorizationContext request) {

[GitHub] [solr] risdenk commented on a diff in pull request #1200: Invert error-prone configuration to be allow-list vs deny-list

2022-11-30 Thread GitBox
risdenk commented on code in PR #1200: URL: https://github.com/apache/solr/pull/1200#discussion_r1036103805 ## gradle/validation/error-prone.gradle: ## @@ -62,53 +62,421 @@ allprojects { prj -> options.errorprone.disableWarningsInGeneratedCode = true options.

[GitHub] [solr] madrob commented on a diff in pull request #1200: Invert error-prone configuration to be allow-list vs deny-list

2022-11-30 Thread GitBox
madrob commented on code in PR #1200: URL: https://github.com/apache/solr/pull/1200#discussion_r1036087253 ## gradle/validation/error-prone.gradle: ## @@ -62,53 +62,421 @@ allprojects { prj -> options.errorprone.disableWarningsInGeneratedCode = true options.e

[GitHub] [solr] risdenk commented on pull request #1200: Invert error-prone configuration to be allow-list vs deny-list

2022-11-30 Thread GitBox
risdenk commented on PR #1200: URL: https://github.com/apache/solr/pull/1200#issuecomment-1332299825 I'm planning to follow up with disabling useless checks - like https://github.com/apache/lucene/pull/11971 is doing for Lucene. -- This is an automated message from the Apache Git Service.

[GitHub] [solr] risdenk opened a new pull request, #1200: Invert error-prone configuration to be allow-list vs deny-list

2022-11-30 Thread GitBox
risdenk opened a new pull request, #1200: URL: https://github.com/apache/solr/pull/1200 This ports https://github.com/apache/lucene/pull/11970 to Solr. Copied commit message from Lucene below: This does not change the semantics or performance of our setup. Instead, it explicitl

[jira] [Commented] (SOLR-16392) Cosmetic, REST-fulness improvements to v2 shard, replica, and replicaprop CRUD APIs

2022-11-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641370#comment-17641370 ] ASF subversion and git services commented on SOLR-16392: Commit b

[jira] [Commented] (SOLR-16562) Upgrade to Caffeine 3.1.2

2022-11-30 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641345#comment-17641345 ] Gus Heck commented on SOLR-16562: - Since the PR for this upgrades woodstox-core to 6.4, t

[GitHub] [solr] fsparv commented on pull request #1198: SOLR-16562: Upgrade to Caffeine 3.1.2

2022-11-30 Thread GitBox
fsparv commented on PR #1198: URL: https://github.com/apache/solr/pull/1198#issuecomment-1332254281 Can we fix the typo comment at the top to say woodstox-core 6.4 not 2.4? Also it looks like this happens to address CVE-2022-40152 -- This is an automated message from the Apache Git Servi

[GitHub] [solr-operator] ivanspasov99 opened a new issue, #500: [Feature] Cross Collection Join Query to return Filter Fields

2022-11-30 Thread GitBox
ivanspasov99 opened a new issue, #500: URL: https://github.com/apache/solr-operator/issues/500 Is it possible to have the option in the Cross Collection Join Query to return the joined fields also? I have succeeded in filtering by field in another collection which tells me that on runtime S

[jira] [Comment Edited] (SOLR-16556) Solr stream expression: Implement Page Streaming Decorator to allow results to be displayed with pagination.

2022-11-30 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641201#comment-17641201 ] Eric Pugh edited comment on SOLR-16556 at 11/30/22 9:56 AM: a

[jira] [Commented] (SOLR-16556) Solr stream expression: Implement Page Streaming Decorator to allow results to be displayed with pagination.

2022-11-30 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17641201#comment-17641201 ] Eric Pugh commented on SOLR-16556: -- awesome!    [~jbernste] would love your feedback on

[GitHub] [solr] epugh commented on pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2022-11-30 Thread GitBox
epugh commented on PR #1182: URL: https://github.com/apache/solr/pull/1182#issuecomment-1331888076 @bszabo97 when you are ready on this PR, ping me and I can do some of that manual testing with BASIC auth etc... -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2022-11-30 Thread GitBox
bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1035705543 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -968,38 +978,39 @@ public Map getStatus(String solrUrl) throws Exception { if (!solrUrl.endsWith(

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2022-11-30 Thread GitBox
bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1035704235 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -968,38 +978,39 @@ public Map getStatus(String solrUrl) throws Exception { if (!solrUrl.endsWith(

[GitHub] [solr] bszabo97 commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

2022-11-30 Thread GitBox
bszabo97 commented on code in PR #1182: URL: https://github.com/apache/solr/pull/1182#discussion_r1035700491 ## solr/core/src/java/org/apache/solr/util/SolrCLI.java: ## @@ -618,6 +623,10 @@ private static boolean exceptionIsAuthRelated(Exception exc) { && Arrays.asList

[jira] [Resolved] (SOLR-16565) posting the same file to the package store should not throw an error

2022-11-30 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul resolved SOLR-16565. --- Fix Version/s: 9.2 Resolution: Fixed > posting the same file to the package store should not t