dsmiley commented on PR #1158:
URL: https://github.com/apache/solr/pull/1158#issuecomment-1329890511
Note that SOLR-16368 is marked "Resolved" already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dsmiley commented on PR #1158:
URL: https://github.com/apache/solr/pull/1158#issuecomment-1329890210
Can you please summarize the changes into a proposed commit message? I wish
GitHub built this into the PR so that we could review it as it's rather
important. If you start listing lots of
dsmiley commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1034143179
##
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##
@@ -261,23 +259,22 @@ private NamedList getIndexVersion(SolrClient s)
throws Exception {
David Smiley created SOLR-16563:
---
Summary: Http2SolrClient should have a defaultCollection setting
Key: SOLR-16563
URL: https://issues.apache.org/jira/browse/SOLR-16563
Project: Solr
Issue Type
risdenk commented on PR #1149:
URL: https://github.com/apache/solr/pull/1149#issuecomment-1329723507
My concern was along the lines of the newly added `collection1` stuff in
this PR specifically.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
epugh commented on PR #1149:
URL: https://github.com/apache/solr/pull/1149#issuecomment-1329716560
> So I see `DEFAULT_COLLECTION` used in a few places and `collection1`
hardcoded in others. I think I prefer `DEFAULT_COLLECTION` if possible to avoid
hard coding `collection1`?
so, `DE
[
https://issues.apache.org/jira/browse/SOLR-16562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640229#comment-17640229
]
Ben Manes commented on SOLR-16562:
--
To clarify, the change is to detect keys that were m
[
https://issues.apache.org/jira/browse/SOLR-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640221#comment-17640221
]
Kevin Risden commented on SOLR-16489:
-
Based on the PR - I opened SOLR-16562 to upgra
risdenk commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1329636763
I opened SOLR-16562 to upgrade to Caffeine 3.1.2 which will detect infinite
loops (not fix the issue).
--
This is an automated message from the Apache Git Service.
To respond to the messag
Kevin Risden created SOLR-16562:
---
Summary: Upgrade to Caffeine 3.1.2
Key: SOLR-16562
URL: https://issues.apache.org/jira/browse/SOLR-16562
Project: Solr
Issue Type: Task
Security Level: P
risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1033664796
##
solr/core/src/test/org/apache/solr/search/TestSmileRequest.java:
##
@@ -91,7 +90,6 @@ public void assertJQ(SolrClient client, SolrParams args,
String... tests)
// a
[
https://issues.apache.org/jira/browse/SOLR-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16553:
Fix Version/s: 9.2
> SolrTestCaseJ4 solr.install.dir property not initialized
> --
[
https://issues.apache.org/jira/browse/SOLR-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16553:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> SolrTestCaseJ4 solr.install.d
[
https://issues.apache.org/jira/browse/SOLR-16508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16508:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Upgrade gradle wrapper to 7.6
[
https://issues.apache.org/jira/browse/SOLR-16508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16508:
Fix Version/s: 9.2
> Upgrade gradle wrapper to 7.6
> -
>
>
risdenk commented on PR #1157:
URL: https://github.com/apache/solr/pull/1157#issuecomment-1329531038
backported to branch_9x as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/SOLR-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16559:
Fix Version/s: 9.2
> Fix benchmark module warnings/errors
>
>
[
https://issues.apache.org/jira/browse/SOLR-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16559:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Fix benchmark module warnings/
[
https://issues.apache.org/jira/browse/SOLR-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640175#comment-17640175
]
ASF subversion and git services commented on SOLR-16559:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-16508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640173#comment-17640173
]
ASF subversion and git services commented on SOLR-16508:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640174#comment-17640174
]
ASF subversion and git services commented on SOLR-16553:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16559:
Fix Version/s: main (10.0)
> Fix benchmark module warnings/errors
> ---
[
https://issues.apache.org/jira/browse/SOLR-16508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16508:
Fix Version/s: main (10.0)
> Upgrade gradle wrapper to 7.6
> -
>
>
[
https://issues.apache.org/jira/browse/SOLR-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16553:
Fix Version/s: main (10.0)
> SolrTestCaseJ4 solr.install.dir property not initialized
> --
[
https://issues.apache.org/jira/browse/SOLR-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640170#comment-17640170
]
ASF subversion and git services commented on SOLR-16559:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-16553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640169#comment-17640169
]
ASF subversion and git services commented on SOLR-16553:
Commit f
risdenk merged PR #1185:
URL: https://github.com/apache/solr/pull/1185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk commented on PR #1157:
URL: https://github.com/apache/solr/pull/1157#issuecomment-1329509900
@justinrsweeney yup merged to main and will backport to branch_9x shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
[
https://issues.apache.org/jira/browse/SOLR-16508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640163#comment-17640163
]
ASF subversion and git services commented on SOLR-16508:
Commit 9
risdenk merged PR #1147:
URL: https://github.com/apache/solr/pull/1147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk merged PR #1157:
URL: https://github.com/apache/solr/pull/1157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
janhoy commented on code in PR #1185:
URL: https://github.com/apache/solr/pull/1185#discussion_r1033841038
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -476,18 +479,22 @@ private void addFoldersToSharedLib(Set libDirs) {
// Adds modules to shared classp
risdenk commented on code in PR #1185:
URL: https://github.com/apache/solr/pull/1185#discussion_r1033834782
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -476,18 +479,22 @@ private void addFoldersToSharedLib(Set libDirs) {
// Adds modules to shared class
epugh commented on PR #1149:
URL: https://github.com/apache/solr/pull/1149#issuecomment-1329433986
@joshgog I'm going to mark this as Ready for Review ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
epugh commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1033801926
##
solr/core/src/test/org/apache/solr/update/TestInPlaceUpdatesDistrib.java:
##
@@ -1489,6 +1489,12 @@ private String getBaseUrl(String id) {
return slice.getLeader().g
epugh commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1033741853
##
solr/core/src/test/org/apache/solr/servlet/CacheHeaderTest.java:
##
@@ -59,7 +59,7 @@ public void testCacheVetoHandler() throws Exception {
f.getCanonicalPat
epugh commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1033740581
##
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##
@@ -261,23 +259,22 @@ private NamedList getIndexVersion(SolrClient s)
throws Exception {
justinrsweeney commented on PR #1157:
URL: https://github.com/apache/solr/pull/1157#issuecomment-1329354130
@risdenk Thanks for approving, is this something we could merge into main
and also backport to branch_9x?
--
This is an automated message from the Apache Git Service.
To respond to
risdenk commented on code in PR #1185:
URL: https://github.com/apache/solr/pull/1185#discussion_r1033716691
##
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##
@@ -476,18 +479,22 @@ private void addFoldersToSharedLib(Set libDirs) {
// Adds modules to shared class
risdenk commented on PR #1147:
URL: https://github.com/apache/solr/pull/1147#issuecomment-1329313363
This is ready to go - the jdk 19 stuff is unrelated to Gradle itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
epugh commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1033692635
##
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##
@@ -261,23 +259,22 @@ private NamedList getIndexVersion(SolrClient s)
throws Exception {
[
https://issues.apache.org/jira/browse/SOLR-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640105#comment-17640105
]
Kevin Risden commented on SOLR-16427:
-
Thanks [~rcmuir] - I've been following along o
[
https://issues.apache.org/jira/browse/SOLR-16508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640098#comment-17640098
]
Kevin Risden commented on SOLR-16508:
-
7.6 was released: https://github.com/gradle/gr
[
https://issues.apache.org/jira/browse/SOLR-16508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16508:
Description:
To upgrade the build system to the latest gradle version, I ran the following
command
[
https://issues.apache.org/jira/browse/SOLR-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640097#comment-17640097
]
Jason Gerlowski commented on SOLR-11029:
Really glad Josh's REPLACENODE example w
[
https://issues.apache.org/jira/browse/SOLR-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640095#comment-17640095
]
Jason Gerlowski commented on SOLR-16488:
Hi Josh - sorry for the delay in getting
[
https://issues.apache.org/jira/browse/SOLR-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640081#comment-17640081
]
Jason Gerlowski commented on SOLR-16397:
Great, thanks for picking it up [~aalbah
[
https://issues.apache.org/jira/browse/SOLR-15749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-15749.
Fix Version/s: main (10.0)
9.2
Resolution: Fixed
Thanks everyone
[
https://issues.apache.org/jira/browse/SOLR-15749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640073#comment-17640073
]
ASF subversion and git services commented on SOLR-15749:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-16555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16555:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> SolrIndexSearcher - FilterCach
[
https://issues.apache.org/jira/browse/SOLR-16555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16555:
Fix Version/s: 9.2
> SolrIndexSearcher - FilterCache intersections/andNot should not clone bitsets
[
https://issues.apache.org/jira/browse/SOLR-16555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640071#comment-17640071
]
ASF subversion and git services commented on SOLR-16555:
Commit 9
risdenk merged PR #1186:
URL: https://github.com/apache/solr/pull/1186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-16555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16555:
Fix Version/s: 8.11.3
> SolrIndexSearcher - FilterCache intersections/andNot should not clone bitse
[
https://issues.apache.org/jira/browse/SOLR-16555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640070#comment-17640070
]
ASF subversion and git services commented on SOLR-16555:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-15749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640069#comment-17640069
]
Jason Gerlowski commented on SOLR-15749:
Not quite [~epugh]; I've been keeping th
[
https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski resolved SOLR-11028.
Fix Version/s: main (10.0)
9.2
Resolution: Fixed
> Create a v2 AP
[
https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640065#comment-17640065
]
Jason Gerlowski commented on SOLR-11028:
Alright, all's-well-that-ends-well. Tha
[
https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski reassigned SOLR-11028:
--
Assignee: Jason Gerlowski
> Create a v2 API equivalent for REPLACENODE API
> -
[
https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640064#comment-17640064
]
ASF subversion and git services commented on SOLR-11028:
Commit 8
[
https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640063#comment-17640063
]
ASF subversion and git services commented on SOLR-11028:
Commit 1
sonatype-lift[bot] commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1033591963
##
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
##
@@ -2841,8 +2836,9 @@ static CollectionAdminResponse getStatusRespo
dsmiley commented on code in PR #1149:
URL: https://github.com/apache/solr/pull/1149#discussion_r1033551745
##
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java:
##
@@ -92,7 +90,7 @@
*
* @since 1.4
*/
-@Nightly
+// @Nightly
Review Comment:
Not on p
[
https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640048#comment-17640048
]
Jason Gerlowski commented on SOLR-11028:
Ooh, thanks for catching this [~bszabo97
[
https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640045#comment-17640045
]
ASF subversion and git services commented on SOLR-11028:
Commit 7
gerlowskija merged PR #1053:
URL: https://github.com/apache/solr/pull/1053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apach
[
https://issues.apache.org/jira/browse/SOLR-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640042#comment-17640042
]
ASF subversion and git services commented on SOLR-16392:
Commit f
67 matches
Mail list logo
