[GitHub] [solr] gerlowskija commented on a diff in pull request #1080: SOLR 15749 created a v2 equivalent of v1 'rename'

2022-11-08 Thread GitBox
gerlowskija commented on code in PR #1080: URL: https://github.com/apache/solr/pull/1080#discussion_r1017074323 ## solr/core/src/java/org/apache/solr/handler/admin/api/RenameCollectionAPI.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[jira] [Commented] (SOLR-16530) Performance degradation due to eliminating noggit Writeable

2022-11-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630784#comment-17630784 ] Noble Paul commented on SOLR-16530: --- thanks [~ichattopadhyaya]    I'm investigating t

[jira] [Assigned] (SOLR-16530) Performance degradation due to eliminating noggit Writeable

2022-11-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul reassigned SOLR-16530: - Assignee: Noble Paul > Performance degradation due to eliminating noggit Writeable > ---

[jira] [Created] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2022-11-08 Thread Ishan Chattopadhyaya (Jira)
Ishan Chattopadhyaya created SOLR-16531: --- Summary: Performance degradation due to introduction of JAX-RS Key: SOLR-16531 URL: https://issues.apache.org/jira/browse/SOLR-16531 Project: Solr

[jira] [Commented] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2022-11-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630764#comment-17630764 ] Ishan Chattopadhyaya commented on SOLR-16531: - Marking this as 9.2 blocker.

[jira] [Updated] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2022-11-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-16531: Fix Version/s: 9.2 > Performance degradation due to introduction of JAX-RS > --

[jira] [Created] (SOLR-16530) Performance degradation due to eliminating noggit Writeable

2022-11-08 Thread Ishan Chattopadhyaya (Jira)
Ishan Chattopadhyaya created SOLR-16530: --- Summary: Performance degradation due to eliminating noggit Writeable Key: SOLR-16530 URL: https://issues.apache.org/jira/browse/SOLR-16530 Project: Solr

[jira] [Commented] (SOLR-16530) Performance degradation due to eliminating noggit Writeable

2022-11-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630763#comment-17630763 ] Ishan Chattopadhyaya commented on SOLR-16530: - Marking as 9.2 blocker. > Per

[jira] [Updated] (SOLR-16530) Performance degradation due to eliminating noggit Writeable

2022-11-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-16530: Fix Version/s: 9.2 > Performance degradation due to eliminating noggit Writeable >

[jira] [Commented] (SOLR-16528) Jaegertracer module must include okhttp3 dependency

2022-11-08 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630752#comment-17630752 ] David Smiley commented on SOLR-16528: - Interestingly, I am trying this tonight on Sol

[GitHub] [solr] AAnakhe commented on a diff in pull request #1080: SOLR 15749 created a v2 equivalent of v1 'rename'

2022-11-08 Thread GitBox
AAnakhe commented on code in PR #1080: URL: https://github.com/apache/solr/pull/1080#discussion_r1017416496 ## solr/core/src/test/org/apache/solr/handler/admin/api/V2CollectionAPIMappingTest.java: ## @@ -87,13 +96,15 @@ public void testGetCollectionStatus() throws Exception {

[GitHub] [solr] risdenk commented on a diff in pull request #1154: SOLR-16496: provide option for Query Elevation Component to bypass filters

2022-11-08 Thread GitBox
risdenk commented on code in PR #1154: URL: https://github.com/apache/solr/pull/1154#discussion_r1017332836 ## solr/core/src/test/org/apache/solr/search/QueryUtilsTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[GitHub] [solr-site] janhoy merged pull request #82: SOLR-16518 Add security.txt to website

2022-11-08 Thread GitBox
janhoy merged PR #82: URL: https://github.com/apache/solr-site/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] joel-bernstein commented on pull request #1161: SOLR-15733: Separate out a solrj-streaming module (#1099)

2022-11-08 Thread GitBox
joel-bernstein commented on PR #1161: URL: https://github.com/apache/solr/pull/1161#issuecomment-1307806387 So lets merge this and then I'll do PR for the changes.txt -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] gerlowskija commented on pull request #1115: SOLR-11028: Created V2 equivalent of REPLACENODE

2022-11-08 Thread GitBox
gerlowskija commented on PR #1115: URL: https://github.com/apache/solr/pull/1115#issuecomment-1307789226 Ah, I was just coming back here to close the loop but I see Houston beat me to it. There is a distinction between the APIs that include `/commands` in the path and those that don'

[GitHub] [solr] rseitz commented on a diff in pull request #1154: SOLR-16496: provide option for Query Elevation Component to bypass filters

2022-11-08 Thread GitBox
rseitz commented on code in PR #1154: URL: https://github.com/apache/solr/pull/1154#discussion_r1017054253 ## solr/core/src/test/org/apache/solr/search/QueryUtilsTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

[GitHub] [solr] gerlowskija commented on a diff in pull request #1080: SOLR 15749 created a v2 equivalent of v1 'rename'

2022-11-08 Thread GitBox
gerlowskija commented on code in PR #1080: URL: https://github.com/apache/solr/pull/1080#discussion_r1017025758 ## solr/core/src/test/org/apache/solr/handler/admin/api/V2CollectionAPIMappingTest.java: ## @@ -87,13 +96,15 @@ public void testGetCollectionStatus() throws Exception

[GitHub] [solr] rseitz commented on a diff in pull request #1154: SOLR-16496: provide option for Query Elevation Component to bypass filters

2022-11-08 Thread GitBox
rseitz commented on code in PR #1154: URL: https://github.com/apache/solr/pull/1154#discussion_r1017024804 ## solr/core/src/test/org/apache/solr/search/QueryUtilsTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

[GitHub] [solr] jeanielamwh commented on a diff in pull request #1067: SOLR-16409: Admin UI - Expose all highlighting parameters in the Query UI

2022-11-08 Thread GitBox
jeanielamwh commented on code in PR #1067: URL: https://github.com/apache/solr/pull/1067#discussion_r1017018072 ## solr/webapp/web/js/angular/controllers/query.js: ## @@ -169,6 +169,9 @@ solrAdminApp.controller('QueryController', purgeParams(params, ["q.alt", "qf", "mm",

[jira] [Commented] (SOLR-16393) Cosmetic, REST-fulness improvements to v2 alias, alias-prop CRUD APIs

2022-11-08 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630571#comment-17630571 ] Jason Gerlowski commented on SOLR-16393: Yep - they're all still available; go fo

[jira] [Commented] (SOLR-16527) RuleBasedAuthorizationPluginBase NPE

2022-11-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630569#comment-17630569 ] Jan Høydahl commented on SOLR-16527: Sure, no prob for me :)  > RuleBasedAuthorizati

[GitHub] [solr] dsmiley commented on a diff in pull request #1154: SOLR-16496: provide option for Query Elevation Component to bypass filters

2022-11-08 Thread GitBox
dsmiley commented on code in PR #1154: URL: https://github.com/apache/solr/pull/1154#discussion_r1017006252 ## solr/core/src/test/org/apache/solr/search/QueryUtilsTest.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[GitHub] [solr-operator] HoustonPutman opened a new pull request, #496: Upgrade Ginkgo and EnvTest

2022-11-08 Thread GitBox
HoustonPutman opened a new pull request, #496: URL: https://github.com/apache/solr-operator/pull/496 With upgrading EnvTest, we have a much easier setup for tests! Ginkgo we are upgrading to v2, which has small back-incompatabilities. -- This is an automated message from the Apache

[GitHub] [solr] rseitz commented on a diff in pull request #1154: SOLR-16496: provide option for Query Elevation Component to bypass filters

2022-11-08 Thread GitBox
rseitz commented on code in PR #1154: URL: https://github.com/apache/solr/pull/1154#discussion_r1016977516 ## solr/core/src/java/org/apache/solr/handler/component/QueryElevationComponent.java: ## @@ -553,6 +560,82 @@ private void setQuery(ResponseBuilder rb, Elevation elevation

[jira] [Commented] (SOLR-16529) Upgrade jaeger to 1.8.1

2022-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630558#comment-17630558 ] ASF subversion and git services commented on SOLR-16529: Commit c

[jira] [Resolved] (SOLR-16529) Upgrade jaeger to 1.8.1

2022-11-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16529. Fix Version/s: 9.2 Resolution: Fixed > Upgrade jaeger to 1.8.1 > --- > >

[GitHub] [solr] gerlowskija commented on a diff in pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-11-08 Thread GitBox
gerlowskija commented on code in PR #1126: URL: https://github.com/apache/solr/pull/1126#discussion_r1016898284 ## solr/core/src/test/org/apache/solr/handler/admin/api/CoreSnapshotAPITest.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Commented] (SOLR-16527) RuleBasedAuthorizationPluginBase NPE

2022-11-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630535#comment-17630535 ] Kevin Risden commented on SOLR-16527: - [~janhoy] yea technically true on changes.txt

[GitHub] [solr] risdenk commented on pull request #1161: SOLR-15733: Separate out a solrj-streaming module (#1099)

2022-11-08 Thread GitBox
risdenk commented on PR #1161: URL: https://github.com/apache/solr/pull/1161#issuecomment-1307566851 @joel-bernstein I think so. Need a change on main and branch_9x for changes.txt and `solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc` I think? -- This is an

[jira] [Commented] (SOLR-16529) Upgrade jaeger to 1.8.1

2022-11-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630529#comment-17630529 ] ASF subversion and git services commented on SOLR-16529: Commit 6

[GitHub] [solr] janhoy merged pull request #1167: SOLR-16529 Upgrade jaeger-client to 1.8.1

2022-11-08 Thread GitBox
janhoy merged PR #1167: URL: https://github.com/apache/solr/pull/1167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] HoustonPutman commented on pull request #1115: SOLR-11028: Created V2 equivalent of REPLACENODE

2022-11-08 Thread GitBox
HoustonPutman commented on PR #1115: URL: https://github.com/apache/solr/pull/1115#issuecomment-1307468029 So Jason and I talked offline and cleared up our misunderstandings 🙂 I didn't know that the API spreadsheet had multiple tabs 😅 Overall I prefer the consistency of the user expe

[jira] [Commented] (SOLR-16523) gosu binary version

2022-11-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630501#comment-17630501 ] Jan Høydahl commented on SOLR-16523: Gosu is not used by solr, but it is a tool (repl

[GitHub] [solr] janhoy opened a new pull request, #1167: SOLR-16529 Upgrade jaeger-client to 1.8.1

2022-11-08 Thread GitBox
janhoy opened a new pull request, #1167: URL: https://github.com/apache/solr/pull/1167 https://issues.apache.org/jira/browse/SOLR-16529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [solr-operator] HoustonPutman merged pull request #491: Upgrade go dependencies

2022-11-08 Thread GitBox
HoustonPutman merged PR #491: URL: https://github.com/apache/solr-operator/pull/491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[GitHub] [solr-operator] HoustonPutman closed issue #487: CVE Security Vulnerabilities

2022-11-08 Thread GitBox
HoustonPutman closed issue #487: CVE Security Vulnerabilities URL: https://github.com/apache/solr-operator/issues/487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Created] (SOLR-16529) Upgrade jaeger to 1.8.1

2022-11-08 Thread Jira
Jan Høydahl created SOLR-16529: -- Summary: Upgrade jaeger to 1.8.1 Key: SOLR-16529 URL: https://issues.apache.org/jira/browse/SOLR-16529 Project: Solr Issue Type: Task Security Level: Publi

[GitHub] [solr] gerlowskija commented on pull request #1126: SOLR-16462: Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (core level)

2022-11-08 Thread GitBox
gerlowskija commented on PR #1126: URL: https://github.com/apache/solr/pull/1126#issuecomment-1307420832 > If we're still waiting on item 1, I'll go ahead and take a stab at the async code. Alright, thanks for grabbing that! On item (1), I think the conclusion on that `dev@` thread

[GitHub] [solr] gerlowskija commented on a diff in pull request #1053: SOLR-16392: Refactor and update v2 DELETEREPLICAPROP API

2022-11-08 Thread GitBox
gerlowskija commented on code in PR #1053: URL: https://github.com/apache/solr/pull/1053#discussion_r1016750781 ## solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java: ## @@ -1298,19 +1298,25 @@ public Map execute( V2ApiUtils.squashIntoSolrRespons

[GitHub] [solr] gerlowskija commented on a diff in pull request #1053: SOLR-16392: Refactor and update v2 DELETEREPLICAPROP API

2022-11-08 Thread GitBox
gerlowskija commented on code in PR #1053: URL: https://github.com/apache/solr/pull/1053#discussion_r1016747436 ## solr/core/src/test/org/apache/solr/handler/admin/api/DeleteReplicaPropertyAPITest.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [solr] gerlowskija commented on a diff in pull request #1053: SOLR-16392: Refactor and update v2 DELETEREPLICAPROP API

2022-11-08 Thread GitBox
gerlowskija commented on code in PR #1053: URL: https://github.com/apache/solr/pull/1053#discussion_r1016747436 ## solr/core/src/test/org/apache/solr/handler/admin/api/DeleteReplicaPropertyAPITest.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Created] (SOLR-16528) Jaegertracer module must include okhttp3 dependency

2022-11-08 Thread Jira
Jan Høydahl created SOLR-16528: -- Summary: Jaegertracer module must include okhttp3 dependency Key: SOLR-16528 URL: https://issues.apache.org/jira/browse/SOLR-16528 Project: Solr Issue Type: Bug

[jira] [Updated] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2022-11-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16457: Attachment: fix_security_symlinks-1.patch > solr.data.home should not be set to empty string in bin

[jira] [Updated] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2022-11-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16457: Attachment: (was: fix_security_symlinks-1.patch) > solr.data.home should not be set to empty st

[jira] [Comment Edited] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2022-11-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630455#comment-17630455 ] Shawn Heisey edited comment on SOLR-16457 at 11/8/22 2:36 PM: -

[jira] [Commented] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2022-11-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630455#comment-17630455 ] Shawn Heisey commented on SOLR-16457: - Attached an updated patch to fix the symlinks.

[jira] [Updated] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2022-11-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shawn Heisey updated SOLR-16457: Attachment: fix_security_symlinks-1.patch > solr.data.home should not be set to empty string in bin

[jira] [Updated] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2022-11-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16457: Attachment: fix_security_symlinks.patch > solr.data.home should not be set to empty string in bin/s

[jira] [Commented] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2022-11-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630450#comment-17630450 ] Kevin Risden commented on SOLR-16457: - attaching a patch [~elyograg] sent about using

[GitHub] [solr] joel-bernstein commented on pull request #1161: SOLR-15733: Separate out a solrj-streaming module (#1099)

2022-11-08 Thread GitBox
joel-bernstein commented on PR #1161: URL: https://github.com/apache/solr/pull/1161#issuecomment-1307234579 Ready to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (SOLR-16523) gosu binary version

2022-11-08 Thread Ritchie Gu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630416#comment-17630416 ] Ritchie Gu commented on SOLR-16523: --- Hi [~janhoy] , our use case is very straightforwar

[jira] [Commented] (SOLR-16527) RuleBasedAuthorizationPluginBase NPE

2022-11-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630304#comment-17630304 ] Jan Høydahl commented on SOLR-16527: Thanks Alex and Kevin. PS: It's not necessary w

[jira] [Commented] (SOLR-16523) gosu binary version

2022-11-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630281#comment-17630281 ] Jan Høydahl commented on SOLR-16523: I asked Martijn the same question at some point