risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011120330
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleStreamingBinaryTest.java:
##
@@ -35,9 +34,15 @@ public class SolrExampleStreamingBinaryTest extends
epugh commented on PR #1158:
URL: https://github.com/apache/solr/pull/1158#issuecomment-1299471494
If this all looks in the right direction, then I can tackle
`Http2SolrClient` and `ConcurrentUpdateHttp2SolrClient`, moving them to builder
pattern.
--
This is an automated message from the
epugh commented on PR #1158:
URL: https://github.com/apache/solr/pull/1158#issuecomment-1299465793
Can't figure out how to use builder pattern in `TestSmileRequest` ;-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
epugh commented on PR #1158:
URL: https://github.com/apache/solr/pull/1158#issuecomment-1299363456
I'd love another set of eyes on eb13c64057c000326087915e5810c3eea5339adf
@risdenk, I *think* I simplified the test which meant I could remove the
`setParser` code... But maybe I lost what th
epugh commented on code in PR #1053:
URL: https://github.com/apache/solr/pull/1053#discussion_r1010962959
##
solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java:
##
@@ -1298,19 +1298,25 @@ public Map execute(
V2ApiUtils.squashIntoSolrResponseWitho
dsmiley commented on code in PR #1053:
URL: https://github.com/apache/solr/pull/1053#discussion_r1010941513
##
solr/core/src/test/org/apache/solr/handler/admin/api/DeleteReplicaPropertyAPITest.java:
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
epugh commented on PR #1158:
URL: https://github.com/apache/solr/pull/1158#issuecomment-1299286090
@risdenk I'd love some input on the way I did deprecation. Since the whole
class is kind of deprecated, I didn't provide a bunch of `@deprecation` in the
javadocs, or add the `since` tag...
[
https://issues.apache.org/jira/browse/SOLR-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627331#comment-17627331
]
Torsten Bøgh Köster commented on SOLR-16497:
[~dsmiley] take your time, the c
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1010874223
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java:
##
@@ -46,6 +49,16 @@ public B withResponseParser(ResponseParser responseParser) {
retu
HoustonPutman merged PR #80:
URL: https://github.com/apache/solr-site/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.ap
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1010870504
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleStreamingBinaryTest.java:
##
@@ -35,9 +34,15 @@ public class SolrExampleStreamingBinaryTest extends
sonatype-lift[bot] commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1010832334
##
solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java:
##
@@ -156,8 +160,7 @@ public synchronized SolrClient getSolrClient() {
public SolrCl
risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1010801052
##
solr/solrj/src/test/org/apache/solr/client/solrj/SolrSchemalessExampleTest.java:
##
@@ -130,20 +130,18 @@ public void testFieldMutating() throws Exception {
@Overr
epugh opened a new pull request, #1158:
URL: https://github.com/apache/solr/pull/1158
https://issues.apache.org/jira/browse/SOLR-16368
# Description
Part of working on reducing the use of legacy `HttpSolrClient` in the tests
everywhere is seeing if mutating the client can b
justinrsweeney opened a new pull request, #1157:
URL: https://github.com/apache/solr/pull/1157
https://issues.apache.org/jira/browse/SOLR-16516
# Description
This change modifies the Github Actions to execute on any PR opened against
any branch, including branches with a `/` in
Justin Sweeney created SOLR-16516:
-
Summary: Execute Github Action for Gradle Checks on All PRs
Key: SOLR-16516
URL: https://issues.apache.org/jira/browse/SOLR-16516
Project: Solr
Issue Type:
[
https://issues.apache.org/jira/browse/SOLR-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627281#comment-17627281
]
David Smiley commented on SOLR-16514:
-
BTW, very recently, Lucene stopped using JIRA;
[
https://issues.apache.org/jira/browse/SOLR-16496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627278#comment-17627278
]
David Smiley commented on SOLR-16496:
-
We can debate the top-level query parameter's
[
https://issues.apache.org/jira/browse/SOLR-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627271#comment-17627271
]
Eric Pugh commented on SOLR-5776:
-
Just stumbled over this ticket... [~janhoy] if you
joshgog commented on code in PR #1080:
URL: https://github.com/apache/solr/pull/1080#discussion_r1010708916
##
solr/core/src/test/org/apache/solr/handler/admin/api/V2CollectionAPIMappingTest.java:
##
@@ -87,13 +96,15 @@ public void testGetCollectionStatus() throws Exception {
joshgog commented on code in PR #1080:
URL: https://github.com/apache/solr/pull/1080#discussion_r1010708916
##
solr/core/src/test/org/apache/solr/handler/admin/api/V2CollectionAPIMappingTest.java:
##
@@ -87,13 +96,15 @@ public void testGetCollectionStatus() throws Exception {
[
https://issues.apache.org/jira/browse/SOLR-16496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627263#comment-17627263
]
Rudi Seitz commented on SOLR-16496:
---
Thanks for the feedback [~dsmiley]
Here is th
[
https://issues.apache.org/jira/browse/SOLR-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-10368.
---
Assignee: (was: Cao Manh Dat)
Resolution: Cannot Reproduce
The test currently is ra
[
https://issues.apache.org/jira/browse/SOLR-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16497:
Status: Patch Available (was: Open)
> Allow finer grained locking in SolrCores
> -
[
https://issues.apache.org/jira/browse/SOLR-16515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16515:
Status: Patch Available (was: Open)
> Remove synchronized access to cachedOrdMaps in SlowComposite
[
https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627238#comment-17627238
]
Joel Bernstein commented on SOLR-15733:
---
Ok, will do.
> Separate out a solrj-strea
[
https://issues.apache.org/jira/browse/SOLR-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627220#comment-17627220
]
David Smiley commented on SOLR-16497:
-
I'm definitely interested, as I expect [~brous
[
https://issues.apache.org/jira/browse/SOLR-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley reassigned SOLR-16497:
---
Assignee: David Smiley
> Allow finer grained locking in SolrCores
>
[
https://issues.apache.org/jira/browse/SOLR-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627217#comment-17627217
]
Nicola Paganotti commented on SOLR-16514:
-
I filled for Sole project because I'm
[
https://issues.apache.org/jira/browse/SOLR-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-16514.
-
Resolution: Invalid
Hello. You filed this issue for the Solr project but it appears it should ha
[
https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627206#comment-17627206
]
David Smiley commented on SOLR-15733:
-
BTW, next time remember to tidy up the commit
dsmiley commented on code in PR #80:
URL: https://github.com/apache/solr-site/pull/80#discussion_r1010529249
##
content/pages/security.md:
##
@@ -4,9 +4,21 @@ save_as: security.html
template: security
## How to report a security issue
-If you believe you have discovered a vu
dsmiley commented on code in PR #80:
URL: https://github.com/apache/solr-site/pull/80#discussion_r1010526385
##
content/pages/security.md:
##
@@ -7,6 +7,9 @@ template: security
If you believe you have discovered a vulnerability in Solr, you may first want
to consult the [list
HoustonPutman commented on code in PR #80:
URL: https://github.com/apache/solr-site/pull/80#discussion_r1010523257
##
content/pages/security.md:
##
@@ -7,6 +7,9 @@ template: security
If you believe you have discovered a vulnerability in Solr, you may first want
to consult the
HoustonPutman commented on PR #80:
URL: https://github.com/apache/solr-site/pull/80#issuecomment-1298618072
Ok split up the dependency CVE and Solr exploits into separate sections.
hopefully its more clear?
--
This is an automated message from the Apache Git Service.
To respond to the mes
dsmiley commented on code in PR #80:
URL: https://github.com/apache/solr-site/pull/80#discussion_r1010507750
##
content/pages/security.md:
##
@@ -7,6 +7,9 @@ template: security
If you believe you have discovered a vulnerability in Solr, you may first want
to consult the [list
dsmiley commented on code in PR #80:
URL: https://github.com/apache/solr-site/pull/80#discussion_r1010506370
##
content/pages/security.md:
##
@@ -7,6 +7,9 @@ template: security
If you believe you have discovered a vulnerability in Solr, you may first want
to consult the [list
HoustonPutman commented on code in PR #80:
URL: https://github.com/apache/solr-site/pull/80#discussion_r1010502343
##
content/pages/security.md:
##
@@ -7,6 +7,9 @@ template: security
If you believe you have discovered a vulnerability in Solr, you may first want
to consult the
janhoy commented on issue #484:
URL: https://github.com/apache/solr-operator/issues/484#issuecomment-1298598915
Turned out it is supported already, but with a slightly different yaml
syntax:
```yaml
solr:
podOptions:
volumes:
# Map service account JWT token ont
janhoy closed issue #484: Support Projected Volume in Solr Pod spec
URL: https://github.com/apache/solr-operator/issues/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
janhoy commented on PR #485:
URL: https://github.com/apache/solr-operator/pull/485#issuecomment-1298597724
I tested the yaml above and it actually works - I now have the
`/var/run/secrets/tokens/sa-token` file in my pod! Closing this. Perhaps I'll
add another PR to document how to mount a p
janhoy closed pull request #485: Support for Projected Volume
URL: https://github.com/apache/solr-operator/pull/485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
HoustonPutman closed issue #472: Helm zk.provided.zookeeperPodPolicy
documentation issues
URL: https://github.com/apache/solr-operator/issues/472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
HoustonPutman commented on issue #472:
URL: https://github.com/apache/solr-operator/issues/472#issuecomment-1298594870
Closed in https://github.com/apache/solr-operator/pull/482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
HoustonPutman closed issue #479: Operator in CrashLoop with panic
URL: https://github.com/apache/solr-operator/issues/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
HoustonPutman merged PR #481:
URL: https://github.com/apache/solr-operator/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
HoustonPutman commented on PR #485:
URL: https://github.com/apache/solr-operator/pull/485#issuecomment-1298587121
But your PR is quite close, you've done a good job!
You would have had two steps left:
- Actually set the projected volume on the pods in the controller (you have
just
tboeghk opened a new pull request, #1156:
URL: https://github.com/apache/solr/pull/1156
https://issues.apache.org/jira/browse/SOLR-16515
The `SlowCompositeReaderWrapper` uses synchronized read and write access to
its internal `cachedOrdMaps`. By using a `ConcurrentHashMap` instead of
HoustonPutman commented on PR #485:
URL: https://github.com/apache/solr-operator/pull/485#issuecomment-1298581924
> Digging some more, I see that in the spec, `corev1.ProjectedVolumeSource`
is alredy a child of `corev1.VolumeSource`
Yeah it looks like that is the case! It sounds like
[
https://issues.apache.org/jira/browse/SOLR-16515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Torsten Bøgh Köster updated SOLR-16515:
---
Description:
The {{SlowCompositeReaderWrapper}} uses synchronized read and write ac
[
https://issues.apache.org/jira/browse/SOLR-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Torsten Bøgh Köster updated SOLR-16497:
---
Description:
Access to loaded SolrCore instances is a synchronized read and write ope
[
https://issues.apache.org/jira/browse/SOLR-16515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Torsten Bøgh Köster updated SOLR-16515:
---
Description:
The {{SlowCompositeReaderWrapper}} uses synchronized read and write ac
Torsten Bøgh Köster created SOLR-16515:
--
Summary: Remove synchronized access to cachedOrdMaps in
SlowCompositeReaderWrapper
Key: SOLR-16515
URL: https://issues.apache.org/jira/browse/SOLR-16515
P
janhoy commented on PR #485:
URL: https://github.com/apache/solr-operator/pull/485#issuecomment-1298538512
Digging some more, I see that in the spec, `corev1.ProjectedVolumeSource` is
alredy a child of `corev1.VolumeSource`, so perhaps this already is supported
by nesting `projected` inside
janhoy commented on PR #485:
URL: https://github.com/apache/solr-operator/pull/485#issuecomment-1298500481
The test output is
```
• Failure [1.304 seconds]
SolrCloud controller - General
/Users/janhoy/git/solr-operator/controllers/solrcloud_controller_test.go:35
Solr Clou
janhoy opened a new pull request, #485:
URL: https://github.com/apache/solr-operator/pull/485
This is my first attempt at a contribution to the operator, implementing
#484. But I cannot get the debugger working in IDEA so I'm not sure where it
goes wrong.
Fixes #484
--
This is an
[
https://issues.apache.org/jira/browse/SOLR-15733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627157#comment-17627157
]
ASF subversion and git services commented on SOLR-15733:
Commit d
joel-bernstein merged PR #1099:
URL: https://github.com/apache/solr/pull/1099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.ap
sonatype-lift[bot] commented on code in PR #1144:
URL: https://github.com/apache/solr/pull/1144#discussion_r1010410293
##
solr/core/src/java/org/apache/solr/handler/admin/api/ZookeeperAPI.java:
##
@@ -0,0 +1,280 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
janhoy commented on issue #484:
URL: https://github.com/apache/solr-operator/issues/484#issuecomment-1298419826
I'm not into the codebase or Go in general, but would like to attempt a PR
if I get some assistance. I'll post a PR with my WIP progress soon.
--
This is an automated message fr
tboeghk commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1298315534
@ben-manes we can confirm that your change with `3.1.2-SNAPSHOT` is working!
We removed our fix from the SolrCache and can confirm that no threads inside
Solr are spinning anymore. We
[
https://issues.apache.org/jira/browse/SOLR-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627057#comment-17627057
]
Torsten Bøgh Köster commented on SOLR-16497:
GitHub PR is finally done. Adopt
[
https://issues.apache.org/jira/browse/SOLR-16497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Torsten Bøgh Köster updated SOLR-16497:
---
Description:
Access to loaded SolrCore instances is a synchronized read and write ope
tboeghk opened a new pull request, #1155:
URL: https://github.com/apache/solr/pull/1155
https://issues.apache.org/jira/browse/SOLR-16497
Access to loaded `SolrCore` instances is a synchronized read and write
operation in `SolrCores#getCoreFromAnyList`. This method is touched by every
sonatype-lift[bot] commented on code in PR #1144:
URL: https://github.com/apache/solr/pull/1144#discussion_r1010266780
##
solr/core/src/java/org/apache/solr/handler/admin/api/ZookeeperAPI.java:
##
@@ -0,0 +1,287 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
joshgog commented on PR #1144:
URL: https://github.com/apache/solr/pull/1144#issuecomment-1298227224
> I have changed the response property to NamedList and the result I'm
getting is now
>
>
`{"responseHeader":{"status":0,"QTime":267},"zookeeperFiles":{"immutableCopy":{"immutableCopy
Nicola Paganotti created SOLR-16514:
---
Summary: lucene query: only QueryParser run well
Key: SOLR-16514
URL: https://issues.apache.org/jira/browse/SOLR-16514
Project: Solr
Issue Type: Task
AAnakhe commented on code in PR #1080:
URL: https://github.com/apache/solr/pull/1080#discussion_r1010192031
##
solr/core/src/test/org/apache/solr/handler/admin/api/V2CollectionAPIMappingTest.java:
##
@@ -87,13 +96,15 @@ public void testGetCollectionStatus() throws Exception {
AAnakhe commented on code in PR #1080:
URL: https://github.com/apache/solr/pull/1080#discussion_r1010155274
##
solr/core/src/test/org/apache/solr/handler/admin/api/V2CollectionAPIMappingTest.java:
##
@@ -87,13 +96,15 @@ public void testGetCollectionStatus() throws Exception {
69 matches
Mail list logo
